linux

mirror of https://github.com/torvalds/linux.git synced 2024-11-08 13:11:45 +00:00

History

Matt Fleming 123abd76ed efivars: efivarfs_valid_name() should handle pstore syntax Stricter validation was introduced with commit `da27a24383` ("efivarfs: guid part of filenames are case-insensitive") and commit `47f531e8ba` ("efivarfs: Validate filenames much more aggressively"), which is necessary for the guid portion of efivarfs filenames, but we don't need to be so strict with the first part, the variable name. The UEFI specification doesn't impose any constraints on variable names other than they be a NULL-terminated string. The above commits caused a regression that resulted in users seeing the following message, $ sudo mount -v /sys/firmware/efi/efivars mount: Cannot allocate memory whenever pstore EFI variables were present in the variable store, since their variable names failed to pass the following check, /* GUID should be right after the first '-' */ if (s - 1 != strchr(str, '-')) as a typical pstore filename is of the form, dump-type0-10-1-<guid>. The fix is trivial since the guid portion of the filename is GUID_LEN bytes, we can use (len - GUID_LEN) to ensure the '-' character is where we expect it to be. (The bogus ENOMEM error value will be fixed in a separate patch.) Reported-by: Joseph Yasi <joe.yasi@gmail.com> Tested-by: Joseph Yasi <joe.yasi@gmail.com> Reported-by: Lingzhu Xiang <lxiang@redhat.com> Cc: Josh Boyer <jwboyer@redhat.com> Cc: Jeremy Kerr <jk@ozlabs.org> Cc: Matthew Garrett <mjg59@srcf.ucam.org> Cc: <stable@vger.kernel.org> # v3.8 Signed-off-by: Matt Fleming <matt.fleming@intel.com>		2013-03-06 14:46:04 +00:00
..
breakpoints	breakpoint selftests: print failure status instead of cause make error	2012-12-17 17:15:27 -08:00
cpu-hotplug	cpu-hotplug selftests: print failure status instead of cause make error	2012-12-17 17:15:27 -08:00
efivarfs	efivars: efivarfs_valid_name() should handle pstore syntax	2013-03-06 14:46:04 +00:00
ipc	selftests: IPC message queue copy feature test	2013-01-04 16:11:45 -08:00
kcmp	tools/testing/selftests/kcmp/kcmp_test.c: print reason for failure in kcmp_test	2012-12-17 17:15:27 -08:00
memory-hotplug	mem-hotplug selftests: print failure status instead of cause make error	2012-12-17 17:15:27 -08:00
mqueue	mqueue selftests: print failure status instead of cause make error	2012-12-17 17:15:26 -08:00
vm	vm selftests: print failure status instead of cause make error	2012-12-17 17:15:26 -08:00
Makefile	tools/testing/selftests/Makefile: rearrange targets	2013-02-27 19:10:24 -08:00
README.txt	selftests: add a simple doc	2013-02-27 19:10:24 -08:00

README.txt

Linux Kernel Selftests

The kernel contains a set of "self tests" under the tools/testing/selftests/
directory. These are intended to be small unit tests to exercise individual
code paths in the kernel.

Running the selftests
=====================

To build the tests:

  $ make -C tools/testing/selftests


To run the tests:

  $ make -C tools/testing/selftests run_tests

- note that some tests will require root privileges.


To run only tests targetted for a single subsystem:

  $  make -C tools/testing/selftests TARGETS=cpu-hotplug run_tests

See the top-level tools/testing/selftests/Makefile for the list of all possible
targets.


Contributing new tests
======================

In general, the rules for for selftests are

 * Do as much as you can if you're not root;

 * Don't take too long;

 * Don't break the build on any architecture, and

 * Don't cause the top-level "make run_tests" to fail if your feature is
   unconfigured.