linux/drivers/scsi/mpt3sas
Stephan Günther 23c3828aa2 scsi: mpt3sas: fix memory ordering on 64bit writes
With commit 09c2f95ad4 ("scsi: mpt3sas: Swap I/O memory read value back
to cpu endianness"), 64bit writes in _base_writeq() were rewritten to use
__raw_writeq() instad of writeq().

This introduced a bug apparent on powerpc64 systems such as the Raptor
Talos II that causes the HBA to drop from the PCIe bus under heavy load and
being reinitialized after a couple of seconds.

It can easily be triggered on affacted systems by using something like

  fio --name=random-write --iodepth=4 --rw=randwrite --bs=4k --direct=0 \
    --size=128M --numjobs=64 --end_fsync=1
  fio --name=random-write --iodepth=4 --rw=randwrite --bs=64k --direct=0 \
    --size=128M --numjobs=64 --end_fsync=1

a couple of times. In my case I tested it on both a ZFS raidz2 and a btrfs
raid6 using LSI 9300-8i and 9400-8i controllers.

The fix consists in resembling the write ordering of writeq() by adding a
mandatory write memory barrier before device access and a compiler barrier
afterwards. The additional MMIO barrier is superfluous.

Signed-off-by: Stephan Günther <moepi@moepi.net>
Reported-by: Matt Corallo <linux@bluematt.me>
Acked-by: Sreekanth Reddy <Sreekanth.Reddy@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-12-19 21:31:41 -05:00
..
mpi scsi: mpt3sas: Update MPI headers to support Aero controllers 2018-11-06 20:16:01 -05:00
Kconfig mpt3sas: fix Kconfig dependency problem for mpt2sas back compatibility 2015-12-03 09:31:23 -08:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mpt3sas_base.c scsi: mpt3sas: fix memory ordering on 64bit writes 2018-12-19 21:31:41 -05:00
mpt3sas_base.h scsi: mpt3sas: Update driver version to 27.101.00.00 2018-12-12 21:29:07 -05:00
mpt3sas_config.c scsi: mpt3sas: fix spelling mistake "manufaucturing" -> "manufacturing" 2018-11-28 21:37:38 -05:00
mpt3sas_ctl.c scsi: mpt3sas: Separate out mpt3sas_wait_for_ioc 2018-11-06 20:16:01 -05:00
mpt3sas_ctl.h scsi: mpt3sas: Increase event log buffer to support 24 port HBA's. 2018-05-08 00:34:20 -04:00
mpt3sas_debug.h mpt2sas, mpt3sas: Remove SCSI_MPTXSAS_LOGGING entry from Kconfig 2015-11-11 18:31:14 -05:00
mpt3sas_scsih.c scsi: flip the default on use_clustering 2018-12-18 23:13:12 -05:00
mpt3sas_transport.c scsi: mpt3sas: Call sas_remove_host before removing the target devices 2018-11-06 20:16:01 -05:00
mpt3sas_trigger_diag.c scsi: mpt3sas: Convert uses of pr_<level> with MPT3SAS_FMT to ioc_<level> 2018-10-10 22:00:43 -04:00
mpt3sas_trigger_diag.h mpt2sas, mpt3sas: Update attribution language to Avago 2015-01-13 16:27:27 +01:00
mpt3sas_warpdrive.c scsi: mpt3sas: Convert uses of pr_<level> with MPT3SAS_FMT to ioc_<level> 2018-10-10 22:00:43 -04:00