mirror of
https://github.com/torvalds/linux.git
synced 2024-12-07 19:41:31 +00:00
8ceafbfa91
Pull DMA mask updates from Russell King: "This series cleans up the handling of DMA masks in a lot of drivers, fixing some bugs as we go. Some of the more serious errors include: - drivers which only set their coherent DMA mask if the attempt to set the streaming mask fails. - drivers which test for a NULL dma mask pointer, and then set the dma mask pointer to a location in their module .data section - which will cause problems if the module is reloaded. To counter these, I have introduced two helper functions: - dma_set_mask_and_coherent() takes care of setting both the streaming and coherent masks at the same time, with the correct error handling as specified by the API. - dma_coerce_mask_and_coherent() which resolves the problem of drivers forcefully setting DMA masks. This is more a marker for future work to further clean these locations up - the code which creates the devices really should be initialising these, but to fix that in one go along with this change could potentially be very disruptive. The last thing this series does is prise away some of Linux's addition to "DMA addresses are physical addresses and RAM always starts at zero". We have ARM LPAE systems where all system memory is above 4GB physical, hence having DMA masks interpreted by (eg) the block layers as describing physical addresses in the range 0..DMAMASK fails on these platforms. Santosh Shilimkar addresses this in this series; the patches were copied to the appropriate people multiple times but were ignored. Fixing this also gets rid of some ARM weirdness in the setup of the max*pfn variables, and brings ARM into line with every other Linux architecture as far as those go" * 'for-linus-dma-masks' of git://git.linaro.org/people/rmk/linux-arm: (52 commits) ARM: 7805/1: mm: change max*pfn to include the physical offset of memory ARM: 7797/1: mmc: Use dma_max_pfn(dev) helper for bounce_limit calculations ARM: 7796/1: scsi: Use dma_max_pfn(dev) helper for bounce_limit calculations ARM: 7795/1: mm: dma-mapping: Add dma_max_pfn(dev) helper function ARM: 7794/1: block: Rename parameter dma_mask to max_addr for blk_queue_bounce_limit() ARM: DMA-API: better handing of DMA masks for coherent allocations ARM: 7857/1: dma: imx-sdma: setup dma mask DMA-API: firmware/google/gsmi.c: avoid direct access to DMA masks DMA-API: dcdbas: update DMA mask handing DMA-API: dma: edma.c: no need to explicitly initialize DMA masks DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks DMA-API: crypto: remove last references to 'static struct device *dev' DMA-API: crypto: fix ixp4xx crypto platform device support DMA-API: others: use dma_set_coherent_mask() DMA-API: staging: use dma_set_coherent_mask() DMA-API: usb: use new dma_coerce_mask_and_coherent() DMA-API: usb: use dma_set_coherent_mask() DMA-API: parport: parport_pc.c: use dma_coerce_mask_and_coherent() DMA-API: net: octeon: use dma_coerce_mask_and_coherent() DMA-API: net: nxp/lpc_eth: use dma_coerce_mask_and_coherent() ...
199 lines
4.7 KiB
C
199 lines
4.7 KiB
C
/*
|
|
* Copyright 2012 Freescale Semiconductor, Inc.
|
|
* Copyright (C) 2012 Marek Vasut <marex@denx.de>
|
|
* on behalf of DENX Software Engineering GmbH
|
|
*
|
|
* The code contained herein is licensed under the GNU General Public
|
|
* License. You may obtain a copy of the GNU General Public License
|
|
* Version 2 or later at the following locations:
|
|
*
|
|
* http://www.opensource.org/licenses/gpl-license.html
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/of_gpio.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pm_runtime.h>
|
|
#include <linux/dma-mapping.h>
|
|
#include <linux/usb/chipidea.h>
|
|
#include <linux/clk.h>
|
|
|
|
#include "ci.h"
|
|
#include "ci_hdrc_imx.h"
|
|
|
|
struct ci_hdrc_imx_data {
|
|
struct usb_phy *phy;
|
|
struct platform_device *ci_pdev;
|
|
struct clk *clk;
|
|
struct imx_usbmisc_data *usbmisc_data;
|
|
};
|
|
|
|
/* Common functions shared by usbmisc drivers */
|
|
|
|
static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev)
|
|
{
|
|
struct device_node *np = dev->of_node;
|
|
struct of_phandle_args args;
|
|
struct imx_usbmisc_data *data;
|
|
int ret;
|
|
|
|
/*
|
|
* In case the fsl,usbmisc property is not present this device doesn't
|
|
* need usbmisc. Return NULL (which is no error here)
|
|
*/
|
|
if (!of_get_property(np, "fsl,usbmisc", NULL))
|
|
return NULL;
|
|
|
|
data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
|
|
if (!data)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
ret = of_parse_phandle_with_args(np, "fsl,usbmisc", "#index-cells",
|
|
0, &args);
|
|
if (ret) {
|
|
dev_err(dev, "Failed to parse property fsl,usbmisc, errno %d\n",
|
|
ret);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
data->index = args.args[0];
|
|
of_node_put(args.np);
|
|
|
|
if (of_find_property(np, "disable-over-current", NULL))
|
|
data->disable_oc = 1;
|
|
|
|
if (of_find_property(np, "external-vbus-divider", NULL))
|
|
data->evdo = 1;
|
|
|
|
return data;
|
|
}
|
|
|
|
/* End of common functions shared by usbmisc drivers*/
|
|
|
|
static int ci_hdrc_imx_probe(struct platform_device *pdev)
|
|
{
|
|
struct ci_hdrc_imx_data *data;
|
|
struct ci_hdrc_platform_data pdata = {
|
|
.name = "ci_hdrc_imx",
|
|
.capoffset = DEF_CAPOFFSET,
|
|
.flags = CI_HDRC_REQUIRE_TRANSCEIVER |
|
|
CI_HDRC_DISABLE_STREAMING,
|
|
};
|
|
int ret;
|
|
|
|
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
|
|
if (!data) {
|
|
dev_err(&pdev->dev, "Failed to allocate ci_hdrc-imx data!\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
data->usbmisc_data = usbmisc_get_init_data(&pdev->dev);
|
|
if (IS_ERR(data->usbmisc_data))
|
|
return PTR_ERR(data->usbmisc_data);
|
|
|
|
data->clk = devm_clk_get(&pdev->dev, NULL);
|
|
if (IS_ERR(data->clk)) {
|
|
dev_err(&pdev->dev,
|
|
"Failed to get clock, err=%ld\n", PTR_ERR(data->clk));
|
|
return PTR_ERR(data->clk);
|
|
}
|
|
|
|
ret = clk_prepare_enable(data->clk);
|
|
if (ret) {
|
|
dev_err(&pdev->dev,
|
|
"Failed to prepare or enable clock, err=%d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
data->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "fsl,usbphy", 0);
|
|
if (IS_ERR(data->phy)) {
|
|
ret = PTR_ERR(data->phy);
|
|
goto err_clk;
|
|
}
|
|
|
|
pdata.phy = data->phy;
|
|
|
|
ret = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
|
|
if (ret)
|
|
goto err_clk;
|
|
|
|
if (data->usbmisc_data) {
|
|
ret = imx_usbmisc_init(data->usbmisc_data);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "usbmisc init failed, ret=%d\n",
|
|
ret);
|
|
goto err_clk;
|
|
}
|
|
}
|
|
|
|
data->ci_pdev = ci_hdrc_add_device(&pdev->dev,
|
|
pdev->resource, pdev->num_resources,
|
|
&pdata);
|
|
if (IS_ERR(data->ci_pdev)) {
|
|
ret = PTR_ERR(data->ci_pdev);
|
|
dev_err(&pdev->dev,
|
|
"Can't register ci_hdrc platform device, err=%d\n",
|
|
ret);
|
|
goto err_clk;
|
|
}
|
|
|
|
if (data->usbmisc_data) {
|
|
ret = imx_usbmisc_init_post(data->usbmisc_data);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "usbmisc post failed, ret=%d\n",
|
|
ret);
|
|
goto disable_device;
|
|
}
|
|
}
|
|
|
|
platform_set_drvdata(pdev, data);
|
|
|
|
pm_runtime_no_callbacks(&pdev->dev);
|
|
pm_runtime_enable(&pdev->dev);
|
|
|
|
return 0;
|
|
|
|
disable_device:
|
|
ci_hdrc_remove_device(data->ci_pdev);
|
|
err_clk:
|
|
clk_disable_unprepare(data->clk);
|
|
return ret;
|
|
}
|
|
|
|
static int ci_hdrc_imx_remove(struct platform_device *pdev)
|
|
{
|
|
struct ci_hdrc_imx_data *data = platform_get_drvdata(pdev);
|
|
|
|
pm_runtime_disable(&pdev->dev);
|
|
ci_hdrc_remove_device(data->ci_pdev);
|
|
clk_disable_unprepare(data->clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id ci_hdrc_imx_dt_ids[] = {
|
|
{ .compatible = "fsl,imx27-usb", },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, ci_hdrc_imx_dt_ids);
|
|
|
|
static struct platform_driver ci_hdrc_imx_driver = {
|
|
.probe = ci_hdrc_imx_probe,
|
|
.remove = ci_hdrc_imx_remove,
|
|
.driver = {
|
|
.name = "imx_usb",
|
|
.owner = THIS_MODULE,
|
|
.of_match_table = ci_hdrc_imx_dt_ids,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(ci_hdrc_imx_driver);
|
|
|
|
MODULE_ALIAS("platform:imx-usb");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_DESCRIPTION("CI HDRC i.MX USB binding");
|
|
MODULE_AUTHOR("Marek Vasut <marex@denx.de>");
|
|
MODULE_AUTHOR("Richard Zhao <richard.zhao@freescale.com>");
|