mirror of
https://github.com/torvalds/linux.git
synced 2024-11-04 11:04:38 +00:00
2243a87d90
What the patch does: 1. Call pinmux_disable_setting ahead of pinmux_enable_setting each time pinctrl_select_state is called 2. Remove the HW disable operation in pinmux_disable_setting function. 3. Remove the disable ops in struct pinmux_ops 4. Remove all the disable ops users in current code base. Notes: 1. Great thanks for the suggestion from Linus, Tony Lindgren and Stephen Warren and Everyone that shared comments on this patch. 2. The patch also includes comment fixes from Stephen Warren. The reason why we do this: 1. To avoid duplicated calling of the enable_setting operation without disabling operation inbetween which will let the pin descriptor desc->mux_usecount increase monotonously. 2. The HW pin disable operation is not useful for any of the existing platforms. And this can be used to avoid the HW glitch after using the item #1 modification. In the following case, the issue can be reproduced: 1. There is a driver that need to switch pin state dynamically, e.g. between "sleep" and "default" state 2. The pin setting configuration in a DTS node may be like this: component a { pinctrl-names = "default", "sleep"; pinctrl-0 = <&a_grp_setting &c_grp_setting>; pinctrl-1 = <&b_grp_setting &c_grp_setting>; } The "c_grp_setting" config node is totally identical, maybe like following one: c_grp_setting: c_grp_setting { pinctrl-single,pins = <GPIO48 AF6>; } 3. When switching the pin state in the following official pinctrl sequence: pin = pinctrl_get(); state = pinctrl_lookup_state(wanted_state); pinctrl_select_state(state); pinctrl_put(); Test Result: 1. The switch is completed as expected, that is: the device's pin configuration is changed according to the description in the "wanted_state" group setting 2. The "desc->mux_usecount" of the corresponding pins in "c_group" is increased without being decreased, because the "desc" is for each physical pin while the setting is for each setting node in the DTS. Thus, if the "c_grp_setting" in pinctrl-0 is not disabled ahead of enabling "c_grp_setting" in pinctrl-1, the desc->mux_usecount will keep increasing without any chance to be decreased. According to the comments in the original code, only the setting, in old state but not in new state, will be "disabled" (calling pinmux_disable_setting), which is correct logic but not intact. We still need consider case that the setting is in both old state and new state. We can do this in the following two ways: 1. Avoid to "enable"(calling pinmux_enable_setting) the "same pin setting" repeatedly 2. "Disable"(calling pinmux_disable_setting) the "same pin setting", actually two setting instances, ahead of enabling them. Analysis: 1. The solution #2 is better because it can avoid too much iteration. 2. If we disable all of the settings in the old state and one of the setting(s) exist in the new state, the pins mux function change may happen when some SoC vendors defined the "pinctrl-single,function-off" in their DTS file. old_setting => disabled_setting => new_setting. 3. In the pinmux framework, when a pin state is switched, the setting in the old state should be marked as "disabled". Conclusion: 1. To Remove the HW disabling operation to above the glitch mentioned above. 2. Handle the issue mentioned above by disabling all of the settings in old state and then enable the all of the settings in new state. Signed-off-by: Fan Wu <fwu@marvell.com> Acked-by: Stephen Warren <swarren@nvidia.com> Acked-by: Patrice Chotard <patrice.chotard@st.com> Acked-by: Heiko Stuebner <heiko@sntech.de> Acked-by: Maxime Coquelin <maxime.coquelin@st.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
||
|---|---|---|
| .. | ||
| berlin | ||
| mvebu | ||
| sh-pfc | ||
| sirf | ||
| spear | ||
| sunxi | ||
| vt8500 | ||
| core.c | ||
| core.h | ||
| devicetree.c | ||
| devicetree.h | ||
| Kconfig | ||
| Makefile | ||
| pinconf-generic.c | ||
| pinconf.c | ||
| pinconf.h | ||
| pinctrl-ab8500.c | ||
| pinctrl-ab8505.c | ||
| pinctrl-ab8540.c | ||
| pinctrl-ab9540.c | ||
| pinctrl-abx500.c | ||
| pinctrl-abx500.h | ||
| pinctrl-adi2-bf54x.c | ||
| pinctrl-adi2-bf60x.c | ||
| pinctrl-adi2.c | ||
| pinctrl-adi2.h | ||
| pinctrl-apq8064.c | ||
| pinctrl-as3722.c | ||
| pinctrl-at91.c | ||
| pinctrl-baytrail.c | ||
| pinctrl-bcm281xx.c | ||
| pinctrl-bcm2835.c | ||
| pinctrl-coh901.c | ||
| pinctrl-coh901.h | ||
| pinctrl-exynos5440.c | ||
| pinctrl-exynos.c | ||
| pinctrl-exynos.h | ||
| pinctrl-falcon.c | ||
| pinctrl-imx1-core.c | ||
| pinctrl-imx1.c | ||
| pinctrl-imx1.h | ||
| pinctrl-imx6dl.c | ||
| pinctrl-imx6q.c | ||
| pinctrl-imx6sl.c | ||
| pinctrl-imx6sx.c | ||
| pinctrl-imx23.c | ||
| pinctrl-imx25.c | ||
| pinctrl-imx27.c | ||
| pinctrl-imx28.c | ||
| pinctrl-imx35.c | ||
| pinctrl-imx50.c | ||
| pinctrl-imx51.c | ||
| pinctrl-imx53.c | ||
| pinctrl-imx.c | ||
| pinctrl-imx.h | ||
| pinctrl-ipq8064.c | ||
| pinctrl-lantiq.c | ||
| pinctrl-lantiq.h | ||
| pinctrl-msm8x74.c | ||
| pinctrl-msm.c | ||
| pinctrl-msm.h | ||
| pinctrl-mxs.c | ||
| pinctrl-mxs.h | ||
| pinctrl-nomadik-db8500.c | ||
| pinctrl-nomadik-db8540.c | ||
| pinctrl-nomadik-stn8815.c | ||
| pinctrl-nomadik.c | ||
| pinctrl-nomadik.h | ||
| pinctrl-palmas.c | ||
| pinctrl-rockchip.c | ||
| pinctrl-s3c24xx.c | ||
| pinctrl-s3c64xx.c | ||
| pinctrl-samsung.c | ||
| pinctrl-samsung.h | ||
| pinctrl-single.c | ||
| pinctrl-st.c | ||
| pinctrl-tb10x.c | ||
| pinctrl-tegra20.c | ||
| pinctrl-tegra30.c | ||
| pinctrl-tegra114.c | ||
| pinctrl-tegra124.c | ||
| pinctrl-tegra.c | ||
| pinctrl-tegra.h | ||
| pinctrl-tz1090-pdc.c | ||
| pinctrl-tz1090.c | ||
| pinctrl-u300.c | ||
| pinctrl-utils.c | ||
| pinctrl-utils.h | ||
| pinctrl-vf610.c | ||
| pinctrl-xway.c | ||
| pinmux.c | ||
| pinmux.h | ||