mirror of
https://github.com/torvalds/linux.git
synced 2024-12-26 04:42:12 +00:00
9b174527e7
In the media drivers, the v4l2 core knows about all submodules and calls into them from a common function. However this cannot work if the modules that get called are loadable and the core is built-in. In that case we get drivers/built-in.o: In function `set_type': drivers/media/v4l2-core/tuner-core.c:301: undefined reference to `tea5767_attach' drivers/media/v4l2-core/tuner-core.c:307: undefined reference to `tea5761_attach' drivers/media/v4l2-core/tuner-core.c:349: undefined reference to `tda9887_attach' drivers/media/v4l2-core/tuner-core.c:405: undefined reference to `xc4000_attach' This was working previously, until the IS_ENABLED() macro was used to replace the construct like #if defined(CONFIG_DVB_CX24110) || (defined(CONFIG_DVB_CX24110_MODULE) && defined(MODULE)) with the difference that the new code no longer checks whether it is being built as a loadable module itself. To fix this, this new patch adds an 'IS_REACHABLE' macro, which evaluates true in exactly the condition that was used previously. The downside of this is that this trades an obvious link error for a more subtle runtime failure, but it is clear that the change that introduced the link error was unintentional and it seems better to revert it for now. Also, a similar change was originally created by Trent Piepho and then reverted by teh change to the IS_ENABLED macro. Ideally Kconfig would be used to avoid the case of a broken dependency, or the code restructured in a way to turn around the dependency, but either way would require much larger changes here. Fixes:7b34be71db("[media] use IS_ENABLED() macro") See-also:c5dec9fb24("V4L/DVB (4751): Fix DBV_FE_CUSTOMISE for card drivers compiled into kernel") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
80 lines
2.5 KiB
C
80 lines
2.5 KiB
C
#ifndef DIB7000P_H
|
|
#define DIB7000P_H
|
|
|
|
#include <linux/kconfig.h>
|
|
|
|
#include "dibx000_common.h"
|
|
|
|
struct dib7000p_config {
|
|
u8 output_mpeg2_in_188_bytes;
|
|
u8 hostbus_diversity;
|
|
u8 tuner_is_baseband;
|
|
int (*update_lna) (struct dvb_frontend *, u16 agc_global);
|
|
|
|
u8 agc_config_count;
|
|
struct dibx000_agc_config *agc;
|
|
struct dibx000_bandwidth_config *bw;
|
|
|
|
#define DIB7000P_GPIO_DEFAULT_DIRECTIONS 0xffff
|
|
u16 gpio_dir;
|
|
#define DIB7000P_GPIO_DEFAULT_VALUES 0x0000
|
|
u16 gpio_val;
|
|
#define DIB7000P_GPIO_PWM_POS0(v) ((v & 0xf) << 12)
|
|
#define DIB7000P_GPIO_PWM_POS1(v) ((v & 0xf) << 8 )
|
|
#define DIB7000P_GPIO_PWM_POS2(v) ((v & 0xf) << 4 )
|
|
#define DIB7000P_GPIO_PWM_POS3(v) (v & 0xf)
|
|
#define DIB7000P_GPIO_DEFAULT_PWM_POS 0xffff
|
|
u16 gpio_pwm_pos;
|
|
|
|
u16 pwm_freq_div;
|
|
|
|
u8 quartz_direct;
|
|
|
|
u8 spur_protect;
|
|
|
|
int (*agc_control) (struct dvb_frontend *, u8 before);
|
|
|
|
u8 output_mode;
|
|
u8 disable_sample_and_hold:1;
|
|
|
|
u8 enable_current_mirror:1;
|
|
u16 diversity_delay;
|
|
|
|
u8 default_i2c_addr;
|
|
u8 enMpegOutput:1;
|
|
};
|
|
|
|
#define DEFAULT_DIB7000P_I2C_ADDRESS 18
|
|
|
|
struct dib7000p_ops {
|
|
int (*set_wbd_ref)(struct dvb_frontend *demod, u16 value);
|
|
int (*get_agc_values)(struct dvb_frontend *fe,
|
|
u16 *agc_global, u16 *agc1, u16 *agc2, u16 *wbd);
|
|
int (*set_agc1_min)(struct dvb_frontend *fe, u16 v);
|
|
int (*update_pll)(struct dvb_frontend *fe, struct dibx000_bandwidth_config *bw);
|
|
int (*set_gpio)(struct dvb_frontend *demod, u8 num, u8 dir, u8 val);
|
|
u32 (*ctrl_timf)(struct dvb_frontend *fe, u8 op, u32 timf);
|
|
int (*dib7000pc_detection)(struct i2c_adapter *i2c_adap);
|
|
struct i2c_adapter *(*get_i2c_master)(struct dvb_frontend *demod, enum dibx000_i2c_interface intf, int gating);
|
|
int (*pid_filter_ctrl)(struct dvb_frontend *fe, u8 onoff);
|
|
int (*pid_filter)(struct dvb_frontend *fe, u8 id, u16 pid, u8 onoff);
|
|
int (*i2c_enumeration)(struct i2c_adapter *i2c, int no_of_demods, u8 default_addr, struct dib7000p_config cfg[]);
|
|
struct i2c_adapter *(*get_i2c_tuner)(struct dvb_frontend *fe);
|
|
int (*tuner_sleep)(struct dvb_frontend *fe, int onoff);
|
|
int (*get_adc_power)(struct dvb_frontend *fe);
|
|
int (*slave_reset)(struct dvb_frontend *fe);
|
|
struct dvb_frontend *(*init)(struct i2c_adapter *i2c_adap, u8 i2c_addr, struct dib7000p_config *cfg);
|
|
};
|
|
|
|
#if IS_REACHABLE(CONFIG_DVB_DIB7000P)
|
|
void *dib7000p_attach(struct dib7000p_ops *ops);
|
|
#else
|
|
static inline void *dib7000p_attach(struct dib7000p_ops *ops)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return NULL;
|
|
}
|
|
#endif
|
|
|
|
#endif
|