mirror of
https://github.com/torvalds/linux.git
synced 2024-10-26 15:02:39 +00:00
1e6a93cf74
soc_compr_open() does rollback when failed (A), but, it is almost same as soc_compr_free(). static int soc_compr_open(xxx) { ... if (ret < 0) goto xxx_err; ... return 0; ^ machine_err: | ... | out: (A) ... | pm_err: | ... v return ret; } The difference is soc_compr_free() is for all dai/component/substream, rollback is for succeeded part only. This kind of duplicated code can be a hotbed of bugs, thus, we want to share soc_compr_free() and rollback. => 1) snd_soc_dai_compr_startup/shutdown() 2) snd_soc_component_compr_open/free() 3) snd_soc_link_compr_startup/shutdown() This patch is for 1) snd_soc_dai_compr_startup/shutdown(), and adds new cstream mark. It will mark cstream when startup() was suceeded. If rollback happen *after* that, it will check rollback flag and marked cstream. It cares *previous* startup() only now, but we might want to check *whole* marked cstream in the future. This patch is using macro so that it can be easily adjust to it. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Link: https://lore.kernel.org/r/87mtze5iwp.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie@kernel.org> |
||
---|---|---|
.. | ||
adi | ||
amd | ||
atmel | ||
au1x | ||
bcm | ||
cirrus | ||
codecs | ||
dwc | ||
fsl | ||
generic | ||
hisilicon | ||
img | ||
intel | ||
jz4740 | ||
kirkwood | ||
mediatek | ||
meson | ||
mxs | ||
pxa | ||
qcom | ||
rockchip | ||
samsung | ||
sh | ||
sirf | ||
sof | ||
spear | ||
sprd | ||
sti | ||
stm | ||
sunxi | ||
tegra | ||
ti | ||
txx9 | ||
uniphier | ||
ux500 | ||
xilinx | ||
xtensa | ||
zte | ||
Kconfig | ||
Makefile | ||
soc-ac97.c | ||
soc-acpi.c | ||
soc-card.c | ||
soc-component.c | ||
soc-compress.c | ||
soc-core.c | ||
soc-dai.c | ||
soc-dapm.c | ||
soc-devres.c | ||
soc-generic-dmaengine-pcm.c | ||
soc-jack.c | ||
soc-link.c | ||
soc-ops.c | ||
soc-pcm.c | ||
soc-topology.c | ||
soc-utils.c |