mirror of
https://github.com/torvalds/linux.git
synced 2024-11-23 20:51:44 +00:00
d58ff35122
It seems like a historic accident that these return unsigned char *,
and in many places that means casts are required, more often than not.
Make these functions return void * and remove all the casts across
the tree, adding a (u8 *) cast only where the unsigned char pointer
was used directly, all done with the following spatch:
@@
expression SKB, LEN;
typedef u8;
identifier fn = { skb_push, __skb_push, skb_push_rcsum };
@@
- *(fn(SKB, LEN))
+ *(u8 *)fn(SKB, LEN)
@@
expression E, SKB, LEN;
identifier fn = { skb_push, __skb_push, skb_push_rcsum };
type T;
@@
- E = ((T *)(fn(SKB, LEN)))
+ E = fn(SKB, LEN)
@@
expression SKB, LEN;
identifier fn = { skb_push, __skb_push, skb_push_rcsum };
@@
- fn(SKB, LEN)[0]
+ *(u8 *)fn(SKB, LEN)
Note that the last part there converts from push(...)[0] to the
more idiomatic *(u8 *)push(...).
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
111 lines
2.7 KiB
C
111 lines
2.7 KiB
C
/*
|
|
* NET3: Fibre Channel device handling subroutines
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*
|
|
* Vineet Abraham <vma@iol.unh.edu>
|
|
* v 1.0 03/22/99
|
|
*/
|
|
|
|
#include <linux/uaccess.h>
|
|
#include <linux/types.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/string.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/socket.h>
|
|
#include <linux/in.h>
|
|
#include <linux/inet.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/fcdevice.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/timer.h>
|
|
#include <linux/net.h>
|
|
#include <linux/proc_fs.h>
|
|
#include <linux/init.h>
|
|
#include <linux/export.h>
|
|
#include <net/arp.h>
|
|
|
|
/*
|
|
* Put the headers on a Fibre Channel packet.
|
|
*/
|
|
|
|
static int fc_header(struct sk_buff *skb, struct net_device *dev,
|
|
unsigned short type,
|
|
const void *daddr, const void *saddr, unsigned int len)
|
|
{
|
|
struct fch_hdr *fch;
|
|
int hdr_len;
|
|
|
|
/*
|
|
* Add the 802.2 SNAP header if IP as the IPv4 code calls
|
|
* dev->hard_header directly.
|
|
*/
|
|
if (type == ETH_P_IP || type == ETH_P_ARP)
|
|
{
|
|
struct fcllc *fcllc;
|
|
|
|
hdr_len = sizeof(struct fch_hdr) + sizeof(struct fcllc);
|
|
fch = skb_push(skb, hdr_len);
|
|
fcllc = (struct fcllc *)(fch+1);
|
|
fcllc->dsap = fcllc->ssap = EXTENDED_SAP;
|
|
fcllc->llc = UI_CMD;
|
|
fcllc->protid[0] = fcllc->protid[1] = fcllc->protid[2] = 0x00;
|
|
fcllc->ethertype = htons(type);
|
|
}
|
|
else
|
|
{
|
|
hdr_len = sizeof(struct fch_hdr);
|
|
fch = skb_push(skb, hdr_len);
|
|
}
|
|
|
|
if(saddr)
|
|
memcpy(fch->saddr,saddr,dev->addr_len);
|
|
else
|
|
memcpy(fch->saddr,dev->dev_addr,dev->addr_len);
|
|
|
|
if(daddr)
|
|
{
|
|
memcpy(fch->daddr,daddr,dev->addr_len);
|
|
return hdr_len;
|
|
}
|
|
return -hdr_len;
|
|
}
|
|
|
|
static const struct header_ops fc_header_ops = {
|
|
.create = fc_header,
|
|
};
|
|
|
|
static void fc_setup(struct net_device *dev)
|
|
{
|
|
dev->header_ops = &fc_header_ops;
|
|
dev->type = ARPHRD_IEEE802;
|
|
dev->hard_header_len = FC_HLEN;
|
|
dev->mtu = 2024;
|
|
dev->addr_len = FC_ALEN;
|
|
dev->tx_queue_len = 100; /* Long queues on fc */
|
|
dev->flags = IFF_BROADCAST;
|
|
|
|
memset(dev->broadcast, 0xFF, FC_ALEN);
|
|
}
|
|
|
|
/**
|
|
* alloc_fcdev - Register fibre channel device
|
|
* @sizeof_priv: Size of additional driver-private structure to be allocated
|
|
* for this fibre channel device
|
|
*
|
|
* Fill in the fields of the device structure with fibre channel-generic values.
|
|
*
|
|
* Constructs a new net device, complete with a private data area of
|
|
* size @sizeof_priv. A 32-byte (not bit) alignment is enforced for
|
|
* this private data area.
|
|
*/
|
|
struct net_device *alloc_fcdev(int sizeof_priv)
|
|
{
|
|
return alloc_netdev(sizeof_priv, "fc%d", NET_NAME_UNKNOWN, fc_setup);
|
|
}
|
|
EXPORT_SYMBOL(alloc_fcdev);
|