Theodore Ts'o 1e424a3483 ext4: partial revert to fix double brelse WARNING() ... This is a partial revert of commit 6487a9d (only the changes made to fs/ext4/namei.c), since it is causing the following brelse() double-free warning when running fsstress on a file system with 1k blocksize and we run into a block allocation failure while converting a single-block directory to a multi-block hash-tree indexed directory. WARNING: at fs/buffer.c:1197 __brelse+0x2e/0x33() Hardware name: VFS: brelse: Trying to free free buffer Modules linked in: Pid: 2226, comm: jbd2/sdd-8 Not tainted 2.6.32-rc6-00577-g0003f55 #101 Call Trace: [<c01587fb>] warn_slowpath_common+0x65/0x95 [<c0158869>] warn_slowpath_fmt+0x29/0x2c [<c021168e>] __brelse+0x2e/0x33 [<c0288a9f>] jbd2_journal_refile_buffer+0x67/0x6c [<c028a9ed>] jbd2_journal_commit_transaction+0x319/0x14d8 [<c0164d73>] ? try_to_del_timer_sync+0x58/0x60 [<c0175bcc>] ? sched_clock_cpu+0x12a/0x13e [<c017f6b4>] ? trace_hardirqs_off+0xb/0xd [<c0175c1f>] ? cpu_clock+0x3f/0x5b [<c017f6ec>] ? lock_release_holdtime+0x36/0x137 [<c0664ad0>] ? _spin_unlock_irqrestore+0x44/0x51 [<c0180af3>] ? trace_hardirqs_on_caller+0x103/0x124 [<c0180b1f>] ? trace_hardirqs_on+0xb/0xd [<c0164d73>] ? try_to_del_timer_sync+0x58/0x60 [<c0290d1c>] kjournald2+0x11a/0x310 [<c017118e>] ? autoremove_wake_function+0x0/0x38 [<c0290c02>] ? kjournald2+0x0/0x310 [<c0170ee6>] kthread+0x66/0x6b [<c0170e80>] ? kthread+0x0/0x6b [<c01251b3>] kernel_thread_helper+0x7/0x10 ---[ end trace 5579351b86af61e3 ]--- Commit 6487a9d was an attempt some buffer head leaks in an ENOSPC error path, but in some cases it actually results in an excess ENOSPC, as shown above. Fixing this means cleaning up who is responsible for releasing the buffer heads from the callee to the caller of add_dirent_to_buf(). Since that's a relatively complex change, and we're late in the rcX development cycle, I'm reverting this now, and holding back a more complete fix until after 2.6.32 ships. We've lived with this buffer_head leak on ENOSPC in ext3 and ext4 for a very long time; a few more months won't kill us. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: Curt Wohlgemuth <curtw@google.com>		2009-11-08 15:45:44 -05:00
..
9p	9p: fix readdir corner cases	2009-11-02 08:43:45 -06:00
adfs	adfs: remove redundant test on unsigned	2009-09-24 07:21:05 -07:00
affs	affs: add ->sync_fs	2009-06-11 21:36:14 -04:00
afs	afs: remove cache.h	2009-10-01 16:11:16 -07:00
autofs	trivial: remove unnecessary semicolons	2009-09-21 15:14:58 +02:00
autofs4	autofs4 - fix missed case when changing to use struct path	2009-08-31 17:44:05 -10:00
befs	fs: Make unload_nls() NULL pointer safe	2009-09-24 07:47:42 -04:00
bfs	headers: smp_lock.h redux	2009-07-12 12:22:34 -07:00
btrfs	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable	2009-10-15 15:06:37 -07:00
cachefiles	enforce ->sync_fs is only called for rw superblock	2009-06-11 21:36:06 -04:00
cifs	[CIFS] Fixing to avoid invalid kfree() in cifs_get_tcp_session()	2009-10-06 18:31:29 +00:00
coda	headers: remove sched.h from poll.h	2009-10-04 15:05:10 -07:00
configfs	writeback: add name to backing_dev_info	2009-09-11 09:20:26 +02:00
cramfs
debugfs	debugfs: use specified mode to possibly mark files read/write only	2009-06-15 21:30:28 -07:00
devpts	Move magic numbers into magic.h	2009-09-23 07:39:28 -07:00
dlm	dlm: fix socket fd translation	2009-09-30 12:19:44 -05:00
ecryptfs	ima: ecryptfs fix imbalance message	2009-10-08 11:31:38 -05:00
efs	get rid of BKL in fs/efs	2009-06-17 00:36:36 -04:00
exofs	exofs: remove BKL from super operations	2009-09-24 07:47:38 -04:00
exportfs
ext2	Merge branch 'hwpoison' of git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-mce-2.6	2009-09-24 07:53:22 -07:00
ext3	ext3: Don't update superblock write time when filesystem is read-only	2009-10-13 00:06:43 +02:00
ext4	ext4: partial revert to fix double brelse WARNING()	2009-11-08 15:45:44 -05:00
fat	Merge git://git.kernel.org/pub/scm/linux/kernel/git/hirofumi/fatfs-2.6	2009-09-30 09:31:14 -07:00
freevxfs	headers: smp_lock.h redux	2009-07-12 12:22:34 -07:00
fscache
fuse	const: mark struct vm_struct_operations	2009-09-27 11:39:25 -07:00
gfs2	const: mark struct vm_struct_operations	2009-09-27 11:39:25 -07:00
hfs	hfs: fix oops on mount with corrupted btree extent records	2009-10-29 07:39:29 -07:00
hfsplus	hfsplus: refuse to mount volumes larger than 2TB	2009-10-29 07:39:27 -07:00
hostfs	hostfs: set maximum filesize in superblock for proper LFS support	2009-06-30 18:56:03 -07:00
hpfs	headers: smp_lock.h redux	2009-07-12 12:22:34 -07:00
hppfs
hugetlbfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6	2009-09-24 08:32:11 -07:00
isofs	fs: Make unload_nls() NULL pointer safe	2009-09-24 07:47:42 -04:00
jbd	jbd: Annotate transaction start also for journal_restart()	2009-09-16 17:44:10 +02:00
jbd2	const: constify remaining file_operations	2009-10-01 16:11:11 -07:00
jffs2	Merge git://git.infradead.org/mtd-2.6	2009-09-23 10:07:49 -07:00
jfs	fs: Make unload_nls() NULL pointer safe	2009-09-24 07:47:42 -04:00
lockd	headers: utsname.h redux	2009-09-23 18:13:10 -07:00
minix	V3 minixfs: add missing directory type checking	2009-09-23 07:39:57 -07:00
ncpfs	const: mark struct vm_struct_operations	2009-09-27 11:39:25 -07:00
nfs	NFSv4: The link() operation should return any delegation on the file	2009-10-26 08:09:46 -04:00
nfs_common
nfsd	const: constify remaining file_operations	2009-10-01 16:11:11 -07:00
nilfs2	nilfs2: add zero-fill for new btree node buffers	2009-11-03 12:32:03 +09:00
nls	Merge git://git.kernel.org/pub/scm/linux/kernel/git/hirofumi/fatfs-2.6	2009-09-30 09:31:14 -07:00
notify	dnotify: ignore FS_EVENT_ON_CHILD	2009-10-20 18:02:33 -04:00
ntfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6	2009-09-24 08:32:11 -07:00
ocfs2	const: constify remaining file_operations	2009-10-01 16:11:11 -07:00
omfs	const: constify remaining file_operations	2009-10-01 16:11:11 -07:00
openpromfs
partitions	block: Seperate read and write statistics of in_flight requests v2	2009-10-06 20:16:55 +02:00
proc	hwpoison: fix/proc/meminfo alignment	2009-10-29 07:39:25 -07:00
qnx4	qnx4: remove write support	2009-09-23 07:39:30 -07:00
quota	const: make struct super_block::s_qcop const	2009-09-22 07:17:24 -07:00
ramfs	truncate: use new helpers	2009-09-24 08:41:47 -04:00
reiserfs	const: make struct super_block::s_qcop const	2009-09-22 07:17:24 -07:00
romfs	ROMFS: fix length used with romfs_dev_strnlen() function	2009-10-11 11:33:56 -07:00
smbfs	fs: Make unload_nls() NULL pointer safe	2009-09-24 07:47:42 -04:00
squashfs	const: mark remaining super_operations const	2009-09-22 07:17:24 -07:00
sysfs	sysfs: Allow sysfs_notify_dirent to be called from interrupt context.	2009-10-14 15:16:25 -07:00
sysv	get rid of BKL in fs/sysv	2009-06-17 00:36:37 -04:00
ubifs	const: mark struct vm_struct_operations	2009-09-27 11:39:25 -07:00
udf	udf: Fix possible corruption when close races with write	2009-09-14 19:13:01 +02:00
ufs	ufs: sector_t cannot be negative	2009-06-18 13:03:46 -07:00
xfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/fs/xfs/xfs	2009-10-31 12:12:49 -07:00
aio.c	aio.c: move EXPORT* macros to line after function	2009-09-23 07:39:29 -07:00
anon_inodes.c	headers: remove sched.h from poll.h	2009-10-04 15:05:10 -07:00
attr.c	truncate: new helpers	2009-09-24 08:41:47 -04:00
bad_inode.c
binfmt_aout.c
binfmt_elf_fdpic.c	fdpic: ignore the loader's PT_GNU_STACK when calculating the stack size	2009-09-24 07:21:02 -07:00
binfmt_elf.c	elf: clean up fill_note_info()	2009-09-24 07:21:01 -07:00
binfmt_em86.c
binfmt_flat.c	flat: use IS_ERR_VALUE() helper macro	2009-09-24 07:21:03 -07:00
binfmt_misc.c
binfmt_script.c
binfmt_som.c
bio-integrity.c	block: Create bip slabs with embedded integrity vectors	2009-07-01 10:56:25 +02:00
bio.c	fs/bio.c: move EXPORT* macros to line after function	2009-10-01 21:15:46 +02:00
block_dev.c	block: use after free bug in __blkdev_get	2009-10-26 15:27:11 +01:00
buffer.c	Merge branch 'writeback' of git://git.kernel.dk/linux-2.6-block	2009-09-25 09:27:30 -07:00
char_dev.c	fs/char_dev.c: remove useless loop	2009-09-24 07:21:03 -07:00
compat_binfmt_elf.c
compat_ioctl.c	compat_ioctl: hook up compat handler for FIEMAP ioctl	2009-08-07 10:39:56 -07:00
compat.c	fs: fix overflow in sys_mount() for in-kernel calls	2009-09-24 08:40:15 -04:00
dcache.c	sched: Pull up the might_sleep() check into cond_resched()	2009-07-18 15:51:44 +02:00
dcookies.c
direct-io.c
drop_caches.c	sysctl: remove "struct file *" argument of ->proc_handler	2009-09-24 07:21:04 -07:00
eventfd.c	anonfd: split interface into file creation and install	2009-09-23 07:39:29 -07:00
eventpoll.c	epoll: fix nested calls support	2009-06-18 13:03:41 -07:00
exec.c	task_struct cleanup: move binfmt field to mm_struct	2009-09-24 07:21:05 -07:00
fcntl.c	fcntl: add F_[SG]ETOWN_EX	2009-09-24 07:21:01 -07:00
fifo.c
file_table.c	sysctl: remove "struct file *" argument of ->proc_handler	2009-09-24 07:21:04 -07:00
file.c	headers: remove sched.h from interrupt.h	2009-10-11 11:20:58 -07:00
filesystems.c
fs_struct.c
fs-writeback.c	writeback: pass in super_block to bdi_start_writeback()	2009-09-26 00:10:40 +02:00
generic_acl.c
inode.c	vfs: optimize touch_time() too	2009-09-24 07:47:27 -04:00
internal.h	fs: fix overflow in sys_mount() for in-kernel calls	2009-09-24 08:40:15 -04:00
ioctl.c	vfs: explicitly cast s_maxbytes in fiemap_check_ranges	2009-09-24 07:47:31 -04:00
ioprio.c
Kconfig	Merge branch 'sh/for-2.6.32' of git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6	2009-10-29 09:07:15 -07:00
Kconfig.binfmt
libfs.c	libfs: return error code on failed attr set	2009-09-24 07:47:30 -04:00
locks.c	const: make lock_manager_operations const	2009-09-22 07:17:25 -07:00
Makefile
mbcache.c
mpage.c
namei.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6	2009-09-11 08:55:49 -07:00
namespace.c	fs: fix overflow in sys_mount() for in-kernel calls	2009-09-24 08:40:15 -04:00
nfsctl.c
no-block.c
open.c	fs: change sys_truncate length parameter type	2009-09-23 09:21:05 -07:00
pipe.c	fs: pipe.c null pointer dereference	2009-10-22 08:11:44 +09:00
pnode.c
pnode.h
posix_acl.c
read_write.c	vfs: remove redundant position check in do_sendfile	2009-09-24 07:47:34 -04:00
read_write.h
readdir.c
select.c	headers: remove sched.h from poll.h	2009-10-04 15:05:10 -07:00
seq_file.c	vfs: seq_file: add helpers for data filling	2009-09-24 07:47:35 -04:00
signalfd.c
splice.c	Merge branch 'for-2.6.32' of git://git.kernel.dk/linux-2.6-block	2009-09-14 17:55:15 -07:00
stack.c
stat.c
super.c	freeze_bdev: grab active reference to frozen superblocks	2009-09-24 07:47:41 -04:00
sync.c	fs/buffer.c: clean up EXPORT* macros	2009-09-23 07:39:29 -07:00
timerfd.c
utimes.c
xattr_acl.c
xattr.c	VFS: Factor out part of vfs_setxattr so it can be called from the SELinux hook for inode_setsecctx.	2009-09-10 10:11:22 +10:00