mirror of
https://github.com/torvalds/linux.git
synced 2024-11-08 21:21:47 +00:00
5a0e3ad6af
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
178 lines
4.5 KiB
C
178 lines
4.5 KiB
C
/*
|
|
* LEDs driver for Dialog Semiconductor DA9030/DA9034
|
|
*
|
|
* Copyright (C) 2008 Compulab, Ltd.
|
|
* Mike Rapoport <mike@compulab.co.il>
|
|
*
|
|
* Copyright (C) 2006-2008 Marvell International Ltd.
|
|
* Eric Miao <eric.miao@marvell.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/leds.h>
|
|
#include <linux/workqueue.h>
|
|
#include <linux/mfd/da903x.h>
|
|
#include <linux/slab.h>
|
|
|
|
#define DA9030_LED1_CONTROL 0x20
|
|
#define DA9030_LED2_CONTROL 0x21
|
|
#define DA9030_LED3_CONTROL 0x22
|
|
#define DA9030_LED4_CONTROL 0x23
|
|
#define DA9030_LEDPC_CONTROL 0x24
|
|
#define DA9030_MISC_CONTROL_A 0x26 /* Vibrator Control */
|
|
|
|
#define DA9034_LED1_CONTROL 0x35
|
|
#define DA9034_LED2_CONTROL 0x36
|
|
#define DA9034_VIBRA 0x40
|
|
|
|
struct da903x_led {
|
|
struct led_classdev cdev;
|
|
struct work_struct work;
|
|
struct device *master;
|
|
enum led_brightness new_brightness;
|
|
int id;
|
|
int flags;
|
|
};
|
|
|
|
#define DA9030_LED_OFFSET(id) ((id) - DA9030_ID_LED_1)
|
|
#define DA9034_LED_OFFSET(id) ((id) - DA9034_ID_LED_1)
|
|
|
|
static void da903x_led_work(struct work_struct *work)
|
|
{
|
|
struct da903x_led *led = container_of(work, struct da903x_led, work);
|
|
uint8_t val;
|
|
int offset;
|
|
|
|
switch (led->id) {
|
|
case DA9030_ID_LED_1:
|
|
case DA9030_ID_LED_2:
|
|
case DA9030_ID_LED_3:
|
|
case DA9030_ID_LED_4:
|
|
case DA9030_ID_LED_PC:
|
|
offset = DA9030_LED_OFFSET(led->id);
|
|
val = led->flags & ~0x87;
|
|
val |= (led->new_brightness) ? 0x80 : 0; /* EN bit */
|
|
val |= (0x7 - (led->new_brightness >> 5)) & 0x7; /* PWM<2:0> */
|
|
da903x_write(led->master, DA9030_LED1_CONTROL + offset, val);
|
|
break;
|
|
case DA9030_ID_VIBRA:
|
|
val = led->flags & ~0x80;
|
|
val |= (led->new_brightness) ? 0x80 : 0; /* EN bit */
|
|
da903x_write(led->master, DA9030_MISC_CONTROL_A, val);
|
|
break;
|
|
case DA9034_ID_LED_1:
|
|
case DA9034_ID_LED_2:
|
|
offset = DA9034_LED_OFFSET(led->id);
|
|
val = (led->new_brightness * 0x5f / LED_FULL) & 0x7f;
|
|
val |= (led->flags & DA9034_LED_RAMP) ? 0x80 : 0;
|
|
da903x_write(led->master, DA9034_LED1_CONTROL + offset, val);
|
|
break;
|
|
case DA9034_ID_VIBRA:
|
|
val = led->new_brightness & 0xfe;
|
|
da903x_write(led->master, DA9034_VIBRA, val);
|
|
break;
|
|
}
|
|
}
|
|
|
|
static void da903x_led_set(struct led_classdev *led_cdev,
|
|
enum led_brightness value)
|
|
{
|
|
struct da903x_led *led;
|
|
|
|
led = container_of(led_cdev, struct da903x_led, cdev);
|
|
led->new_brightness = value;
|
|
schedule_work(&led->work);
|
|
}
|
|
|
|
static int __devinit da903x_led_probe(struct platform_device *pdev)
|
|
{
|
|
struct led_info *pdata = pdev->dev.platform_data;
|
|
struct da903x_led *led;
|
|
int id, ret;
|
|
|
|
if (pdata == NULL)
|
|
return 0;
|
|
|
|
id = pdev->id;
|
|
|
|
if (!((id >= DA9030_ID_LED_1 && id <= DA9030_ID_VIBRA) ||
|
|
(id >= DA9034_ID_LED_1 && id <= DA9034_ID_VIBRA))) {
|
|
dev_err(&pdev->dev, "invalid LED ID (%d) specified\n", id);
|
|
return -EINVAL;
|
|
}
|
|
|
|
led = kzalloc(sizeof(struct da903x_led), GFP_KERNEL);
|
|
if (led == NULL) {
|
|
dev_err(&pdev->dev, "failed to alloc memory for LED%d\n", id);
|
|
return -ENOMEM;
|
|
}
|
|
|
|
led->cdev.name = pdata->name;
|
|
led->cdev.default_trigger = pdata->default_trigger;
|
|
led->cdev.brightness_set = da903x_led_set;
|
|
led->cdev.brightness = LED_OFF;
|
|
|
|
led->id = id;
|
|
led->flags = pdata->flags;
|
|
led->master = pdev->dev.parent;
|
|
led->new_brightness = LED_OFF;
|
|
|
|
INIT_WORK(&led->work, da903x_led_work);
|
|
|
|
ret = led_classdev_register(led->master, &led->cdev);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "failed to register LED %d\n", id);
|
|
goto err;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, led);
|
|
return 0;
|
|
|
|
err:
|
|
kfree(led);
|
|
return ret;
|
|
}
|
|
|
|
static int __devexit da903x_led_remove(struct platform_device *pdev)
|
|
{
|
|
struct da903x_led *led = platform_get_drvdata(pdev);
|
|
|
|
led_classdev_unregister(&led->cdev);
|
|
kfree(led);
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver da903x_led_driver = {
|
|
.driver = {
|
|
.name = "da903x-led",
|
|
.owner = THIS_MODULE,
|
|
},
|
|
.probe = da903x_led_probe,
|
|
.remove = __devexit_p(da903x_led_remove),
|
|
};
|
|
|
|
static int __init da903x_led_init(void)
|
|
{
|
|
return platform_driver_register(&da903x_led_driver);
|
|
}
|
|
module_init(da903x_led_init);
|
|
|
|
static void __exit da903x_led_exit(void)
|
|
{
|
|
platform_driver_unregister(&da903x_led_driver);
|
|
}
|
|
module_exit(da903x_led_exit);
|
|
|
|
MODULE_DESCRIPTION("LEDs driver for Dialog Semiconductor DA9030/DA9034");
|
|
MODULE_AUTHOR("Eric Miao <eric.miao@marvell.com>"
|
|
"Mike Rapoport <mike@compulab.co.il>");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:da903x-led");
|