Basavaraj Natikar 8785436617 HID: amd_sfh: Fix for shift-out-of-bounds ... Shift operation of 'exp' and 'shift' variables exceeds the maximum number of shift values in the u32 range leading to UBSAN shift-out-of-bounds. ... [ 6.120512] UBSAN: shift-out-of-bounds in drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c:149:50 [ 6.120598] shift exponent 104 is too large for 64-bit type 'long unsigned int' [ 6.120659] CPU: 4 PID: 96 Comm: kworker/4:1 Not tainted 6.4.0amd_1-next-20230519-dirty #10 [ 6.120665] Hardware name: AMD Birman-PHX/Birman-PHX, BIOS SFH_with_HPD_SEN.FD 04/05/2023 [ 6.120667] Workqueue: events amd_sfh_work_buffer [amd_sfh] [ 6.120687] Call Trace: [ 6.120690] <TASK> [ 6.120694] dump_stack_lvl+0x48/0x70 [ 6.120704] dump_stack+0x10/0x20 [ 6.120707] ubsan_epilogue+0x9/0x40 [ 6.120716] __ubsan_handle_shift_out_of_bounds+0x10f/0x170 [ 6.120720] ? psi_group_change+0x25f/0x4b0 [ 6.120729] float_to_int.cold+0x18/0xba [amd_sfh] [ 6.120739] get_input_rep+0x57/0x340 [amd_sfh] [ 6.120748] ? __schedule+0xba7/0x1b60 [ 6.120756] ? __pfx_get_input_rep+0x10/0x10 [amd_sfh] [ 6.120764] amd_sfh_work_buffer+0x91/0x180 [amd_sfh] [ 6.120772] process_one_work+0x229/0x430 [ 6.120780] worker_thread+0x4a/0x3c0 [ 6.120784] ? __pfx_worker_thread+0x10/0x10 [ 6.120788] kthread+0xf7/0x130 [ 6.120792] ? __pfx_kthread+0x10/0x10 [ 6.120795] ret_from_fork+0x29/0x50 [ 6.120804] </TASK> ... Fix this by adding the condition to validate shift ranges. Fixes: 93ce5e0231 ("HID: amd_sfh: Implement SFH1.1 functionality") Cc: stable@vger.kernel.org Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> Signed-off-by: Akshata MukundShetty <akshata.mukundshetty@amd.com> Link: https://lore.kernel.org/r/20230707065722.9036-3-Basavaraj.Natikar@amd.com Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>		2023-07-10 09:53:50 +02:00
..
hid_descriptor	HID: amd_sfh: Support for additional light sensor	2023-04-13 15:57:14 +02:00
sfh1_1	HID: amd_sfh: Fix for shift-out-of-bounds	2023-07-10 09:53:50 +02:00
amd_sfh_client.c	HID: amd_sfh: Split sensor and HID initialization	2023-05-23 15:58:30 +02:00
amd_sfh_common.h	HID: amd_sfh: Implement SFH1.1 functionality	2022-07-21 13:44:04 +02:00
amd_sfh_hid.c	HID: amd_sfh: Constify lowlevel HID driver	2023-02-06 15:08:44 +01:00
amd_sfh_hid.h	HID: amd_sfh: Fix max supported HID devices	2023-04-25 10:58:28 +02:00
amd_sfh_pcie.c	HID: amd_sfh: Support for additional light sensor	2023-04-13 15:57:14 +02:00
amd_sfh_pcie.h	HID: amd_sfh: Support for additional light sensor	2023-04-13 15:57:14 +02:00
Kconfig	HID: stop drivers from selecting CONFIG_HID	2023-01-18 16:14:04 +01:00
Makefile	HID: amd_sfh: Implement SFH1.1 functionality	2022-07-21 13:44:04 +02:00