mirror of
https://github.com/torvalds/linux.git
synced 2024-12-27 13:22:23 +00:00
1cd8909642
Smatch complains:
hif_tx.c:319 hif_join() error: we previously assumed 'channel' could be null (see line 315)
311 if (!hif)
312 return -ENOMEM;
313 body->infrastructure_bss_mode = !conf->ibss_joined;
314 body->short_preamble = conf->use_short_preamble;
315 if (channel && channel->flags & IEEE80211_CHAN_NO_IR)
^^^^^^^
316 body->probe_for_join = 0;
317 else
318 body->probe_for_join = 1;
319 body->channel_number = channel->hw_value;
^^^^^^^^^^^^^^^^^
320 body->beacon_interval = cpu_to_le32(conf->beacon_int);
321 body->basic_rate_set =
Indeed, channel can't be NULL (else I would have seen plenty of Ooops
this past year). This patch explicitly claims this restriction.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20201009171307.864608-2-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
||
|---|---|---|
| .. | ||
| Documentation/devicetree/bindings/net/wireless | ||
| bh.c | ||
| bh.h | ||
| bus_sdio.c | ||
| bus_spi.c | ||
| bus.h | ||
| data_rx.c | ||
| data_rx.h | ||
| data_tx.c | ||
| data_tx.h | ||
| debug.c | ||
| debug.h | ||
| fwio.c | ||
| fwio.h | ||
| hif_api_cmd.h | ||
| hif_api_general.h | ||
| hif_api_mib.h | ||
| hif_rx.c | ||
| hif_rx.h | ||
| hif_tx_mib.c | ||
| hif_tx_mib.h | ||
| hif_tx.c | ||
| hif_tx.h | ||
| hwio.c | ||
| hwio.h | ||
| Kconfig | ||
| key.c | ||
| key.h | ||
| main.c | ||
| main.h | ||
| Makefile | ||
| queue.c | ||
| queue.h | ||
| scan.c | ||
| scan.h | ||
| sta.c | ||
| sta.h | ||
| TODO | ||
| traces.h | ||
| wfx.h | ||