mirror of
https://github.com/torvalds/linux.git
synced 2024-11-05 19:41:54 +00:00
3b9561e9d9
Many USB host drivers contain code such as:
if (!pdev->dev.dma_mask)
pdev->dev.dma_mask = &tegra_ehci_dma_mask;
... where tegra_ehci_dma_mask is a global. I suspect this code originated
in commit 4a53f4e
"USB: ehci-tegra: add probing through device tree" and
was simply copied everywhere else.
This works fine when the code is built-in, but can cause a crash when the
code is in a module. The first module load sets up the dma_mask pointer,
but if the module is removed and re-inserted, the value is now non-NULL,
and hence is not updated to point at the new location, and hence points
at a stale location within the previous module load address, which in
turn causes a crash if the pointer is de-referenced.
The simplest way of solving this seems to be to copy the code from
ehci-platform.c, which uses the coherent_dma_mask as the target for the
dma_mask pointer.
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
210 lines
4.7 KiB
C
210 lines
4.7 KiB
C
/*
|
|
* Driver for EHCI UHP on Atmel chips
|
|
*
|
|
* Copyright (C) 2009 Atmel Corporation,
|
|
* Nicolas Ferre <nicolas.ferre@atmel.com>
|
|
*
|
|
* Based on various ehci-*.c drivers
|
|
*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file COPYING in the main directory of this archive for
|
|
* more details.
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/dma-mapping.h>
|
|
#include <linux/io.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/usb.h>
|
|
#include <linux/usb/hcd.h>
|
|
|
|
#include "ehci.h"
|
|
|
|
#define DRIVER_DESC "EHCI Atmel driver"
|
|
|
|
static const char hcd_name[] = "ehci-atmel";
|
|
static struct hc_driver __read_mostly ehci_atmel_hc_driver;
|
|
|
|
/* interface and function clocks */
|
|
static struct clk *iclk, *fclk;
|
|
static int clocked;
|
|
|
|
/*-------------------------------------------------------------------------*/
|
|
|
|
static void atmel_start_clock(void)
|
|
{
|
|
clk_enable(iclk);
|
|
clk_enable(fclk);
|
|
clocked = 1;
|
|
}
|
|
|
|
static void atmel_stop_clock(void)
|
|
{
|
|
clk_disable(fclk);
|
|
clk_disable(iclk);
|
|
clocked = 0;
|
|
}
|
|
|
|
static void atmel_start_ehci(struct platform_device *pdev)
|
|
{
|
|
dev_dbg(&pdev->dev, "start\n");
|
|
atmel_start_clock();
|
|
}
|
|
|
|
static void atmel_stop_ehci(struct platform_device *pdev)
|
|
{
|
|
dev_dbg(&pdev->dev, "stop\n");
|
|
atmel_stop_clock();
|
|
}
|
|
|
|
/*-------------------------------------------------------------------------*/
|
|
|
|
static int ehci_atmel_drv_probe(struct platform_device *pdev)
|
|
{
|
|
struct usb_hcd *hcd;
|
|
const struct hc_driver *driver = &ehci_atmel_hc_driver;
|
|
struct resource *res;
|
|
struct ehci_hcd *ehci;
|
|
int irq;
|
|
int retval;
|
|
|
|
if (usb_disabled())
|
|
return -ENODEV;
|
|
|
|
pr_debug("Initializing Atmel-SoC USB Host Controller\n");
|
|
|
|
irq = platform_get_irq(pdev, 0);
|
|
if (irq <= 0) {
|
|
dev_err(&pdev->dev,
|
|
"Found HC with no IRQ. Check %s setup!\n",
|
|
dev_name(&pdev->dev));
|
|
retval = -ENODEV;
|
|
goto fail_create_hcd;
|
|
}
|
|
|
|
/* Right now device-tree probed devices don't get dma_mask set.
|
|
* Since shared usb code relies on it, set it here for now.
|
|
* Once we have dma capability bindings this can go away.
|
|
*/
|
|
if (!pdev->dev.dma_mask)
|
|
pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
|
|
if (!pdev->dev.coherent_dma_mask)
|
|
pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
|
|
|
|
hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev));
|
|
if (!hcd) {
|
|
retval = -ENOMEM;
|
|
goto fail_create_hcd;
|
|
}
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
if (!res) {
|
|
dev_err(&pdev->dev,
|
|
"Found HC with no register addr. Check %s setup!\n",
|
|
dev_name(&pdev->dev));
|
|
retval = -ENODEV;
|
|
goto fail_request_resource;
|
|
}
|
|
hcd->rsrc_start = res->start;
|
|
hcd->rsrc_len = resource_size(res);
|
|
|
|
hcd->regs = devm_ioremap_resource(&pdev->dev, res);
|
|
if (IS_ERR(hcd->regs)) {
|
|
retval = PTR_ERR(hcd->regs);
|
|
goto fail_request_resource;
|
|
}
|
|
|
|
iclk = devm_clk_get(&pdev->dev, "ehci_clk");
|
|
if (IS_ERR(iclk)) {
|
|
dev_err(&pdev->dev, "Error getting interface clock\n");
|
|
retval = -ENOENT;
|
|
goto fail_request_resource;
|
|
}
|
|
fclk = devm_clk_get(&pdev->dev, "uhpck");
|
|
if (IS_ERR(fclk)) {
|
|
dev_err(&pdev->dev, "Error getting function clock\n");
|
|
retval = -ENOENT;
|
|
goto fail_request_resource;
|
|
}
|
|
|
|
ehci = hcd_to_ehci(hcd);
|
|
/* registers start at offset 0x0 */
|
|
ehci->caps = hcd->regs;
|
|
|
|
atmel_start_ehci(pdev);
|
|
|
|
retval = usb_add_hcd(hcd, irq, IRQF_SHARED);
|
|
if (retval)
|
|
goto fail_add_hcd;
|
|
|
|
return retval;
|
|
|
|
fail_add_hcd:
|
|
atmel_stop_ehci(pdev);
|
|
fail_request_resource:
|
|
usb_put_hcd(hcd);
|
|
fail_create_hcd:
|
|
dev_err(&pdev->dev, "init %s fail, %d\n",
|
|
dev_name(&pdev->dev), retval);
|
|
|
|
return retval;
|
|
}
|
|
|
|
static int ehci_atmel_drv_remove(struct platform_device *pdev)
|
|
{
|
|
struct usb_hcd *hcd = platform_get_drvdata(pdev);
|
|
|
|
usb_remove_hcd(hcd);
|
|
usb_put_hcd(hcd);
|
|
|
|
atmel_stop_ehci(pdev);
|
|
fclk = iclk = NULL;
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_OF
|
|
static const struct of_device_id atmel_ehci_dt_ids[] = {
|
|
{ .compatible = "atmel,at91sam9g45-ehci" },
|
|
{ /* sentinel */ }
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, atmel_ehci_dt_ids);
|
|
#endif
|
|
|
|
static struct platform_driver ehci_atmel_driver = {
|
|
.probe = ehci_atmel_drv_probe,
|
|
.remove = ehci_atmel_drv_remove,
|
|
.shutdown = usb_hcd_platform_shutdown,
|
|
.driver = {
|
|
.name = "atmel-ehci",
|
|
.of_match_table = of_match_ptr(atmel_ehci_dt_ids),
|
|
},
|
|
};
|
|
|
|
static int __init ehci_atmel_init(void)
|
|
{
|
|
if (usb_disabled())
|
|
return -ENODEV;
|
|
|
|
pr_info("%s: " DRIVER_DESC "\n", hcd_name);
|
|
ehci_init_driver(&ehci_atmel_hc_driver, NULL);
|
|
return platform_driver_register(&ehci_atmel_driver);
|
|
}
|
|
module_init(ehci_atmel_init);
|
|
|
|
static void __exit ehci_atmel_cleanup(void)
|
|
{
|
|
platform_driver_unregister(&ehci_atmel_driver);
|
|
}
|
|
module_exit(ehci_atmel_cleanup);
|
|
|
|
MODULE_DESCRIPTION(DRIVER_DESC);
|
|
MODULE_ALIAS("platform:atmel-ehci");
|
|
MODULE_AUTHOR("Nicolas Ferre");
|
|
MODULE_LICENSE("GPL");
|