mirror of
https://github.com/torvalds/linux.git
synced 2024-12-27 13:22:23 +00:00
1aec169673
The vmbus/hyperv interrupt handling is another complete trainwreck and probably the worst of all currently in tree. If CONFIG_HYPERV=y then the interrupt delivery to the vmbus happens via the direct HYPERVISOR_CALLBACK_VECTOR. So far so good, but: The driver requests first a normal device interrupt. The only reason to do so is to increment the interrupt stats of that device interrupt. For no reason it also installs a private flow handler. We have proper accounting mechanisms for direct vectors, but of course it's too much effort to add that 5 lines of code. Aside of that the alloc_intr_gate() is not protected against reallocation which makes module reload impossible. Solution to the problem is simple to rip out the whole mess and implement it correctly. First of all move all that code to arch/x86/kernel/cpu/mshyperv.c and merily install the HYPERVISOR_CALLBACK_VECTOR with proper reallocation protection and use the proper direct vector accounting mechanism. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: K. Y. Srinivasan <kys@microsoft.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linuxdrivers <devel@linuxdriverproject.org> Cc: x86 <x86@kernel.org> Link: http://lkml.kernel.org/r/20140223212739.028307673@linutronix.de Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
24 lines
531 B
C
24 lines
531 B
C
#ifndef _ASM_X86_MSHYPER_H
|
|
#define _ASM_X86_MSHYPER_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/interrupt.h>
|
|
#include <asm/hyperv.h>
|
|
|
|
struct ms_hyperv_info {
|
|
u32 features;
|
|
u32 hints;
|
|
};
|
|
|
|
extern struct ms_hyperv_info ms_hyperv;
|
|
|
|
void hyperv_callback_vector(void);
|
|
#ifdef CONFIG_TRACING
|
|
#define trace_hyperv_callback_vector hyperv_callback_vector
|
|
#endif
|
|
void hyperv_vector_handler(struct pt_regs *regs);
|
|
int hv_setup_vmbus_irq(int irq, irq_handler_t handler, void *dev_id);
|
|
void hv_remove_vmbus_irq(int irq, void *dev_id);
|
|
|
|
#endif
|