mirror of
https://github.com/torvalds/linux.git
synced 2024-12-25 20:32:22 +00:00
1943edacef
When building with -Wsometimes-uninitialized, Clang warns:
drivers/scsi/ufs/ufs-mediatek.c:112:7: warning: variable 'ret' is used
uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
if (on)
^~
drivers/scsi/ufs/ufs-mediatek.c:120:9: note: uninitialized use occurs
here
return ret;
^~~
drivers/scsi/ufs/ufs-mediatek.c:112:3: note: remove the 'if' if its
condition is always true
if (on)
^~~~~~~
drivers/scsi/ufs/ufs-mediatek.c:108:7: warning: variable 'ret' is used
uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
if (!on)
^~~
drivers/scsi/ufs/ufs-mediatek.c:120:9: note: uninitialized use occurs
here
return ret;
^~~
drivers/scsi/ufs/ufs-mediatek.c:108:3: note: remove the 'if' if its
condition is always true
if (!on)
^~~~~~~~
drivers/scsi/ufs/ufs-mediatek.c:96:9: note: initialize the variable
'ret' to silence this warning
int ret;
^
= 0
2 warnings generated.
Remove the default case and initialize ret to -EINVAL to properly fix
this warning.
Fixes:
|
||
|---|---|---|
| .. | ||
| cdns-pltfrm.c | ||
| Kconfig | ||
| Makefile | ||
| tc-dwc-g210-pci.c | ||
| tc-dwc-g210-pltfrm.c | ||
| tc-dwc-g210.c | ||
| tc-dwc-g210.h | ||
| ufs_bsg.c | ||
| ufs_bsg.h | ||
| ufs_quirks.h | ||
| ufs-hisi.c | ||
| ufs-hisi.h | ||
| ufs-mediatek.c | ||
| ufs-mediatek.h | ||
| ufs-qcom.c | ||
| ufs-qcom.h | ||
| ufs-sysfs.c | ||
| ufs-sysfs.h | ||
| ufs.h | ||
| ufshcd-dwc.c | ||
| ufshcd-dwc.h | ||
| ufshcd-pci.c | ||
| ufshcd-pltfrm.c | ||
| ufshcd-pltfrm.h | ||
| ufshcd.c | ||
| ufshcd.h | ||
| ufshci-dwc.h | ||
| ufshci.h | ||
| unipro.h | ||