mirror of
https://github.com/torvalds/linux.git
synced 2024-11-26 06:02:05 +00:00
e4de205769
After commit45c7e8af4a
("MIPS: Remove KVM_TE support") we get a NULL pointer dereference when creating a KVM guest: [ 146.243409] Starting KVM with MIPS VZ extensions [ 149.849151] CPU 3 Unable to handle kernel paging request at virtual address 0000000000000300, epc == ffffffffc06356ec, ra == ffffffffc063568c [ 149.849177] Oops[#1]: [ 149.849182] CPU: 3 PID: 2265 Comm: qemu-system-mip Not tainted 6.4.0-rc3+ #1671 [ 149.849188] Hardware name: THTF CX TL630 Series/THTF-LS3A4000-7A1000-ML4A, BIOS KL4.1F.TF.D.166.201225.R 12/25/2020 [ 149.849192] $ 0 : 0000000000000000 000000007400cce0 0000000000400004 ffffffff8119c740 [ 149.849209] $ 4 : 000000007400cce1 000000007400cce1 0000000000000000 0000000000000000 [ 149.849221] $ 8 : 000000240058bb36 ffffffff81421ac0 0000000000000000 0000000000400dc0 [ 149.849233] $12 : 9800000102a07cc8 ffffffff80e40e38 0000000000000001 0000000000400dc0 [ 149.849245] $16 : 0000000000000000 9800000106cd0000 9800000106cd0000 9800000100cce000 [ 149.849257] $20 : ffffffffc0632b28 ffffffffc05b31b0 9800000100ccca00 0000000000400000 [ 149.849269] $24 : 9800000106cd09ce ffffffff802f69d0 [ 149.849281] $28 : 9800000102a04000 9800000102a07cd0 98000001106a8000 ffffffffc063568c [ 149.849293] Hi : 00000335b2111e66 [ 149.849295] Lo : 6668d90061ae0ae9 [ 149.849298] epc : ffffffffc06356ec kvm_vz_vcpu_setup+0xc4/0x328 [kvm] [ 149.849324] ra : ffffffffc063568c kvm_vz_vcpu_setup+0x64/0x328 [kvm] [ 149.849336] Status: 7400cce3 KX SX UX KERNEL EXL IE [ 149.849351] Cause : 1000000c (ExcCode 03) [ 149.849354] BadVA : 0000000000000300 [ 149.849357] PrId : 0014c004 (ICT Loongson-3) [ 149.849360] Modules linked in: kvm nfnetlink_queue nfnetlink_log nfnetlink fuse sha256_generic libsha256 cfg80211 rfkill binfmt_misc vfat fat snd_hda_codec_hdmi input_leds led_class snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hda_core snd_pcm snd_timer snd serio_raw xhci_pci radeon drm_suballoc_helper drm_display_helper xhci_hcd ip_tables x_tables [ 149.849432] Process qemu-system-mip (pid: 2265, threadinfo=00000000ae2982d2, task=0000000038e09ad4, tls=000000ffeba16030) [ 149.849439] Stack : 9800000000000003 9800000100ccca00 9800000100ccc000 ffffffffc062cef4 [ 149.849453] 9800000102a07d18 c89b63a7ab338e00 0000000000000000 ffffffff811a0000 [ 149.849465] 0000000000000000 9800000106cd0000 ffffffff80e59938 98000001106a8920 [ 149.849476] ffffffff80e57f30 ffffffffc062854c ffffffff811a0000 9800000102bf4240 [ 149.849488] ffffffffc05b0000 ffffffff80e3a798 000000ff78000000 000000ff78000010 [ 149.849500] 0000000000000255 98000001021f7de0 98000001023f0078 ffffffff81434000 [ 149.849511] 0000000000000000 0000000000000000 9800000102ae0000 980000025e92ae28 [ 149.849523] 0000000000000000 c89b63a7ab338e00 0000000000000001 ffffffff8119dce0 [ 149.849535] 000000ff78000010 ffffffff804f3d3c 9800000102a07eb0 0000000000000255 [ 149.849546] 0000000000000000 ffffffff8049460c 000000ff78000010 0000000000000255 [ 149.849558] ... [ 149.849565] Call Trace: [ 149.849567] [<ffffffffc06356ec>] kvm_vz_vcpu_setup+0xc4/0x328 [kvm] [ 149.849586] [<ffffffffc062cef4>] kvm_arch_vcpu_create+0x184/0x228 [kvm] [ 149.849605] [<ffffffffc062854c>] kvm_vm_ioctl+0x64c/0xf28 [kvm] [ 149.849623] [<ffffffff805209c0>] sys_ioctl+0xc8/0x118 [ 149.849631] [<ffffffff80219eb0>] syscall_common+0x34/0x58 The root cause is the deletion of kvm_mips_commpage_init() leaves vcpu ->arch.cop0 NULL. So fix it by making cop0 from a pointer to an embedded object. Fixes:45c7e8af4a
("MIPS: Remove KVM_TE support") Cc: stable@vger.kernel.org Reported-by: Yu Zhao <yuzhao@google.com> Suggested-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
347 lines
9.9 KiB
C
347 lines
9.9 KiB
C
/*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file "COPYING" in the main directory of this archive
|
|
* for more details.
|
|
*
|
|
* Copyright (C) 2012 MIPS Technologies, Inc. All rights reserved.
|
|
* Authors: Sanjay Lal <sanjayl@kymasys.com>
|
|
*/
|
|
|
|
#if !defined(_TRACE_KVM_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_KVM_H
|
|
|
|
#include <linux/tracepoint.h>
|
|
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM kvm
|
|
#define TRACE_INCLUDE_PATH .
|
|
#define TRACE_INCLUDE_FILE trace
|
|
|
|
/*
|
|
* arch/mips/kvm/mips.c
|
|
*/
|
|
extern bool kvm_trace_guest_mode_change;
|
|
int kvm_guest_mode_change_trace_reg(void);
|
|
void kvm_guest_mode_change_trace_unreg(void);
|
|
|
|
/*
|
|
* Tracepoints for VM enters
|
|
*/
|
|
DECLARE_EVENT_CLASS(kvm_transition,
|
|
TP_PROTO(struct kvm_vcpu *vcpu),
|
|
TP_ARGS(vcpu),
|
|
TP_STRUCT__entry(
|
|
__field(unsigned long, pc)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->pc = vcpu->arch.pc;
|
|
),
|
|
|
|
TP_printk("PC: 0x%08lx",
|
|
__entry->pc)
|
|
);
|
|
|
|
DEFINE_EVENT(kvm_transition, kvm_enter,
|
|
TP_PROTO(struct kvm_vcpu *vcpu),
|
|
TP_ARGS(vcpu));
|
|
|
|
DEFINE_EVENT(kvm_transition, kvm_reenter,
|
|
TP_PROTO(struct kvm_vcpu *vcpu),
|
|
TP_ARGS(vcpu));
|
|
|
|
DEFINE_EVENT(kvm_transition, kvm_out,
|
|
TP_PROTO(struct kvm_vcpu *vcpu),
|
|
TP_ARGS(vcpu));
|
|
|
|
/* The first 32 exit reasons correspond to Cause.ExcCode */
|
|
#define KVM_TRACE_EXIT_INT 0
|
|
#define KVM_TRACE_EXIT_TLBMOD 1
|
|
#define KVM_TRACE_EXIT_TLBMISS_LD 2
|
|
#define KVM_TRACE_EXIT_TLBMISS_ST 3
|
|
#define KVM_TRACE_EXIT_ADDRERR_LD 4
|
|
#define KVM_TRACE_EXIT_ADDRERR_ST 5
|
|
#define KVM_TRACE_EXIT_SYSCALL 8
|
|
#define KVM_TRACE_EXIT_BREAK_INST 9
|
|
#define KVM_TRACE_EXIT_RESVD_INST 10
|
|
#define KVM_TRACE_EXIT_COP_UNUSABLE 11
|
|
#define KVM_TRACE_EXIT_TRAP_INST 13
|
|
#define KVM_TRACE_EXIT_MSA_FPE 14
|
|
#define KVM_TRACE_EXIT_FPE 15
|
|
#define KVM_TRACE_EXIT_MSA_DISABLED 21
|
|
#define KVM_TRACE_EXIT_GUEST_EXIT 27
|
|
/* Further exit reasons */
|
|
#define KVM_TRACE_EXIT_WAIT 32
|
|
#define KVM_TRACE_EXIT_CACHE 33
|
|
#define KVM_TRACE_EXIT_SIGNAL 34
|
|
/* 32 exit reasons correspond to GuestCtl0.GExcCode (VZ) */
|
|
#define KVM_TRACE_EXIT_GEXCCODE_BASE 64
|
|
#define KVM_TRACE_EXIT_GPSI 64 /* 0 */
|
|
#define KVM_TRACE_EXIT_GSFC 65 /* 1 */
|
|
#define KVM_TRACE_EXIT_HC 66 /* 2 */
|
|
#define KVM_TRACE_EXIT_GRR 67 /* 3 */
|
|
#define KVM_TRACE_EXIT_GVA 72 /* 8 */
|
|
#define KVM_TRACE_EXIT_GHFC 73 /* 9 */
|
|
#define KVM_TRACE_EXIT_GPA 74 /* 10 */
|
|
|
|
/* Tracepoints for VM exits */
|
|
#define kvm_trace_symbol_exit_types \
|
|
{ KVM_TRACE_EXIT_INT, "Interrupt" }, \
|
|
{ KVM_TRACE_EXIT_TLBMOD, "TLB Mod" }, \
|
|
{ KVM_TRACE_EXIT_TLBMISS_LD, "TLB Miss (LD)" }, \
|
|
{ KVM_TRACE_EXIT_TLBMISS_ST, "TLB Miss (ST)" }, \
|
|
{ KVM_TRACE_EXIT_ADDRERR_LD, "Address Error (LD)" }, \
|
|
{ KVM_TRACE_EXIT_ADDRERR_ST, "Address Err (ST)" }, \
|
|
{ KVM_TRACE_EXIT_SYSCALL, "System Call" }, \
|
|
{ KVM_TRACE_EXIT_BREAK_INST, "Break Inst" }, \
|
|
{ KVM_TRACE_EXIT_RESVD_INST, "Reserved Inst" }, \
|
|
{ KVM_TRACE_EXIT_COP_UNUSABLE, "COP0/1 Unusable" }, \
|
|
{ KVM_TRACE_EXIT_TRAP_INST, "Trap Inst" }, \
|
|
{ KVM_TRACE_EXIT_MSA_FPE, "MSA FPE" }, \
|
|
{ KVM_TRACE_EXIT_FPE, "FPE" }, \
|
|
{ KVM_TRACE_EXIT_MSA_DISABLED, "MSA Disabled" }, \
|
|
{ KVM_TRACE_EXIT_GUEST_EXIT, "Guest Exit" }, \
|
|
{ KVM_TRACE_EXIT_WAIT, "WAIT" }, \
|
|
{ KVM_TRACE_EXIT_CACHE, "CACHE" }, \
|
|
{ KVM_TRACE_EXIT_SIGNAL, "Signal" }, \
|
|
{ KVM_TRACE_EXIT_GPSI, "GPSI" }, \
|
|
{ KVM_TRACE_EXIT_GSFC, "GSFC" }, \
|
|
{ KVM_TRACE_EXIT_HC, "HC" }, \
|
|
{ KVM_TRACE_EXIT_GRR, "GRR" }, \
|
|
{ KVM_TRACE_EXIT_GVA, "GVA" }, \
|
|
{ KVM_TRACE_EXIT_GHFC, "GHFC" }, \
|
|
{ KVM_TRACE_EXIT_GPA, "GPA" }
|
|
|
|
TRACE_EVENT(kvm_exit,
|
|
TP_PROTO(struct kvm_vcpu *vcpu, unsigned int reason),
|
|
TP_ARGS(vcpu, reason),
|
|
TP_STRUCT__entry(
|
|
__field(unsigned long, pc)
|
|
__field(unsigned int, reason)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->pc = vcpu->arch.pc;
|
|
__entry->reason = reason;
|
|
),
|
|
|
|
TP_printk("[%s]PC: 0x%08lx",
|
|
__print_symbolic(__entry->reason,
|
|
kvm_trace_symbol_exit_types),
|
|
__entry->pc)
|
|
);
|
|
|
|
#define KVM_TRACE_MFC0 0
|
|
#define KVM_TRACE_MTC0 1
|
|
#define KVM_TRACE_DMFC0 2
|
|
#define KVM_TRACE_DMTC0 3
|
|
#define KVM_TRACE_RDHWR 4
|
|
|
|
#define KVM_TRACE_HWR_COP0 0
|
|
#define KVM_TRACE_HWR_HWR 1
|
|
|
|
#define KVM_TRACE_COP0(REG, SEL) ((KVM_TRACE_HWR_COP0 << 8) | \
|
|
((REG) << 3) | (SEL))
|
|
#define KVM_TRACE_HWR(REG, SEL) ((KVM_TRACE_HWR_HWR << 8) | \
|
|
((REG) << 3) | (SEL))
|
|
|
|
#define kvm_trace_symbol_hwr_ops \
|
|
{ KVM_TRACE_MFC0, "MFC0" }, \
|
|
{ KVM_TRACE_MTC0, "MTC0" }, \
|
|
{ KVM_TRACE_DMFC0, "DMFC0" }, \
|
|
{ KVM_TRACE_DMTC0, "DMTC0" }, \
|
|
{ KVM_TRACE_RDHWR, "RDHWR" }
|
|
|
|
#define kvm_trace_symbol_hwr_cop \
|
|
{ KVM_TRACE_HWR_COP0, "COP0" }, \
|
|
{ KVM_TRACE_HWR_HWR, "HWR" }
|
|
|
|
#define kvm_trace_symbol_hwr_regs \
|
|
{ KVM_TRACE_COP0( 0, 0), "Index" }, \
|
|
{ KVM_TRACE_COP0( 2, 0), "EntryLo0" }, \
|
|
{ KVM_TRACE_COP0( 3, 0), "EntryLo1" }, \
|
|
{ KVM_TRACE_COP0( 4, 0), "Context" }, \
|
|
{ KVM_TRACE_COP0( 4, 2), "UserLocal" }, \
|
|
{ KVM_TRACE_COP0( 5, 0), "PageMask" }, \
|
|
{ KVM_TRACE_COP0( 6, 0), "Wired" }, \
|
|
{ KVM_TRACE_COP0( 7, 0), "HWREna" }, \
|
|
{ KVM_TRACE_COP0( 8, 0), "BadVAddr" }, \
|
|
{ KVM_TRACE_COP0( 9, 0), "Count" }, \
|
|
{ KVM_TRACE_COP0(10, 0), "EntryHi" }, \
|
|
{ KVM_TRACE_COP0(11, 0), "Compare" }, \
|
|
{ KVM_TRACE_COP0(12, 0), "Status" }, \
|
|
{ KVM_TRACE_COP0(12, 1), "IntCtl" }, \
|
|
{ KVM_TRACE_COP0(12, 2), "SRSCtl" }, \
|
|
{ KVM_TRACE_COP0(13, 0), "Cause" }, \
|
|
{ KVM_TRACE_COP0(14, 0), "EPC" }, \
|
|
{ KVM_TRACE_COP0(15, 0), "PRId" }, \
|
|
{ KVM_TRACE_COP0(15, 1), "EBase" }, \
|
|
{ KVM_TRACE_COP0(16, 0), "Config" }, \
|
|
{ KVM_TRACE_COP0(16, 1), "Config1" }, \
|
|
{ KVM_TRACE_COP0(16, 2), "Config2" }, \
|
|
{ KVM_TRACE_COP0(16, 3), "Config3" }, \
|
|
{ KVM_TRACE_COP0(16, 4), "Config4" }, \
|
|
{ KVM_TRACE_COP0(16, 5), "Config5" }, \
|
|
{ KVM_TRACE_COP0(16, 7), "Config7" }, \
|
|
{ KVM_TRACE_COP0(17, 1), "MAAR" }, \
|
|
{ KVM_TRACE_COP0(17, 2), "MAARI" }, \
|
|
{ KVM_TRACE_COP0(26, 0), "ECC" }, \
|
|
{ KVM_TRACE_COP0(30, 0), "ErrorEPC" }, \
|
|
{ KVM_TRACE_COP0(31, 2), "KScratch1" }, \
|
|
{ KVM_TRACE_COP0(31, 3), "KScratch2" }, \
|
|
{ KVM_TRACE_COP0(31, 4), "KScratch3" }, \
|
|
{ KVM_TRACE_COP0(31, 5), "KScratch4" }, \
|
|
{ KVM_TRACE_COP0(31, 6), "KScratch5" }, \
|
|
{ KVM_TRACE_COP0(31, 7), "KScratch6" }, \
|
|
{ KVM_TRACE_HWR( 0, 0), "CPUNum" }, \
|
|
{ KVM_TRACE_HWR( 1, 0), "SYNCI_Step" }, \
|
|
{ KVM_TRACE_HWR( 2, 0), "CC" }, \
|
|
{ KVM_TRACE_HWR( 3, 0), "CCRes" }, \
|
|
{ KVM_TRACE_HWR(29, 0), "ULR" }
|
|
|
|
TRACE_EVENT(kvm_hwr,
|
|
TP_PROTO(struct kvm_vcpu *vcpu, unsigned int op, unsigned int reg,
|
|
unsigned long val),
|
|
TP_ARGS(vcpu, op, reg, val),
|
|
TP_STRUCT__entry(
|
|
__field(unsigned long, val)
|
|
__field(u16, reg)
|
|
__field(u8, op)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->val = val;
|
|
__entry->reg = reg;
|
|
__entry->op = op;
|
|
),
|
|
|
|
TP_printk("%s %s (%s:%u:%u) 0x%08lx",
|
|
__print_symbolic(__entry->op,
|
|
kvm_trace_symbol_hwr_ops),
|
|
__print_symbolic(__entry->reg,
|
|
kvm_trace_symbol_hwr_regs),
|
|
__print_symbolic(__entry->reg >> 8,
|
|
kvm_trace_symbol_hwr_cop),
|
|
(__entry->reg >> 3) & 0x1f,
|
|
__entry->reg & 0x7,
|
|
__entry->val)
|
|
);
|
|
|
|
#define KVM_TRACE_AUX_RESTORE 0
|
|
#define KVM_TRACE_AUX_SAVE 1
|
|
#define KVM_TRACE_AUX_ENABLE 2
|
|
#define KVM_TRACE_AUX_DISABLE 3
|
|
#define KVM_TRACE_AUX_DISCARD 4
|
|
|
|
#define KVM_TRACE_AUX_FPU 1
|
|
#define KVM_TRACE_AUX_MSA 2
|
|
#define KVM_TRACE_AUX_FPU_MSA 3
|
|
|
|
#define kvm_trace_symbol_aux_op \
|
|
{ KVM_TRACE_AUX_RESTORE, "restore" }, \
|
|
{ KVM_TRACE_AUX_SAVE, "save" }, \
|
|
{ KVM_TRACE_AUX_ENABLE, "enable" }, \
|
|
{ KVM_TRACE_AUX_DISABLE, "disable" }, \
|
|
{ KVM_TRACE_AUX_DISCARD, "discard" }
|
|
|
|
#define kvm_trace_symbol_aux_state \
|
|
{ KVM_TRACE_AUX_FPU, "FPU" }, \
|
|
{ KVM_TRACE_AUX_MSA, "MSA" }, \
|
|
{ KVM_TRACE_AUX_FPU_MSA, "FPU & MSA" }
|
|
|
|
TRACE_EVENT(kvm_aux,
|
|
TP_PROTO(struct kvm_vcpu *vcpu, unsigned int op,
|
|
unsigned int state),
|
|
TP_ARGS(vcpu, op, state),
|
|
TP_STRUCT__entry(
|
|
__field(unsigned long, pc)
|
|
__field(u8, op)
|
|
__field(u8, state)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->pc = vcpu->arch.pc;
|
|
__entry->op = op;
|
|
__entry->state = state;
|
|
),
|
|
|
|
TP_printk("%s %s PC: 0x%08lx",
|
|
__print_symbolic(__entry->op,
|
|
kvm_trace_symbol_aux_op),
|
|
__print_symbolic(__entry->state,
|
|
kvm_trace_symbol_aux_state),
|
|
__entry->pc)
|
|
);
|
|
|
|
TRACE_EVENT(kvm_asid_change,
|
|
TP_PROTO(struct kvm_vcpu *vcpu, unsigned int old_asid,
|
|
unsigned int new_asid),
|
|
TP_ARGS(vcpu, old_asid, new_asid),
|
|
TP_STRUCT__entry(
|
|
__field(unsigned long, pc)
|
|
__field(u8, old_asid)
|
|
__field(u8, new_asid)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->pc = vcpu->arch.pc;
|
|
__entry->old_asid = old_asid;
|
|
__entry->new_asid = new_asid;
|
|
),
|
|
|
|
TP_printk("PC: 0x%08lx old: 0x%02x new: 0x%02x",
|
|
__entry->pc,
|
|
__entry->old_asid,
|
|
__entry->new_asid)
|
|
);
|
|
|
|
TRACE_EVENT(kvm_guestid_change,
|
|
TP_PROTO(struct kvm_vcpu *vcpu, unsigned int guestid),
|
|
TP_ARGS(vcpu, guestid),
|
|
TP_STRUCT__entry(
|
|
__field(unsigned int, guestid)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->guestid = guestid;
|
|
),
|
|
|
|
TP_printk("GuestID: 0x%02x",
|
|
__entry->guestid)
|
|
);
|
|
|
|
TRACE_EVENT_FN(kvm_guest_mode_change,
|
|
TP_PROTO(struct kvm_vcpu *vcpu),
|
|
TP_ARGS(vcpu),
|
|
TP_STRUCT__entry(
|
|
__field(unsigned long, epc)
|
|
__field(unsigned long, pc)
|
|
__field(unsigned long, badvaddr)
|
|
__field(unsigned int, status)
|
|
__field(unsigned int, cause)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->epc = kvm_read_c0_guest_epc(&vcpu->arch.cop0);
|
|
__entry->pc = vcpu->arch.pc;
|
|
__entry->badvaddr = kvm_read_c0_guest_badvaddr(&vcpu->arch.cop0);
|
|
__entry->status = kvm_read_c0_guest_status(&vcpu->arch.cop0);
|
|
__entry->cause = kvm_read_c0_guest_cause(&vcpu->arch.cop0);
|
|
),
|
|
|
|
TP_printk("EPC: 0x%08lx PC: 0x%08lx Status: 0x%08x Cause: 0x%08x BadVAddr: 0x%08lx",
|
|
__entry->epc,
|
|
__entry->pc,
|
|
__entry->status,
|
|
__entry->cause,
|
|
__entry->badvaddr),
|
|
|
|
kvm_guest_mode_change_trace_reg,
|
|
kvm_guest_mode_change_trace_unreg
|
|
);
|
|
|
|
#endif /* _TRACE_KVM_H */
|
|
|
|
/* This part must be outside protection */
|
|
#include <trace/define_trace.h>
|