mirror of
https://github.com/torvalds/linux.git
synced 2024-12-26 21:02:19 +00:00
5a0e3ad6af
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
125 lines
3.3 KiB
C
125 lines
3.3 KiB
C
/*
|
|
* IBM eServer eHCA Infiniband device driver for Linux on POWER
|
|
*
|
|
* PD functions
|
|
*
|
|
* Authors: Christoph Raisch <raisch@de.ibm.com>
|
|
*
|
|
* Copyright (c) 2005 IBM Corporation
|
|
*
|
|
* All rights reserved.
|
|
*
|
|
* This source code is distributed under a dual license of GPL v2.0 and OpenIB
|
|
* BSD.
|
|
*
|
|
* OpenIB BSD License
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials
|
|
* provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
|
|
* BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER
|
|
* IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include "ehca_tools.h"
|
|
#include "ehca_iverbs.h"
|
|
|
|
static struct kmem_cache *pd_cache;
|
|
|
|
struct ib_pd *ehca_alloc_pd(struct ib_device *device,
|
|
struct ib_ucontext *context, struct ib_udata *udata)
|
|
{
|
|
struct ehca_pd *pd;
|
|
int i;
|
|
|
|
pd = kmem_cache_zalloc(pd_cache, GFP_KERNEL);
|
|
if (!pd) {
|
|
ehca_err(device, "device=%p context=%p out of memory",
|
|
device, context);
|
|
return ERR_PTR(-ENOMEM);
|
|
}
|
|
|
|
for (i = 0; i < 2; i++) {
|
|
INIT_LIST_HEAD(&pd->free[i]);
|
|
INIT_LIST_HEAD(&pd->full[i]);
|
|
}
|
|
mutex_init(&pd->lock);
|
|
|
|
/*
|
|
* Kernel PD: when device = -1, 0
|
|
* User PD: when context != -1
|
|
*/
|
|
if (!context) {
|
|
/*
|
|
* Kernel PDs after init reuses always
|
|
* the one created in ehca_shca_reopen()
|
|
*/
|
|
struct ehca_shca *shca = container_of(device, struct ehca_shca,
|
|
ib_device);
|
|
pd->fw_pd.value = shca->pd->fw_pd.value;
|
|
} else
|
|
pd->fw_pd.value = (u64)pd;
|
|
|
|
return &pd->ib_pd;
|
|
}
|
|
|
|
int ehca_dealloc_pd(struct ib_pd *pd)
|
|
{
|
|
struct ehca_pd *my_pd = container_of(pd, struct ehca_pd, ib_pd);
|
|
int i, leftovers = 0;
|
|
struct ipz_small_queue_page *page, *tmp;
|
|
|
|
for (i = 0; i < 2; i++) {
|
|
list_splice(&my_pd->full[i], &my_pd->free[i]);
|
|
list_for_each_entry_safe(page, tmp, &my_pd->free[i], list) {
|
|
leftovers = 1;
|
|
free_page(page->page);
|
|
kmem_cache_free(small_qp_cache, page);
|
|
}
|
|
}
|
|
|
|
if (leftovers)
|
|
ehca_warn(pd->device,
|
|
"Some small queue pages were not freed");
|
|
|
|
kmem_cache_free(pd_cache, my_pd);
|
|
|
|
return 0;
|
|
}
|
|
|
|
int ehca_init_pd_cache(void)
|
|
{
|
|
pd_cache = kmem_cache_create("ehca_cache_pd",
|
|
sizeof(struct ehca_pd), 0,
|
|
SLAB_HWCACHE_ALIGN,
|
|
NULL);
|
|
if (!pd_cache)
|
|
return -ENOMEM;
|
|
return 0;
|
|
}
|
|
|
|
void ehca_cleanup_pd_cache(void)
|
|
{
|
|
if (pd_cache)
|
|
kmem_cache_destroy(pd_cache);
|
|
}
|