Wanpeng Li 17e433b543 KVM: Fix leak vCPU's VMCS value into other pCPU ... After commit d73eb57b80 (KVM: Boost vCPUs that are delivering interrupts), a five years old bug is exposed. Running ebizzy benchmark in three 80 vCPUs VMs on one 80 pCPUs Skylake server, a lot of rcu_sched stall warning splatting in the VMs after stress testing: INFO: rcu_sched detected stalls on CPUs/tasks: { 4 41 57 62 77} (detected by 15, t=60004 jiffies, g=899, c=898, q=15073) Call Trace: flush_tlb_mm_range+0x68/0x140 tlb_flush_mmu.part.75+0x37/0xe0 tlb_finish_mmu+0x55/0x60 zap_page_range+0x142/0x190 SyS_madvise+0x3cd/0x9c0 system_call_fastpath+0x1c/0x21 swait_active() sustains to be true before finish_swait() is called in kvm_vcpu_block(), voluntarily preempted vCPUs are taken into account by kvm_vcpu_on_spin() loop greatly increases the probability condition kvm_arch_vcpu_runnable(vcpu) is checked and can be true, when APICv is enabled the yield-candidate vCPU's VMCS RVI field leaks(by vmx_sync_pir_to_irr()) into spinning-on-a-taken-lock vCPU's current VMCS. This patch fixes it by checking conservatively a subset of events. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Radim Krčmář <rkrcmar@redhat.com> Cc: Christian Borntraeger <borntraeger@de.ibm.com> Cc: Marc Zyngier <Marc.Zyngier@arm.com> Cc: stable@vger.kernel.org Fixes: 98f4a1467 (KVM: add kvm_arch_vcpu_runnable() test to kvm_vcpu_on_spin() loop) Signed-off-by: Wanpeng Li <wanpengli@tencent.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>		2019-08-05 12:55:47 +02:00
..
capabilities.h	KVM: VMX: Include architectural defs header in capabilities.h	2019-04-30 21:32:21 +02:00
evmcs.c	x86/kvm/nVMX: fix VMCLEAR when Enlightened VMCS is in use	2019-07-02 18:56:00 +02:00
evmcs.h	x86/kvm/nVMX: fix VMCLEAR when Enlightened VMCS is in use	2019-07-02 18:56:00 +02:00
nested.c	KVM: nVMX: Set cached_vmcs12 and cached_shadow_vmcs12 NULL after free	2019-07-22 13:55:49 +02:00
nested.h	KVM: nVMX: Use descriptive names for VMCS sync functions and flags	2019-06-18 11:46:06 +02:00
ops.h	KVM: VMX: remove unneeded 'asm volatile ("")' from vmcs_write64	2019-06-05 14:14:49 +02:00
pmu_intel.c	KVM: x86/vPMU: reset pmc->counter to 0 for pmu fixed_counters	2019-07-17 12:23:20 +02:00
vmcs12.c
vmcs12.h	KVM/arm updates for 5.3	2019-07-11 15:14:16 +02:00
vmcs_shadow_fields.h	KVM: nVMX: shadow pin based execution controls	2019-06-18 17:10:50 +02:00
vmcs.h	KVM: VMX: Leave preemption timer running when it's disabled	2019-06-18 17:10:46 +02:00
vmenter.S	KVM: VMX: Move RSB stuffing to before the first RET after VM-Exit	2019-04-27 09:48:52 +02:00
vmx.c	KVM: Fix leak vCPU's VMCS value into other pCPU	2019-08-05 12:55:47 +02:00
vmx.h	KVM: VMX: Explicitly initialize controls shadow at VMCS allocation	2019-06-18 11:47:44 +02:00