mirror of
https://github.com/torvalds/linux.git
synced 2024-12-25 04:11:49 +00:00
5a0e3ad6af
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
298 lines
7.1 KiB
C
298 lines
7.1 KiB
C
/*
|
|
* Generic implementation of a polled input device
|
|
|
|
* Copyright (c) 2007 Dmitry Torokhov
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License version 2 as published by
|
|
* the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/jiffies.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/input-polldev.h>
|
|
|
|
MODULE_AUTHOR("Dmitry Torokhov <dtor@mail.ru>");
|
|
MODULE_DESCRIPTION("Generic implementation of a polled input device");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_VERSION("0.1");
|
|
|
|
static DEFINE_MUTEX(polldev_mutex);
|
|
static int polldev_users;
|
|
static struct workqueue_struct *polldev_wq;
|
|
|
|
static int input_polldev_start_workqueue(void)
|
|
{
|
|
int retval;
|
|
|
|
retval = mutex_lock_interruptible(&polldev_mutex);
|
|
if (retval)
|
|
return retval;
|
|
|
|
if (!polldev_users) {
|
|
polldev_wq = create_singlethread_workqueue("ipolldevd");
|
|
if (!polldev_wq) {
|
|
printk(KERN_ERR "input-polldev: failed to create "
|
|
"ipolldevd workqueue\n");
|
|
retval = -ENOMEM;
|
|
goto out;
|
|
}
|
|
}
|
|
|
|
polldev_users++;
|
|
|
|
out:
|
|
mutex_unlock(&polldev_mutex);
|
|
return retval;
|
|
}
|
|
|
|
static void input_polldev_stop_workqueue(void)
|
|
{
|
|
mutex_lock(&polldev_mutex);
|
|
|
|
if (!--polldev_users)
|
|
destroy_workqueue(polldev_wq);
|
|
|
|
mutex_unlock(&polldev_mutex);
|
|
}
|
|
|
|
static void input_polldev_queue_work(struct input_polled_dev *dev)
|
|
{
|
|
unsigned long delay;
|
|
|
|
delay = msecs_to_jiffies(dev->poll_interval);
|
|
if (delay >= HZ)
|
|
delay = round_jiffies_relative(delay);
|
|
|
|
queue_delayed_work(polldev_wq, &dev->work, delay);
|
|
}
|
|
|
|
static void input_polled_device_work(struct work_struct *work)
|
|
{
|
|
struct input_polled_dev *dev =
|
|
container_of(work, struct input_polled_dev, work.work);
|
|
|
|
dev->poll(dev);
|
|
input_polldev_queue_work(dev);
|
|
}
|
|
|
|
static int input_open_polled_device(struct input_dev *input)
|
|
{
|
|
struct input_polled_dev *dev = input_get_drvdata(input);
|
|
int error;
|
|
|
|
error = input_polldev_start_workqueue();
|
|
if (error)
|
|
return error;
|
|
|
|
if (dev->open)
|
|
dev->open(dev);
|
|
|
|
/* Only start polling if polling is enabled */
|
|
if (dev->poll_interval > 0)
|
|
queue_delayed_work(polldev_wq, &dev->work, 0);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void input_close_polled_device(struct input_dev *input)
|
|
{
|
|
struct input_polled_dev *dev = input_get_drvdata(input);
|
|
|
|
cancel_delayed_work_sync(&dev->work);
|
|
/*
|
|
* Clean up work struct to remove references to the workqueue.
|
|
* It may be destroyed by the next call. This causes problems
|
|
* at next device open-close in case of poll_interval == 0.
|
|
*/
|
|
INIT_DELAYED_WORK(&dev->work, dev->work.work.func);
|
|
input_polldev_stop_workqueue();
|
|
|
|
if (dev->close)
|
|
dev->close(dev);
|
|
}
|
|
|
|
/* SYSFS interface */
|
|
|
|
static ssize_t input_polldev_get_poll(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct input_polled_dev *polldev = dev_get_drvdata(dev);
|
|
|
|
return sprintf(buf, "%d\n", polldev->poll_interval);
|
|
}
|
|
|
|
static ssize_t input_polldev_set_poll(struct device *dev,
|
|
struct device_attribute *attr, const char *buf,
|
|
size_t count)
|
|
{
|
|
struct input_polled_dev *polldev = dev_get_drvdata(dev);
|
|
struct input_dev *input = polldev->input;
|
|
unsigned long interval;
|
|
|
|
if (strict_strtoul(buf, 0, &interval))
|
|
return -EINVAL;
|
|
|
|
if (interval < polldev->poll_interval_min)
|
|
return -EINVAL;
|
|
|
|
if (interval > polldev->poll_interval_max)
|
|
return -EINVAL;
|
|
|
|
mutex_lock(&input->mutex);
|
|
|
|
polldev->poll_interval = interval;
|
|
|
|
if (input->users) {
|
|
cancel_delayed_work_sync(&polldev->work);
|
|
if (polldev->poll_interval > 0)
|
|
input_polldev_queue_work(polldev);
|
|
}
|
|
|
|
mutex_unlock(&input->mutex);
|
|
|
|
return count;
|
|
}
|
|
|
|
static DEVICE_ATTR(poll, S_IRUGO | S_IWUSR, input_polldev_get_poll,
|
|
input_polldev_set_poll);
|
|
|
|
|
|
static ssize_t input_polldev_get_max(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct input_polled_dev *polldev = dev_get_drvdata(dev);
|
|
|
|
return sprintf(buf, "%d\n", polldev->poll_interval_max);
|
|
}
|
|
|
|
static DEVICE_ATTR(max, S_IRUGO, input_polldev_get_max, NULL);
|
|
|
|
static ssize_t input_polldev_get_min(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct input_polled_dev *polldev = dev_get_drvdata(dev);
|
|
|
|
return sprintf(buf, "%d\n", polldev->poll_interval_min);
|
|
}
|
|
|
|
static DEVICE_ATTR(min, S_IRUGO, input_polldev_get_min, NULL);
|
|
|
|
static struct attribute *sysfs_attrs[] = {
|
|
&dev_attr_poll.attr,
|
|
&dev_attr_max.attr,
|
|
&dev_attr_min.attr,
|
|
NULL
|
|
};
|
|
|
|
static struct attribute_group input_polldev_attribute_group = {
|
|
.attrs = sysfs_attrs
|
|
};
|
|
|
|
/**
|
|
* input_allocate_polled_device - allocated memory polled device
|
|
*
|
|
* The function allocates memory for a polled device and also
|
|
* for an input device associated with this polled device.
|
|
*/
|
|
struct input_polled_dev *input_allocate_polled_device(void)
|
|
{
|
|
struct input_polled_dev *dev;
|
|
|
|
dev = kzalloc(sizeof(struct input_polled_dev), GFP_KERNEL);
|
|
if (!dev)
|
|
return NULL;
|
|
|
|
dev->input = input_allocate_device();
|
|
if (!dev->input) {
|
|
kfree(dev);
|
|
return NULL;
|
|
}
|
|
|
|
return dev;
|
|
}
|
|
EXPORT_SYMBOL(input_allocate_polled_device);
|
|
|
|
/**
|
|
* input_free_polled_device - free memory allocated for polled device
|
|
* @dev: device to free
|
|
*
|
|
* The function frees memory allocated for polling device and drops
|
|
* reference to the associated input device.
|
|
*/
|
|
void input_free_polled_device(struct input_polled_dev *dev)
|
|
{
|
|
if (dev) {
|
|
input_free_device(dev->input);
|
|
kfree(dev);
|
|
}
|
|
}
|
|
EXPORT_SYMBOL(input_free_polled_device);
|
|
|
|
/**
|
|
* input_register_polled_device - register polled device
|
|
* @dev: device to register
|
|
*
|
|
* The function registers previously initialized polled input device
|
|
* with input layer. The device should be allocated with call to
|
|
* input_allocate_polled_device(). Callers should also set up poll()
|
|
* method and set up capabilities (id, name, phys, bits) of the
|
|
* corresponing input_dev structure.
|
|
*/
|
|
int input_register_polled_device(struct input_polled_dev *dev)
|
|
{
|
|
struct input_dev *input = dev->input;
|
|
int error;
|
|
|
|
input_set_drvdata(input, dev);
|
|
INIT_DELAYED_WORK(&dev->work, input_polled_device_work);
|
|
if (!dev->poll_interval)
|
|
dev->poll_interval = 500;
|
|
if (!dev->poll_interval_max)
|
|
dev->poll_interval_max = dev->poll_interval;
|
|
input->open = input_open_polled_device;
|
|
input->close = input_close_polled_device;
|
|
|
|
error = input_register_device(input);
|
|
if (error)
|
|
return error;
|
|
|
|
error = sysfs_create_group(&input->dev.kobj,
|
|
&input_polldev_attribute_group);
|
|
if (error) {
|
|
input_unregister_device(input);
|
|
return error;
|
|
}
|
|
|
|
/*
|
|
* Take extra reference to the underlying input device so
|
|
* that it survives call to input_unregister_polled_device()
|
|
* and is deleted only after input_free_polled_device()
|
|
* has been invoked. This is needed to ease task of freeing
|
|
* sparse keymaps.
|
|
*/
|
|
input_get_device(input);
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL(input_register_polled_device);
|
|
|
|
/**
|
|
* input_unregister_polled_device - unregister polled device
|
|
* @dev: device to unregister
|
|
*
|
|
* The function unregisters previously registered polled input
|
|
* device from input layer. Polling is stopped and device is
|
|
* ready to be freed with call to input_free_polled_device().
|
|
*/
|
|
void input_unregister_polled_device(struct input_polled_dev *dev)
|
|
{
|
|
sysfs_remove_group(&dev->input->dev.kobj,
|
|
&input_polldev_attribute_group);
|
|
|
|
input_unregister_device(dev->input);
|
|
}
|
|
EXPORT_SYMBOL(input_unregister_polled_device);
|
|
|