mirror of
https://github.com/torvalds/linux.git
synced 2024-11-26 06:02:05 +00:00
9979cc6485
The devm_clk_get_enabled() helper:
- calls devm_clk_get()
- calls clk_prepare_enable() and registers what is needed in order to
call clk_disable_unprepare() when needed, as a managed resource.
Also replace devm_regulator_get() and regulator_enable() with
devm_regulator_get_enable() helper and remove regulator_disable().
Replace iio_device_register() with devm_iio_device_register() and remove
iio_device_unregister().
And st->reg is not used anymore, so remove it.
As Jonathan pointed out, couple of things that are wrong:
1) The device is powered down 'before' we unregister it with the
subsystem and as such userspace interfaces are still exposed which
probably won't do the right thing if the chip is powered down.
2) This isn't done in the error paths in probe.
To solve this problem, register a new callback adf4350_power_down()
with devm_add_action_or_reset(), to enable software power down in both
error and device detach path. So the remove function can be removed.
Remove spi_set_drvdata() from the probe function, since spi_get_drvdata()
is not used anymore.
Fixes:
|
||
|---|---|---|
| .. | ||
| ad9523.c | ||
| adf4350.c | ||
| adf4371.c | ||
| adf4377.c | ||
| admv1013.c | ||
| admv1014.c | ||
| admv4420.c | ||
| adrf6780.c | ||
| Kconfig | ||
| Makefile | ||