mirror of
https://github.com/torvalds/linux.git
synced 2024-12-23 11:21:33 +00:00
292a089d78
Due to several bugs caused by timers being re-armed after they are
shutdown and just before they are freed, a new state of timers was added
called "shutdown". After a timer is set to this state, then it can no
longer be re-armed.
The following script was run to find all the trivial locations where
del_timer() or del_timer_sync() is called in the same function that the
object holding the timer is freed. It also ignores any locations where
the timer->function is modified between the del_timer*() and the free(),
as that is not considered a "trivial" case.
This was created by using a coccinelle script and the following
commands:
$ cat timer.cocci
@@
expression ptr, slab;
identifier timer, rfield;
@@
(
- del_timer(&ptr->timer);
+ timer_shutdown(&ptr->timer);
|
- del_timer_sync(&ptr->timer);
+ timer_shutdown_sync(&ptr->timer);
)
... when strict
when != ptr->timer
(
kfree_rcu(ptr, rfield);
|
kmem_cache_free(slab, ptr);
|
kfree(ptr);
)
$ spatch timer.cocci . > /tmp/t.patch
$ patch -p1 < /tmp/t.patch
Link: https://lore.kernel.org/lkml/20221123201306.823305113@linutronix.de/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Pavel Machek <pavel@ucw.cz> [ LED ]
Acked-by: Kalle Valo <kvalo@kernel.org> [ wireless ]
Acked-by: Paolo Abeni <pabeni@redhat.com> [ networking ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| pvrusb2-audio.c | ||
| pvrusb2-audio.h | ||
| pvrusb2-context.c | ||
| pvrusb2-context.h | ||
| pvrusb2-cs53l32a.c | ||
| pvrusb2-cs53l32a.h | ||
| pvrusb2-ctrl.c | ||
| pvrusb2-ctrl.h | ||
| pvrusb2-cx2584x-v4l.c | ||
| pvrusb2-cx2584x-v4l.h | ||
| pvrusb2-debug.h | ||
| pvrusb2-debugifc.c | ||
| pvrusb2-debugifc.h | ||
| pvrusb2-devattr.c | ||
| pvrusb2-devattr.h | ||
| pvrusb2-dvb.c | ||
| pvrusb2-dvb.h | ||
| pvrusb2-eeprom.c | ||
| pvrusb2-eeprom.h | ||
| pvrusb2-encoder.c | ||
| pvrusb2-encoder.h | ||
| pvrusb2-fx2-cmd.h | ||
| pvrusb2-hdw-internal.h | ||
| pvrusb2-hdw.c | ||
| pvrusb2-hdw.h | ||
| pvrusb2-i2c-core.c | ||
| pvrusb2-i2c-core.h | ||
| pvrusb2-io.c | ||
| pvrusb2-io.h | ||
| pvrusb2-ioread.c | ||
| pvrusb2-ioread.h | ||
| pvrusb2-main.c | ||
| pvrusb2-std.c | ||
| pvrusb2-std.h | ||
| pvrusb2-sysfs.c | ||
| pvrusb2-sysfs.h | ||
| pvrusb2-util.h | ||
| pvrusb2-v4l2.c | ||
| pvrusb2-v4l2.h | ||
| pvrusb2-video-v4l.c | ||
| pvrusb2-video-v4l.h | ||
| pvrusb2-wm8775.c | ||
| pvrusb2-wm8775.h | ||
| pvrusb2.h | ||