mirror of
https://github.com/torvalds/linux.git
synced 2024-12-17 16:43:08 +00:00
9b174527e7
In the media drivers, the v4l2 core knows about all submodules and calls into them from a common function. However this cannot work if the modules that get called are loadable and the core is built-in. In that case we get drivers/built-in.o: In function `set_type': drivers/media/v4l2-core/tuner-core.c:301: undefined reference to `tea5767_attach' drivers/media/v4l2-core/tuner-core.c:307: undefined reference to `tea5761_attach' drivers/media/v4l2-core/tuner-core.c:349: undefined reference to `tda9887_attach' drivers/media/v4l2-core/tuner-core.c:405: undefined reference to `xc4000_attach' This was working previously, until the IS_ENABLED() macro was used to replace the construct like #if defined(CONFIG_DVB_CX24110) || (defined(CONFIG_DVB_CX24110_MODULE) && defined(MODULE)) with the difference that the new code no longer checks whether it is being built as a loadable module itself. To fix this, this new patch adds an 'IS_REACHABLE' macro, which evaluates true in exactly the condition that was used previously. The downside of this is that this trades an obvious link error for a more subtle runtime failure, but it is clear that the change that introduced the link error was unintentional and it seems better to revert it for now. Also, a similar change was originally created by Trent Piepho and then reverted by teh change to the IS_ENABLED macro. Ideally Kconfig would be used to avoid the case of a broken dependency, or the code restructured in a way to turn around the dependency, but either way would require much larger changes here. Fixes:7b34be71db("[media] use IS_ENABLED() macro") See-also:c5dec9fb24("V4L/DVB (4751): Fix DBV_FE_CUSTOMISE for card drivers compiled into kernel") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
75 lines
2.0 KiB
C
75 lines
2.0 KiB
C
/*
|
|
* stv0900.h
|
|
*
|
|
* Driver for ST STV0900 satellite demodulator IC.
|
|
*
|
|
* Copyright (C) ST Microelectronics.
|
|
* Copyright (C) 2009 NetUP Inc.
|
|
* Copyright (C) 2009 Igor M. Liplianin <liplianin@netup.ru>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
*
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
*/
|
|
|
|
#ifndef STV0900_H
|
|
#define STV0900_H
|
|
|
|
#include <linux/kconfig.h>
|
|
#include <linux/dvb/frontend.h>
|
|
#include "dvb_frontend.h"
|
|
|
|
struct stv0900_reg {
|
|
u16 addr;
|
|
u8 val;
|
|
};
|
|
|
|
struct stv0900_config {
|
|
u8 demod_address;
|
|
u8 demod_mode;
|
|
u32 xtal;
|
|
u8 clkmode;/* 0 for CLKI, 2 for XTALI */
|
|
|
|
u8 diseqc_mode;
|
|
|
|
u8 path1_mode;
|
|
u8 path2_mode;
|
|
struct stv0900_reg *ts_config_regs;
|
|
u8 tun1_maddress;/* 0, 1, 2, 3 for 0xc0, 0xc2, 0xc4, 0xc6 */
|
|
u8 tun2_maddress;
|
|
u8 tun1_adc;/* 1 for stv6110, 2 for stb6100 */
|
|
u8 tun2_adc;
|
|
u8 tun1_type;/* for now 3 for stb6100 auto, else - software */
|
|
u8 tun2_type;
|
|
/* Set device param to start dma */
|
|
int (*set_ts_params)(struct dvb_frontend *fe, int is_punctured);
|
|
/* Hook for Lock LED */
|
|
void (*set_lock_led)(struct dvb_frontend *fe, int offon);
|
|
};
|
|
|
|
#if IS_REACHABLE(CONFIG_DVB_STV0900)
|
|
extern struct dvb_frontend *stv0900_attach(const struct stv0900_config *config,
|
|
struct i2c_adapter *i2c, int demod);
|
|
#else
|
|
static inline struct dvb_frontend *stv0900_attach(const struct stv0900_config *config,
|
|
struct i2c_adapter *i2c, int demod)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return NULL;
|
|
}
|
|
#endif
|
|
|
|
#endif
|
|
|