mirror of
https://github.com/torvalds/linux.git
synced 2024-12-06 11:01:43 +00:00
0561e514c9
Drivers that need to tweak a device IDENTIFY data implement the read_id() port operation. The IDENTIFY data buffer is passed as an argument to the read_id() operation for drivers to use. However, when this operation is called, the IDENTIFY data is not yet converted to CPU endian and contains le16 words. Change the interface of the read_id operation to pass a __le16 * pointer to the IDENTIFY data buffer to clarify the buffer endianness. Fix the pata_netcell, pata_it821x, ahci_xgene, ahci_ceva and ahci_brcm drivers implementation of this operation and modify the code to corretly deal with identify data words manipulation to avoid sparse warnings such as: drivers/ata/ahci_xgene.c:262:33: warning: invalid assignment: &= drivers/ata/ahci_xgene.c:262:33: left side has type unsigned short drivers/ata/ahci_xgene.c:262:33: right side has type restricted __le16 Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> Reviewed-by: Hannes Reinecke <hare@suse.de>
110 lines
2.7 KiB
C
110 lines
2.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* pata_netcell.c - Netcell PATA driver
|
|
*
|
|
* (c) 2006 Red Hat
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/blkdev.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/device.h>
|
|
#include <scsi/scsi_host.h>
|
|
#include <linux/libata.h>
|
|
#include <linux/ata.h>
|
|
|
|
#define DRV_NAME "pata_netcell"
|
|
#define DRV_VERSION "0.1.7"
|
|
|
|
/* No PIO or DMA methods needed for this device */
|
|
|
|
static unsigned int netcell_read_id(struct ata_device *adev,
|
|
struct ata_taskfile *tf, __le16 *id)
|
|
{
|
|
unsigned int err_mask = ata_do_dev_read_id(adev, tf, id);
|
|
|
|
/* Firmware forgets to mark words 85-87 valid */
|
|
if (err_mask == 0)
|
|
id[ATA_ID_CSF_DEFAULT] |= cpu_to_le16(0x4000);
|
|
return err_mask;
|
|
}
|
|
|
|
static struct scsi_host_template netcell_sht = {
|
|
ATA_BMDMA_SHT(DRV_NAME),
|
|
};
|
|
|
|
static struct ata_port_operations netcell_ops = {
|
|
.inherits = &ata_bmdma_port_ops,
|
|
.cable_detect = ata_cable_80wire,
|
|
.read_id = netcell_read_id,
|
|
};
|
|
|
|
|
|
/**
|
|
* netcell_init_one - Register Netcell ATA PCI device with kernel services
|
|
* @pdev: PCI device to register
|
|
* @ent: Entry in netcell_pci_tbl matching with @pdev
|
|
*
|
|
* Called from kernel PCI layer.
|
|
*
|
|
* LOCKING:
|
|
* Inherited from PCI layer (may sleep).
|
|
*
|
|
* RETURNS:
|
|
* Zero on success, or -ERRNO value.
|
|
*/
|
|
|
|
static int netcell_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
|
|
{
|
|
static const struct ata_port_info info = {
|
|
.flags = ATA_FLAG_SLAVE_POSS,
|
|
/* Actually we don't really care about these as the
|
|
firmware deals with it */
|
|
.pio_mask = ATA_PIO4,
|
|
.mwdma_mask = ATA_MWDMA2,
|
|
.udma_mask = ATA_UDMA5, /* UDMA 133 */
|
|
.port_ops = &netcell_ops,
|
|
};
|
|
const struct ata_port_info *port_info[] = { &info, NULL };
|
|
int rc;
|
|
|
|
ata_print_version_once(&pdev->dev, DRV_VERSION);
|
|
|
|
rc = pcim_enable_device(pdev);
|
|
if (rc)
|
|
return rc;
|
|
|
|
/* Any chip specific setup/optimisation/messages here */
|
|
ata_pci_bmdma_clear_simplex(pdev);
|
|
|
|
/* And let the library code do the work */
|
|
return ata_pci_bmdma_init_one(pdev, port_info, &netcell_sht, NULL, 0);
|
|
}
|
|
|
|
static const struct pci_device_id netcell_pci_tbl[] = {
|
|
{ PCI_VDEVICE(NETCELL, PCI_DEVICE_ID_REVOLUTION), },
|
|
|
|
{ } /* terminate list */
|
|
};
|
|
|
|
static struct pci_driver netcell_pci_driver = {
|
|
.name = DRV_NAME,
|
|
.id_table = netcell_pci_tbl,
|
|
.probe = netcell_init_one,
|
|
.remove = ata_pci_remove_one,
|
|
#ifdef CONFIG_PM_SLEEP
|
|
.suspend = ata_pci_device_suspend,
|
|
.resume = ata_pci_device_resume,
|
|
#endif
|
|
};
|
|
|
|
module_pci_driver(netcell_pci_driver);
|
|
|
|
MODULE_AUTHOR("Alan Cox");
|
|
MODULE_DESCRIPTION("SCSI low-level driver for Netcell PATA RAID");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DEVICE_TABLE(pci, netcell_pci_tbl);
|
|
MODULE_VERSION(DRV_VERSION);
|