mirror of
https://github.com/torvalds/linux.git
synced 2024-12-02 09:01:34 +00:00
5164c78898
This change adds a parameter to the {devm_}iio_triggered_buffer_setup()
functions to assign the extra sysfs buffer attributes that are typically
assigned via iio_buffer_set_attrs().
The functions also get renamed to iio_triggered_buffer_setup_ext() &
devm_iio_triggered_buffer_setup_ext().
For backwards compatibility the old {devm_}iio_triggered_buffer_setup()
functions are now macros wrap the new (renamed) functions with NULL for the
buffer attrs.
The aim is to remove iio_buffer_set_attrs(), so in the
iio_triggered_buffer_setup_ext() function the attributes are assigned
directly to 'buffer->attrs'.
When adding multiple IIO buffers per IIO device, it can be pretty
cumbersome to first allocate a set of buffers, then to dig them out of IIO
to assign extra attributes (with iio_buffer_set_attrs()).
Naturally, the best way would be to provide them at allocation time, which
is what this change does.
At this moment, buffers allocated with {devm_}iio_triggered_buffer_setup()
are the only ones in mainline IIO to call iio_buffer_set_attrs().
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200929125949.69934-4-alexandru.ardelean@analog.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
131 lines
3.6 KiB
C
131 lines
3.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2012 Analog Devices, Inc.
|
|
* Author: Lars-Peter Clausen <lars@metafoo.de>
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/export.h>
|
|
#include <linux/module.h>
|
|
#include <linux/iio/iio.h>
|
|
#include <linux/iio/buffer.h>
|
|
#include <linux/iio/buffer_impl.h>
|
|
#include <linux/iio/kfifo_buf.h>
|
|
#include <linux/iio/triggered_buffer.h>
|
|
#include <linux/iio/trigger_consumer.h>
|
|
|
|
/**
|
|
* iio_triggered_buffer_setup_ext() - Setup triggered buffer and pollfunc
|
|
* @indio_dev: IIO device structure
|
|
* @h: Function which will be used as pollfunc top half
|
|
* @thread: Function which will be used as pollfunc bottom half
|
|
* @setup_ops: Buffer setup functions to use for this device.
|
|
* If NULL the default setup functions for triggered
|
|
* buffers will be used.
|
|
* @buffer_attrs: Extra sysfs buffer attributes for this IIO buffer
|
|
*
|
|
* This function combines some common tasks which will normally be performed
|
|
* when setting up a triggered buffer. It will allocate the buffer and the
|
|
* pollfunc.
|
|
*
|
|
* Before calling this function the indio_dev structure should already be
|
|
* completely initialized, but not yet registered. In practice this means that
|
|
* this function should be called right before iio_device_register().
|
|
*
|
|
* To free the resources allocated by this function call
|
|
* iio_triggered_buffer_cleanup().
|
|
*/
|
|
int iio_triggered_buffer_setup_ext(struct iio_dev *indio_dev,
|
|
irqreturn_t (*h)(int irq, void *p),
|
|
irqreturn_t (*thread)(int irq, void *p),
|
|
const struct iio_buffer_setup_ops *setup_ops,
|
|
const struct attribute **buffer_attrs)
|
|
{
|
|
struct iio_buffer *buffer;
|
|
int ret;
|
|
|
|
buffer = iio_kfifo_allocate();
|
|
if (!buffer) {
|
|
ret = -ENOMEM;
|
|
goto error_ret;
|
|
}
|
|
|
|
iio_device_attach_buffer(indio_dev, buffer);
|
|
|
|
indio_dev->pollfunc = iio_alloc_pollfunc(h,
|
|
thread,
|
|
IRQF_ONESHOT,
|
|
indio_dev,
|
|
"%s_consumer%d",
|
|
indio_dev->name,
|
|
indio_dev->id);
|
|
if (indio_dev->pollfunc == NULL) {
|
|
ret = -ENOMEM;
|
|
goto error_kfifo_free;
|
|
}
|
|
|
|
/* Ring buffer functions - here trigger setup related */
|
|
indio_dev->setup_ops = setup_ops;
|
|
|
|
/* Flag that polled ring buffering is possible */
|
|
indio_dev->modes |= INDIO_BUFFER_TRIGGERED;
|
|
|
|
buffer->attrs = buffer_attrs;
|
|
|
|
return 0;
|
|
|
|
error_kfifo_free:
|
|
iio_kfifo_free(indio_dev->buffer);
|
|
error_ret:
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(iio_triggered_buffer_setup_ext);
|
|
|
|
/**
|
|
* iio_triggered_buffer_cleanup() - Free resources allocated by iio_triggered_buffer_setup_ext()
|
|
* @indio_dev: IIO device structure
|
|
*/
|
|
void iio_triggered_buffer_cleanup(struct iio_dev *indio_dev)
|
|
{
|
|
iio_dealloc_pollfunc(indio_dev->pollfunc);
|
|
iio_kfifo_free(indio_dev->buffer);
|
|
}
|
|
EXPORT_SYMBOL(iio_triggered_buffer_cleanup);
|
|
|
|
static void devm_iio_triggered_buffer_clean(struct device *dev, void *res)
|
|
{
|
|
iio_triggered_buffer_cleanup(*(struct iio_dev **)res);
|
|
}
|
|
|
|
int devm_iio_triggered_buffer_setup_ext(struct device *dev,
|
|
struct iio_dev *indio_dev,
|
|
irqreturn_t (*h)(int irq, void *p),
|
|
irqreturn_t (*thread)(int irq, void *p),
|
|
const struct iio_buffer_setup_ops *ops,
|
|
const struct attribute **buffer_attrs)
|
|
{
|
|
struct iio_dev **ptr;
|
|
int ret;
|
|
|
|
ptr = devres_alloc(devm_iio_triggered_buffer_clean, sizeof(*ptr),
|
|
GFP_KERNEL);
|
|
if (!ptr)
|
|
return -ENOMEM;
|
|
|
|
*ptr = indio_dev;
|
|
|
|
ret = iio_triggered_buffer_setup_ext(indio_dev, h, thread, ops,
|
|
buffer_attrs);
|
|
if (!ret)
|
|
devres_add(dev, ptr);
|
|
else
|
|
devres_free(ptr);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL_GPL(devm_iio_triggered_buffer_setup_ext);
|
|
|
|
MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
|
|
MODULE_DESCRIPTION("IIO helper functions for setting up triggered buffers");
|
|
MODULE_LICENSE("GPL");
|