mirror of
https://github.com/torvalds/linux.git
synced 2024-11-23 04:31:50 +00:00
a105291c90
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Acked-by: Tudor Ambarus <tudor.ambarus@linaro.org> Link: https://lore.kernel.org/linux-mtd/20231008200143.196369-16-u.kleine-koenig@pengutronix.de
140 lines
3.4 KiB
C
140 lines
3.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Map driver for Intel XScale PXA2xx platforms.
|
|
*
|
|
* Author: Nicolas Pitre
|
|
* Copyright: (C) 2001 MontaVista Software Inc.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/types.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/mtd/mtd.h>
|
|
#include <linux/mtd/map.h>
|
|
#include <linux/mtd/partitions.h>
|
|
|
|
#include <asm/io.h>
|
|
#include <asm/mach/flash.h>
|
|
|
|
#define CACHELINESIZE 32
|
|
|
|
static void pxa2xx_map_inval_cache(struct map_info *map, unsigned long from,
|
|
ssize_t len)
|
|
{
|
|
unsigned long start = (unsigned long)map->cached + from;
|
|
unsigned long end = start + len;
|
|
|
|
start &= ~(CACHELINESIZE - 1);
|
|
while (start < end) {
|
|
/* invalidate D cache line */
|
|
asm volatile ("mcr p15, 0, %0, c7, c6, 1" : : "r" (start));
|
|
start += CACHELINESIZE;
|
|
}
|
|
}
|
|
|
|
struct pxa2xx_flash_info {
|
|
struct mtd_info *mtd;
|
|
struct map_info map;
|
|
};
|
|
|
|
static const char * const probes[] = { "RedBoot", "cmdlinepart", NULL };
|
|
|
|
static int pxa2xx_flash_probe(struct platform_device *pdev)
|
|
{
|
|
struct flash_platform_data *flash = dev_get_platdata(&pdev->dev);
|
|
struct pxa2xx_flash_info *info;
|
|
struct resource *res;
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
if (!res)
|
|
return -ENODEV;
|
|
|
|
info = kzalloc(sizeof(struct pxa2xx_flash_info), GFP_KERNEL);
|
|
if (!info)
|
|
return -ENOMEM;
|
|
|
|
info->map.name = flash->name;
|
|
info->map.bankwidth = flash->width;
|
|
info->map.phys = res->start;
|
|
info->map.size = resource_size(res);
|
|
|
|
info->map.virt = ioremap(info->map.phys, info->map.size);
|
|
if (!info->map.virt) {
|
|
printk(KERN_WARNING "Failed to ioremap %s\n",
|
|
info->map.name);
|
|
kfree(info);
|
|
return -ENOMEM;
|
|
}
|
|
info->map.cached = ioremap_cache(info->map.phys, info->map.size);
|
|
if (!info->map.cached)
|
|
printk(KERN_WARNING "Failed to ioremap cached %s\n",
|
|
info->map.name);
|
|
info->map.inval_cache = pxa2xx_map_inval_cache;
|
|
simple_map_init(&info->map);
|
|
|
|
printk(KERN_NOTICE
|
|
"Probing %s at physical address 0x%08lx"
|
|
" (%d-bit bankwidth)\n",
|
|
info->map.name, (unsigned long)info->map.phys,
|
|
info->map.bankwidth * 8);
|
|
|
|
info->mtd = do_map_probe(flash->map_name, &info->map);
|
|
|
|
if (!info->mtd) {
|
|
iounmap((void *)info->map.virt);
|
|
if (info->map.cached)
|
|
iounmap(info->map.cached);
|
|
kfree(info);
|
|
return -EIO;
|
|
}
|
|
info->mtd->dev.parent = &pdev->dev;
|
|
|
|
mtd_device_parse_register(info->mtd, probes, NULL, flash->parts,
|
|
flash->nr_parts);
|
|
|
|
platform_set_drvdata(pdev, info);
|
|
return 0;
|
|
}
|
|
|
|
static void pxa2xx_flash_remove(struct platform_device *dev)
|
|
{
|
|
struct pxa2xx_flash_info *info = platform_get_drvdata(dev);
|
|
|
|
mtd_device_unregister(info->mtd);
|
|
|
|
map_destroy(info->mtd);
|
|
iounmap(info->map.virt);
|
|
if (info->map.cached)
|
|
iounmap(info->map.cached);
|
|
kfree(info);
|
|
}
|
|
|
|
#ifdef CONFIG_PM
|
|
static void pxa2xx_flash_shutdown(struct platform_device *dev)
|
|
{
|
|
struct pxa2xx_flash_info *info = platform_get_drvdata(dev);
|
|
|
|
if (info && mtd_suspend(info->mtd) == 0)
|
|
mtd_resume(info->mtd);
|
|
}
|
|
#else
|
|
#define pxa2xx_flash_shutdown NULL
|
|
#endif
|
|
|
|
static struct platform_driver pxa2xx_flash_driver = {
|
|
.driver = {
|
|
.name = "pxa2xx-flash",
|
|
},
|
|
.probe = pxa2xx_flash_probe,
|
|
.remove_new = pxa2xx_flash_remove,
|
|
.shutdown = pxa2xx_flash_shutdown,
|
|
};
|
|
|
|
module_platform_driver(pxa2xx_flash_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Nicolas Pitre <nico@fluxnic.net>");
|
|
MODULE_DESCRIPTION("MTD map driver for Intel XScale PXA2xx");
|