mirror of
https://github.com/torvalds/linux.git
synced 2024-12-22 19:01:37 +00:00
9b174527e7
In the media drivers, the v4l2 core knows about all submodules and calls into them from a common function. However this cannot work if the modules that get called are loadable and the core is built-in. In that case we get drivers/built-in.o: In function `set_type': drivers/media/v4l2-core/tuner-core.c:301: undefined reference to `tea5767_attach' drivers/media/v4l2-core/tuner-core.c:307: undefined reference to `tea5761_attach' drivers/media/v4l2-core/tuner-core.c:349: undefined reference to `tda9887_attach' drivers/media/v4l2-core/tuner-core.c:405: undefined reference to `xc4000_attach' This was working previously, until the IS_ENABLED() macro was used to replace the construct like #if defined(CONFIG_DVB_CX24110) || (defined(CONFIG_DVB_CX24110_MODULE) && defined(MODULE)) with the difference that the new code no longer checks whether it is being built as a loadable module itself. To fix this, this new patch adds an 'IS_REACHABLE' macro, which evaluates true in exactly the condition that was used previously. The downside of this is that this trades an obvious link error for a more subtle runtime failure, but it is clear that the change that introduced the link error was unintentional and it seems better to revert it for now. Also, a similar change was originally created by Trent Piepho and then reverted by teh change to the IS_ENABLED macro. Ideally Kconfig would be used to avoid the case of a broken dependency, or the code restructured in a way to turn around the dependency, but either way would require much larger changes here. Fixes:7b34be71db("[media] use IS_ENABLED() macro") See-also:c5dec9fb24("V4L/DVB (4751): Fix DBV_FE_CUSTOMISE for card drivers compiled into kernel") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
67 lines
2.0 KiB
C
67 lines
2.0 KiB
C
#ifndef _DRXK_H_
|
|
#define _DRXK_H_
|
|
|
|
#include <linux/kconfig.h>
|
|
#include <linux/types.h>
|
|
#include <linux/i2c.h>
|
|
|
|
/**
|
|
* struct drxk_config - Configure the initial parameters for DRX-K
|
|
*
|
|
* @adr: I2C address of the DRX-K
|
|
* @parallel_ts: True means that the device uses parallel TS,
|
|
* Serial otherwise.
|
|
* @dynamic_clk: True means that the clock will be dynamically
|
|
* adjusted. Static clock otherwise.
|
|
* @enable_merr_cfg: Enable SIO_PDR_PERR_CFG/SIO_PDR_MVAL_CFG.
|
|
* @single_master: Device is on the single master mode
|
|
* @no_i2c_bridge: Don't switch the I2C bridge to talk with tuner
|
|
* @antenna_gpio: GPIO bit used to control the antenna
|
|
* @antenna_dvbt: GPIO bit for changing antenna to DVB-C. A value of 1
|
|
* means that 1=DVBC, 0 = DVBT. Zero means the opposite.
|
|
* @mpeg_out_clk_strength: DRXK Mpeg output clock drive strength.
|
|
* @microcode_name: Name of the firmware file with the microcode
|
|
* @qam_demod_parameter_count: The number of parameters used for the command
|
|
* to set the demodulator parameters. All
|
|
* firmwares are using the 2-parameter commmand.
|
|
* An exception is the "drxk_a3.mc" firmware,
|
|
* which uses the 4-parameter command.
|
|
* A value of 0 (default) or lower indicates that
|
|
* the correct number of parameters will be
|
|
* automatically detected.
|
|
*
|
|
* On the *_gpio vars, bit 0 is UIO-1, bit 1 is UIO-2 and bit 2 is
|
|
* UIO-3.
|
|
*/
|
|
struct drxk_config {
|
|
u8 adr;
|
|
bool single_master;
|
|
bool no_i2c_bridge;
|
|
bool parallel_ts;
|
|
bool dynamic_clk;
|
|
bool enable_merr_cfg;
|
|
|
|
bool antenna_dvbt;
|
|
u16 antenna_gpio;
|
|
|
|
u8 mpeg_out_clk_strength;
|
|
int chunk_size;
|
|
|
|
const char *microcode_name;
|
|
int qam_demod_parameter_count;
|
|
};
|
|
|
|
#if IS_REACHABLE(CONFIG_DVB_DRXK)
|
|
extern struct dvb_frontend *drxk_attach(const struct drxk_config *config,
|
|
struct i2c_adapter *i2c);
|
|
#else
|
|
static inline struct dvb_frontend *drxk_attach(const struct drxk_config *config,
|
|
struct i2c_adapter *i2c)
|
|
{
|
|
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
|
|
return NULL;
|
|
}
|
|
#endif
|
|
|
|
#endif
|