Jason A. Donenfeld d2a02e3c8b lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI ... blake2s_compress_generic is weakly aliased by blake2s_compress. The current harness for function selection uses a function pointer, which is ordinarily inlined and resolved at compile time. But when Clang's CFI is enabled, CFI still triggers when making an indirect call via a weak symbol. This seems like a bug in Clang's CFI, as though it's bucketing weak symbols and strong symbols differently. It also only seems to trigger when "full LTO" mode is used, rather than "thin LTO". [ 0.000000][ T0] Kernel panic - not syncing: CFI failure (target: blake2s_compress_generic+0x0/0x1444) [ 0.000000][ T0] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.16.0-mainline-06981-g076c855b846e #1 [ 0.000000][ T0] Hardware name: MT6873 (DT) [ 0.000000][ T0] Call trace: [ 0.000000][ T0] dump_backtrace+0xfc/0x1dc [ 0.000000][ T0] dump_stack_lvl+0xa8/0x11c [ 0.000000][ T0] panic+0x194/0x464 [ 0.000000][ T0] __cfi_check_fail+0x54/0x58 [ 0.000000][ T0] __cfi_slowpath_diag+0x354/0x4b0 [ 0.000000][ T0] blake2s_update+0x14c/0x178 [ 0.000000][ T0] _extract_entropy+0xf4/0x29c [ 0.000000][ T0] crng_initialize_primary+0x24/0x94 [ 0.000000][ T0] rand_initialize+0x2c/0x6c [ 0.000000][ T0] start_kernel+0x2f8/0x65c [ 0.000000][ T0] __primary_switched+0xc4/0x7be4 [ 0.000000][ T0] Rebooting in 5 seconds.. Nonetheless, the function pointer method isn't so terrific anyway, so this patch replaces it with a simple boolean, which also gets inlined away. This successfully works around the Clang bug. In general, I'm not too keen on all of the indirection involved here; it clearly does more harm than good. Hopefully the whole thing can get cleaned up down the road when lib/crypto is overhauled more comprehensively. But for now, we go with a simple bandaid. Fixes: 6048fdcc5f ("lib/crypto: blake2s: include as built-in") Link: https://github.com/ClangBuiltLinux/linux/issues/1567 Reported-by: Miles Chen <miles.chen@mediatek.com> Tested-by: Miles Chen <miles.chen@mediatek.com> Tested-by: Nathan Chancellor <nathan@kernel.org> Tested-by: John Stultz <john.stultz@linaro.org> Acked-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>		2022-02-04 19:22:32 +01:00
..
842
crypto	lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI	2022-02-04 19:22:32 +01:00
dim
fonts	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
kunit	Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2022-01-17 05:49:30 +02:00
livepatch
lz4	include/linux/unaligned: replace kernel.h with the necessary inclusions	2022-01-20 08:52:53 +02:00
lzo
math	math: make RATIONAL tristate	2021-09-08 11:50:26 -07:00
mpi	lib/mpi: Add the return value check of kcalloc()	2022-01-07 14:30:01 +11:00
pldmfw	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
raid6	lib/raid6: Use strict priority ranking for pq gen() benchmarking	2022-01-06 08:37:03 -08:00
reed_solomon	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
test_fortify	fortify: Add compile-time FORTIFY_SOURCE tests	2021-10-18 12:28:52 -07:00
vdso	lib/vdso: Add vdso_data pointer as input to __arch_get_timens_vdso_data()	2021-04-14 23:04:44 +10:00
xz	lib/xz, lib/decompress_unxz.c: Fix spelling in comments	2021-10-19 23:44:30 +08:00
zlib_deflate
zlib_dfltcc
zlib_inflate	lib/zlib_inflate/inffast: check config in C to avoid unused function warning	2021-09-24 16:13:35 -07:00
zstd	lib: zstd: Don't add -O3 to cflags	2021-11-18 13:16:22 -08:00
.gitignore	fortify: Add compile-time FORTIFY_SOURCE tests	2021-10-18 12:28:52 -07:00
argv_split.c
ashldi3.c
ashrdi3.c
asn1_decoder.c
asn1_encoder.c	lib: remove redundant assignment to variable ret	2022-01-20 08:52:55 +02:00
assoc_array.c	assoc_array: Avoid open coded arithmetic in allocator arguments	2021-10-13 14:54:13 -05:00
atomic64_test.c
atomic64.c	locking/atomic: atomic64: Remove unusable atomic ops	2021-12-13 10:56:09 +01:00
audit.c	audit: add support for the openat2 syscall	2021-10-01 16:52:48 -04:00
bcd.c
bch.c	lib/bch.c: fix a typo in the file bch.c	2021-05-06 19:24:12 -07:00
bitfield_kunit.c
bitmap.c	lib: bitmap: Introduce node-aware alloc API	2021-10-26 19:30:38 -07:00
bitrev.c
bootconfig.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
bsearch.c
btree.c
bucket_locks.c
bug.c	bug: Assign values once in bug_get_file_line()	2021-04-01 09:54:37 +01:00
build_OID_registry
buildid.c	kdump: use vmlinux_build_id to simplify	2021-07-08 11:48:22 -07:00
bust_spinlocks.c
check_signature.c
checksum.c
clz_ctz.c
clz_tab.c
cmdline_kunit.c	lib/cmdline_kunit: Remove a cast which are no-longer required	2021-06-23 16:41:41 -06:00
cmdline.c	lib/cmdline: Export next_arg() for being used in modules	2021-05-05 16:07:40 +02:00
cmpdi2.c
compat_audit.c	audit: add support for the openat2 syscall	2021-10-01 16:52:48 -04:00
cpu_rmap.c
cpumask.c	memblock: use memblock_free for freeing virtual pointers	2021-11-06 13:30:41 -07:00
crc4.c
crc7.c
crc8.c	lib: crc8: pointer to data block should be const	2021-05-06 19:24:12 -07:00
crc16.c
crc32.c
crc32defs.h
crc32test.c
crc64.c	lib: crc64: fix kernel-doc warning	2021-06-05 08:58:12 -07:00
crc-ccitt.c
crc-itu-t.c
crc-t10dif.c
ctype.c
debug_info.c	isystem: ship and use stdarg.h	2021-08-19 09:02:55 +09:00
debug_locks.c	locking/lockdep: Improve noinstr vs errors	2021-06-22 13:56:43 +02:00
debugobjects.c	debugobjects: Make them PREEMPT_RT aware	2021-08-13 10:07:44 +02:00
dec_and_lock.c
decompress_bunzip2.c	lib/decompressors: fix spelling mistakes	2021-07-01 11:06:05 -07:00
decompress_inflate.c
decompress_unlz4.c	lib/decompress_unlz4.c: correctly handle zero-padding around initrds.	2021-07-01 11:06:06 -07:00
decompress_unlzma.c	lib: fix inconsistent indenting in process_bit1()	2021-05-06 19:24:12 -07:00
decompress_unlzo.c	lib/decompressors: remove set but not used variabled 'level'	2021-07-01 11:06:06 -07:00
decompress_unxz.c	lib/xz, lib/decompress_unxz.c: Fix spelling in comments	2021-10-19 23:44:30 +08:00
decompress_unzstd.c	lib: zstd: Add decompress_sources.h for decompress_unzstd	2021-11-08 16:55:26 -08:00
decompress.c
devmem_is_allowed.c	lib: use PFN_PHYS() in devmem_is_allowed()	2021-08-13 14:09:32 -10:00
devres.c	lib: devres: Add managed arch_io_reserve_memtype_wc()	2021-09-23 09:25:59 +02:00
digsig.c
dump_stack.c	lib/dump_stack: correct kernel-doc notation	2021-09-08 11:50:26 -07:00
dynamic_debug.c	dyndbg: refine verbosity 1-4 summary-detail	2021-10-21 13:01:25 +02:00
dynamic_queue_limits.c
earlycpio.c	lib: remove "expecting prototype" kernel-doc warnings	2021-04-16 16:10:37 -07:00
errname.c
error-inject.c	kprobes: treewide: Replace arch_deref_entry_point() with dereference_symbol_descriptor()	2021-09-30 21:24:06 -04:00
errseq.c
extable.c
fault-inject-usercopy.c
fault-inject.c
fdt_addresses.c
fdt_empty_tree.c
fdt_ro.c
fdt_rw.c
fdt_strerror.c
fdt_sw.c
fdt_wip.c
fdt.c
find_bit_benchmark.c	lib: add find_first_and_bit()	2022-01-15 08:47:31 -08:00
find_bit.c	lib: add find_first_and_bit()	2022-01-15 08:47:31 -08:00
flex_proportions.c	flex_proportions: Allow N events instead of 1	2021-10-18 07:49:39 -04:00
gen_crc32table.c
gen_crc64table.c
genalloc.c	all: replace find_next{,_zero}_bit with find_first{,_zero}_bit where appropriate	2022-01-15 08:47:31 -08:00
generic-radix-tree.c
glob.c
globtest.c
hexdump.c
hweight.c
idr.c
inflate.c
interval_tree_test.c
interval_tree.c
iomap_copy.c
iomap.c
iommu-helper.c
iov_iter.c	iov_iter: Convert iter_xarray to use folios	2022-01-04 13:15:33 -05:00
irq_poll.c
irq_regs.c
is_single_threaded.c
kasprintf.c	isystem: ship and use stdarg.h	2021-08-19 09:02:55 +09:00
Kconfig	bitmap patches for 5.17-rc1	2022-01-23 06:20:44 +02:00
Kconfig.debug	Merge branch 'akpm' (patches from Andrew)	2022-01-20 10:41:01 +02:00
Kconfig.kasan	lib/stackdepot: allow optional init and stack_table allocation by kvmalloc()	2022-01-22 08:33:37 +02:00
Kconfig.kcsan	kcsan: Support WEAK_MEMORY with Clang where no objtool support exists	2021-12-09 16:42:28 -08:00
Kconfig.kfence	kfence: default to dynamic branch instead of static keys mode	2021-11-06 13:30:43 -07:00
Kconfig.kgdb
Kconfig.ubsan	ubsan: remove CONFIG_UBSAN_OBJECT_SIZE	2022-01-20 08:52:55 +02:00
kfifo.c	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
klist.c
kobject_uevent.c	kobject: remove kset from struct kset_uevent_ops callbacks	2021-12-28 11:26:18 +01:00
kobject.c	driver core: make kobj_type constant.	2021-12-27 10:40:00 +01:00
kstrtox.c	kstrtox: uninline everything	2022-01-20 08:52:53 +02:00
kstrtox.h	lib: vsprintf: Fix handling of number field widths in vsscanf	2021-05-19 15:05:11 +02:00
libcrc32c.c
linear_ranges.c	lib: add linear range get selector within	2021-08-13 18:37:38 +02:00
list_debug.c	lib/list_debug.c: print more list debugging context in __list_del_entry_valid()	2022-01-20 08:52:53 +02:00
list_sort.c	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
list-test.c
llist.c
locking-selftest-hardirq.h
locking-selftest-mutex.h
locking-selftest-rlock-hardirq.h
locking-selftest-rlock-softirq.h
locking-selftest-rlock.h
locking-selftest-rsem.h
locking-selftest-rtmutex.h
locking-selftest-softirq.h
locking-selftest-spin-hardirq.h
locking-selftest-spin-softirq.h
locking-selftest-spin.h
locking-selftest-wlock-hardirq.h
locking-selftest-wlock-softirq.h
locking-selftest-wlock.h
locking-selftest-wsem.h
locking-selftest.c	lockdep/selftests: Adapt ww-tests for PREEMPT_RT	2021-12-04 10:56:24 +01:00
lockref.c
logic_iomem.c	logic_io instance of iounmap() needs volatile on argument	2021-12-21 21:31:08 +01:00
logic_pio.c	PCI: Fix pci_register_io_range() memory leak	2021-02-17 17:31:06 -06:00
lru_cache.c	lib: remove "expecting prototype" kernel-doc warnings	2021-04-16 16:10:37 -07:00
lshrdi3.c
Makefile	Merge branch 'akpm' (patches from Andrew)	2022-01-20 10:41:01 +02:00
memcat_p.c
memcpy_kunit.c	string.h: Introduce memset_startat() for wiping trailing members and padding	2021-10-18 12:28:52 -07:00
memory-notifier-error-inject.c
memregion.c
memweight.c
muldi3.c
net_utils.c
netdev-notifier-error-inject.c
nlattr.c	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
nmi_backtrace.c	printk: restore flushing of NMI buffers on remote CPUs after NMI backtraces	2021-11-10 16:12:00 +01:00
nodemask.c
notifier-error-inject.c
notifier-error-inject.h
objagg.c	lib: objagg: Use the bitmap API when applicable	2021-12-24 14:54:29 -08:00
of-reconfig-notifier-error-inject.c
oid_registry.c	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
once.c	once: Fix panic when module unload	2021-08-08 13:00:20 +01:00
packing.c	net: update NXP copyright text	2021-09-17 13:52:17 +01:00
parman.c	lib: remove "expecting prototype" kernel-doc warnings	2021-04-16 16:10:37 -07:00
parser.c	kernel.h: split out kstrtox() and simple_strtox() to a separate header	2021-07-01 11:06:05 -07:00
pci_iomap.c	pci_iounmap'2: Electric Boogaloo: try to make sense of it all	2021-09-19 17:13:35 -07:00
percpu_counter.c	lib/percpu_counter: tame kernel-doc compile warning	2021-05-06 19:24:12 -07:00
percpu_test.c
percpu-refcount.c	percpu_ref: Don't opencode percpu_ref_is_dying	2021-05-13 03:27:38 +00:00
plist.c
pm-notifier-error-inject.c
radix-tree.c	lib: remove "expecting prototype" kernel-doc warnings	2021-04-16 16:10:37 -07:00
random32.c	mm: don't include <linux/blk-cgroup.h> in <linux/writeback.h>	2021-10-18 06:17:01 -06:00
ratelimit.c
rbtree_test.c
rbtree.c
ref_tracker.c	ref_tracker: use __GFP_NOFAIL more carefully	2022-01-12 14:29:50 +00:00
refcount.c	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
rhashtable.c	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
sbitmap.c	blk-mq: Fix wrong wakeup batch configuration which will cause hang	2022-01-27 10:15:32 -07:00
scatterlist.c	mm/scatterlist: replace the !preemptible warning in sg_miter_stop()	2021-11-09 10:02:50 -08:00
seq_buf.c	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
sg_pool.c	lib/scatterlist: Fix wrong update of orig_nents	2021-08-24 19:52:40 -03:00
sg_split.c
sha1.c	lib/crypto: sha1: re-roll loops to reduce code size	2022-01-18 13:03:55 +01:00
show_mem.c
siphash.c	siphash: use _unaligned version by default	2021-11-29 19:50:50 -08:00
slub_kunit.c	mm/slub, kunit: add a KUnit test for SLUB debugging functionality	2021-06-29 10:53:46 -07:00
smp_processor_id.c	lib/smp_processor_id: Use is_percpu_thread() instead of nr_cpus_allowed	2021-05-19 10:51:40 +02:00
sort.c	lib: fix spelling mistakes	2021-07-08 11:48:20 -07:00
stackdepot.c	lib/stackdepot: always do filter_irq_stacks() in stack_depot_save()	2022-01-22 08:33:38 +02:00
stmp_device.c
string_helpers.c	lib/string_helpers: Introduce managed variant of kasprintf_strarray()	2021-11-18 18:40:08 +02:00
string.c	lib/string: Move helper functions out of string.c	2021-09-25 08:20:49 -07:00
strncpy_from_user.c
strnlen_user.c
syscall.c	sched: Change task_struct::state	2021-06-18 11:43:09 +02:00
test_bitmap.c	lib: bitmap: add performance test for bitmap_print_to_pagebuf	2022-01-15 08:47:31 -08:00
test_bitops.c	lib/test: fix spelling mistakes	2021-07-08 11:48:20 -07:00
test_bits.c
test_blackhole_dev.c
test_bpf.c	bpf: Change value of MAX_TAIL_CALL_CNT from 32 to 33	2021-11-16 14:03:15 +01:00
test_debug_virtual.c
test_firmware.c	firmware: replace HOTPLUG with UEVENT in FW_ACTION defines	2021-05-13 16:14:45 +02:00
test_fpu.c
test_free_pages.c
test_hash.c	test_hash.c: refactor into kunit	2022-01-20 08:52:54 +02:00
test_hexdump.c
test_hmm_uapi.h	mm: selftests for exclusive device memory	2021-07-01 11:06:03 -07:00
test_hmm.c	mm/hmm.c: allow VM_MIXEDMAP to work with hmm_range_fault	2022-01-15 16:30:31 +02:00
test_ida.c
test_kasan_module.c	kasan: test: bypass __alloc_size checks	2021-11-06 13:30:33 -07:00
test_kasan.c	kasan: test: fix compatibility with FORTIFY_SOURCE	2022-01-30 09:56:58 +02:00
test_kmod.c	lib/test: fix spelling mistakes	2021-07-08 11:48:20 -07:00
test_kprobes.c	test_kprobes: Move it from kernel/ to lib/	2021-10-26 17:23:46 -04:00
test_linear_ranges.c
test_list_sort.c	lib/test: convert lib/test_list_sort.c to use KUnit	2021-06-25 11:31:03 -06:00
test_lockup.c	lib/test_lockup: Adapt to changed variables	2021-08-17 19:05:33 +02:00
test_memcat_p.c
test_meminit.c	lib/test_meminit: destroy cache in kmem_cache_alloc_bulk() test	2022-01-20 08:52:54 +02:00
test_min_heap.c
test_module.c
test_objagg.c
test_overflow.c
test_parman.c
test_printf.c	vsprintf: Make %pGp print the hex value	2021-10-27 13:40:14 +02:00
test_ref_tracker.c	lib: add tests for reference tracker	2021-12-06 16:04:44 -08:00
test_rhashtable.c	rhashtable: avoid -Wrestrict warning on overlapping sprintf output	2021-03-24 15:16:09 -07:00
test_scanf.c	lib/test_scanf: split up number parsing test routines	2021-09-06 11:04:03 -07:00
test_siphash.c
test_sort.c	lib/test: convert test_sort.c to use KUnit	2021-09-08 11:50:26 -07:00
test_stackinit.c	lib/test_stackinit: Add assigned initializers	2021-08-22 00:21:36 -07:00
test_static_key_base.c
test_static_keys.c
test_string.c	lib/test_string.c: allow module removal	2021-07-01 11:06:05 -07:00
test_strscpy.c
test_sysctl.c	test_sysctl: simplify subdirectory registration with register_sysctl()	2022-01-22 08:33:35 +02:00
test_ubsan.c	ubsan: remove CONFIG_UBSAN_OBJECT_SIZE	2022-01-20 08:52:55 +02:00
test_user_copy.c
test_uuid.c
test_vmalloc.c	lib/test_vmalloc.c: use swap() to make code cleaner	2021-11-06 13:30:37 -07:00
test_xarray.c	XArray: Fix splitting to non-zero orders	2021-03-30 13:42:33 -04:00
test-kstrtox.c
test-string_helpers.c	string_helpers: Escape double quotes in escape_special	2021-07-19 11:39:28 +02:00
textsearch.c
timerqueue.c	rbtree, timerqueue: Use rb_add_cached()	2021-02-17 14:08:01 +01:00
ts_bm.c
ts_fsm.c
ts_kmp.c
ubsan.c	kunit: ubsan integration	2021-08-13 13:19:06 -06:00
ubsan.h	ubsan: implement __ubsan_handle_alignment_assumption	2021-02-05 11:03:47 -08:00
ucmpdi2.c
ucs2_string.c
usercopy.c
uuid.c
vsprintf.c	bitmap patches for 5.17-rc1	2022-01-23 06:20:44 +02:00
win_minmax.c
xarray.c	XArray: Add xas_advance()	2022-01-08 00:28:41 -05:00
xxhash.c