linux/drivers/staging/octeon-usb
Gustavo A. R. Silva 5979afa2c4 staging: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20200220132908.GA30501@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-02-23 19:18:54 +01:00
..
Kconfig Revert "staging: octeon-usb: delete the octeon usb host controller driver" 2020-02-12 13:50:32 -08:00
Makefile Revert "staging: octeon-usb: delete the octeon usb host controller driver" 2020-02-12 13:50:32 -08:00
octeon-hcd.c staging: Replace zero-length array with flexible-array member 2020-02-23 19:18:54 +01:00
octeon-hcd.h Revert "staging: octeon-usb: delete the octeon usb host controller driver" 2020-02-12 13:50:32 -08:00
TODO Revert "staging: octeon-usb: delete the octeon usb host controller driver" 2020-02-12 13:50:32 -08:00