Chuck Lever 11476e9dec NFS: Fix an LOCK/OPEN race when unlinking an open file ... At Connectathon 2016, we found that recent upstream Linux clients would occasionally send a LOCK operation with a zero stateid. This appeared to happen in close proximity to another thread returning a delegation before unlinking the same file while it remained open. Earlier, the client received a write delegation on this file and returned the open stateid. Now, as it is getting ready to unlink the file, it returns the write delegation. But there is still an open file descriptor on that file, so the client must OPEN the file again before it returns the delegation. Since commit 24311f8841 ('NFSv4: Recovery of recalled read delegations is broken'), nfs_open_delegation_recall() clears the NFS_DELEGATED_STATE flag _before_ it sends the OPEN. This allows a racing LOCK on the same inode to be put on the wire before the OPEN operation has returned a valid open stateid. To eliminate this race, serialize delegation return with the acquisition of a file lock on the same file. Adopt the same approach as is used in the unlock path. This patch also eliminates a similar race seen when sending a LOCK operation at the same time as returning a delegation on the same file. Fixes: 24311f8841 ('NFSv4: Recovery of recalled read ... ') Signed-off-by: Chuck Lever <chuck.lever@oracle.com> [Anna: Add sentence about LOCK / delegation race] Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>		2016-05-09 09:05:40 -04:00
..
9p	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
adfs
affs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
afs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
autofs4	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-03-19 18:52:29 -07:00
befs
bfs
btrfs	Merge branch 'for-linus-4.6' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs	2016-04-09 10:41:34 -07:00
cachefiles	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
ceph	libceph: make authorizer destruction independent of ceph_auth_client	2016-04-25 20:54:13 +02:00
cifs	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
coda
configfs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
cramfs	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
crypto	ext4/fscrypto: avoid RCU lookup in d_revalidate	2016-04-12 20:01:35 -07:00
debugfs	debugfs: Make automount point inodes permanently empty	2016-04-12 15:01:53 -07:00
devpts	devpts: more pty driver interface cleanups	2016-04-26 15:47:32 -07:00
dlm	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
ecryptfs	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
efivarfs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
efs
exofs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
exportfs
ext2	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
ext4	ext4/fscrypto: avoid RCU lookup in d_revalidate	2016-04-12 20:01:35 -07:00
f2fs	fscrypto: don't let data integrity writebacks fail with ENOMEM	2016-04-12 10:25:30 -07:00
fat	fat: add config option to set UTF-8 mount option by default	2016-03-22 15:36:02 -07:00
freevxfs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
fscache	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
fuse	fuse: Fix return value from fuse_get_user_pages()	2016-04-25 13:01:04 +02:00
gfs2	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
hfs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
hfsplus	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
hostfs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
hpfs	hpfs: don't truncate the file when delete fails	2016-02-27 19:15:51 -05:00
hugetlbfs	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
isofs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
jbd2	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
jffs2	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
jfs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
kernfs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
lockd
logfs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
minix	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
ncpfs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
nfs	NFS: Fix an LOCK/OPEN race when unlinking an open file	2016-05-09 09:05:40 -04:00
nfs_common
nfsd	Various bugfixes, a RDMA update from Chuck Lever, and support for a new	2016-03-24 19:50:32 -07:00
nilfs2	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
nls
notify
ntfs	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
ocfs2	ocfs2/dlm: return zero if deref_done message is successfully handled	2016-04-28 19:34:04 -07:00
omfs
openpromfs
orangefs	Orangefs: cleanups and a strncpy vulnerability fix.	2016-04-09 10:33:58 -07:00
overlayfs	fs: add file_dentry()	2016-03-26 16:14:37 -04:00
proc	proc: prevent accessing /proc/<PID>/environ until it's ready	2016-05-05 17:38:53 -07:00
pstore	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
qnx4
qnx6	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
quota	quota: Handle Q_GETNEXTQUOTA when quota is disabled	2016-03-29 17:20:10 +02:00
ramfs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
reiserfs	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
romfs
squashfs	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
sysfs
sysv	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
tracefs
ubifs	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
udf	udf: Fix conversion of 'dstring' fields to UTF8	2016-04-25 15:18:50 +02:00
ufs	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
xfs	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
aio.c
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c
binfmt_elf_fdpic.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
binfmt_elf.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c
binfmt_script.c
block_dev.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
buffer.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
char_dev.c
compat_binfmt_elf.c
compat_ioctl.c
compat.c
coredump.c	fs/coredump: prevent fsuid=0 dumps into user-controlled directories	2016-03-22 15:36:02 -07:00
dax.c	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
dcache.c	fs: add file_dentry()	2016-03-26 16:14:37 -04:00
dcookies.c
direct-io.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
drop_caches.c
eventfd.c	eventfd: document lockless access in eventfd_poll	2016-03-22 15:36:02 -07:00
eventpoll.c	timer: convert timer_slack_ns from unsigned long to u64	2016-03-17 15:09:34 -07:00
exec.c	Merge branch 'mm-pkeys-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2016-03-20 19:08:56 -07:00
fcntl.c
fhandle.c	fs/coredump: prevent fsuid=0 dumps into user-controlled directories	2016-03-22 15:36:02 -07:00
file_table.c
file.c
filesystems.c
fs_pin.c
fs_struct.c
fs-writeback.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
inode.c
internal.h
ioctl.c
Kconfig	Merge tag 'ofs-pull-tag-1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux	2016-03-26 12:59:04 -07:00
Kconfig.binfmt
libfs.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
locks.c
Makefile	Merge tag 'ofs-pull-tag-1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux	2016-03-26 12:59:04 -07:00
mbcache.c	mbcache: add reusable flag to cache entries	2016-02-22 22:44:04 -05:00
mount.h
mpage.c	mm, fs: remove remaining PAGE_CACHE_* and page_cache_{get,release} usage	2016-04-04 10:41:08 -07:00
namei.c	fix the braino in "namei: massage lookup_slow() to be usable by lookup_one_len_unlocked()"	2016-03-31 00:23:05 -04:00
namespace.c
no-block.c
nsfs.c
open.c	fs/coredump: prevent fsuid=0 dumps into user-controlled directories	2016-03-22 15:36:02 -07:00
pipe.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
pnode.c	propogate_mnt: Handle the first propogated copy being a slave	2016-05-05 09:54:45 -05:00
pnode.h
posix_acl.c
proc_namespace.c	vfs: show_vfsstat: do not ignore errors from show_devname method	2016-03-16 13:09:08 -04:00
read_write.c	Merge branches 'work.lookups', 'work.misc' and 'work.preadv2' into for-next	2016-03-18 16:07:38 -04:00
readdir.c
select.c	timer: convert timer_slack_ns from unsigned long to u64	2016-03-17 15:09:34 -07:00
seq_file.c	Make file credentials available to the seqfile interfaces	2016-04-14 12:56:09 -07:00
signalfd.c
splice.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
stack.c
stat.c
statfs.c
super.c	writeback: flush inode cgroup wb switches instead of pinning super_block	2016-03-03 14:42:50 -07:00
sync.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
timerfd.c
userfaultfd.c	userfaultfd: don't block on the last VM updates at exit time	2016-03-02 09:03:18 -08:00
utimes.c
xattr.c