Adam Vodopjan 37e14e4f37 ata: ahci: Fix PCS quirk application for suspend ... Since kernel 5.3.4 my laptop (ICH8M controller) does not see Kingston SV300S37A60G SSD disk connected into a SATA connector on wake from suspend. The problem was introduced in c312ef1763 ("libata/ahci: Drop PCS quirk for Denverton and beyond"): the quirk is not applied on wake from suspend as it originally was. It is worth to mention the commit contained another bug: the quirk is not applied at all to controllers which require it. The fix commit 09d6ac8dc5 ("libata/ahci: Fix PCS quirk application") landed in 5.3.8. So testing my patch anywhere between commits c312ef1763 and 09d6ac8dc5 is pointless. Not all disks trigger the problem. For example nothing bad happens with Western Digital WD5000LPCX HDD. Test hardware: - Acer 5920G with ICH8M SATA controller - sda: some SATA HDD connnected into the DVD drive IDE port with a SATA-IDE caddy. It is a boot disk - sdb: Kingston SV300S37A60G SSD connected into the only SATA port Sample "dmesg --notime | grep -E '^(sd |ata)'" output on wake: sd 0:0:0:0: [sda] Starting disk sd 2:0:0:0: [sdb] Starting disk ata4: SATA link down (SStatus 4 SControl 300) ata3: SATA link down (SStatus 4 SControl 300) ata1.00: ACPI cmd ef/03:0c:00:00:00:a0 (SET FEATURES) filtered out ata1.00: ACPI cmd ef/03:42:00:00:00:a0 (SET FEATURES) filtered out ata1: FORCE: cable set to 80c ata5: SATA link down (SStatus 0 SControl 300) ata3: SATA link down (SStatus 4 SControl 300) ata3: SATA link down (SStatus 4 SControl 300) ata3.00: disabled sd 2:0:0:0: rejecting I/O to offline device ata3.00: detaching (SCSI 2:0:0:0) sd 2:0:0:0: [sdb] Start/Stop Unit failed: Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK sd 2:0:0:0: [sdb] Synchronizing SCSI cache sd 2:0:0:0: [sdb] Synchronize Cache(10) failed: Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK sd 2:0:0:0: [sdb] Stopping disk sd 2:0:0:0: [sdb] Start/Stop Unit failed: Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK Commit c312ef1763 dropped ahci_pci_reset_controller() which internally calls ahci_reset_controller() and applies the PCS quirk if needed after that. It was called each time a reset was required instead of just ahci_reset_controller(). This patch puts the function back in place. Fixes: c312ef1763 ("libata/ahci: Drop PCS quirk for Denverton and beyond") Signed-off-by: Adam Vodopjan <grozzly@protonmail.com> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>		2022-12-27 11:06:57 +09:00
..
acard-ahci.c	ata: add/use ata_taskfile::{error|status} fields	2022-02-20 09:06:05 +09:00
ahci_brcm.c	ata: ahci_brcm: Fix compilation warning	2022-10-18 08:01:57 +09:00
ahci_ceva.c	ata: Drop commas after OF match table sentinels	2022-03-07 11:49:10 +09:00
ahci_da850.c	ata: libahci_platform: Convert to using devm bulk clocks API	2022-09-17 01:39:22 +09:00
ahci_dm816.c	ata: libahci_platform: Convert to using devm bulk clocks API	2022-09-17 01:39:22 +09:00
ahci_dwc.c	ata: ahci-dwc: Add Baikal-T1 AHCI SATA interface support	2022-09-17 01:40:31 +09:00
ahci_imx.c	ata: ahci_imx: Fix compilation warning	2022-10-18 08:02:14 +09:00
ahci_mtk.c	ata: libahci_platform: Parse ports-implemented property in resources getter	2022-09-17 01:39:30 +09:00
ahci_mvebu.c	Char/Misc and other driver updates for 5.18-rc1	2022-03-28 12:27:35 -07:00
ahci_octeon.c	ata: Drop commas after OF match table sentinels	2022-03-07 11:49:10 +09:00
ahci_platform.c	ata: ahci: Add DWC AHCI SATA controller support	2022-09-17 01:40:15 +09:00
ahci_qoriq.c	ata: ahci_qoriq: Fix compilation warning	2022-10-18 08:02:14 +09:00
ahci_seattle.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235	2019-06-19 17:09:07 +02:00
ahci_st.c	ata: ahci_st: Fix compilation warning	2022-10-17 22:01:57 +09:00
ahci_sunxi.c	ata: Drop commas after OF match table sentinels	2022-03-07 11:49:10 +09:00
ahci_tegra.c	ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present	2021-04-11 20:35:08 -06:00
ahci_xgene.c	ata: ahci_xgene: Fix compilation warning	2022-10-18 08:02:14 +09:00
ahci.c	ata: ahci: Fix PCS quirk application for suspend	2022-12-27 11:06:57 +09:00
ahci.h	ata changes for 6.2	2022-12-13 10:54:19 -08:00
ata_generic.c	ata: ata_generic: Fix misspelling of 'ata_generic_init_one()'	2021-03-30 20:21:26 -06:00
ata_piix.c	ata: libata: make ata_host_suspend() *void*	2022-02-19 11:18:35 +09:00
Kconfig	ata: remove palmchip pata_bk3710 driver	2022-10-21 08:04:39 +09:00
libahci_platform.c	ata: libahci_platform: ahci_platform_find_clk: oops, NULL pointer	2022-12-07 08:36:37 +09:00
libahci.c	ata: make use of ata_port_is_frozen() helper	2022-10-18 13:53:27 +09:00
libata-acpi.c	ata: make use of ata_port_is_frozen() helper	2022-10-18 13:53:27 +09:00
libata-core.c	ata: libata-core: do not retry reading the log on timeout	2022-10-19 13:46:08 +09:00
libata-eh.c	ata: libata: fix commands incorrectly not getting retried during NCQ error	2022-11-19 09:41:52 +09:00
libata-pata-timings.c	ata: separate PATA timings code from libata-core.c	2020-03-26 10:28:19 -06:00
libata-pmp.c	ata: libata: add tracepoints for ATA error handling	2022-01-05 19:33:01 +09:00
libata-sata.c	ata: libata: fix commands incorrectly not getting retried during NCQ error	2022-11-19 09:41:52 +09:00
libata-scsi.c	ata changes for 6.2	2022-12-13 10:54:19 -08:00
libata-sff.c	ata: libata-sff: kill unused ata_sff_busy_sleep()	2022-11-11 17:20:26 +09:00
libata-trace.c	ata: libata-sff: tracepoints for HSM state machine	2022-01-05 19:33:01 +09:00
libata-transport.c	ata: libata-transport: fix error handling in ata_tdev_add()	2022-11-11 17:26:05 +09:00
libata-transport.h
libata-zpodd.c	libata: zpodd: Fix small read overflow in zpodd_get_mech_type()	2019-07-29 16:00:14 -06:00
libata.h	ata: libata: only set sense valid flag if sense data is valid	2022-10-17 11:31:52 +09:00
Makefile	ata: remove palmchip pata_bk3710 driver	2022-10-21 08:04:39 +09:00
pata_acpi.c	ata: make transfer mode masks *unsigned int*	2022-06-17 16:35:02 +09:00
pata_ali.c	ata: make transfer mode masks *unsigned int*	2022-06-17 16:35:02 +09:00
pata_amd.c	ata: make transfer mode masks *unsigned int*	2022-06-17 16:35:02 +09:00
pata_arasan_cf.c	ata: libata: make ata_host_suspend() *void*	2022-02-19 11:18:35 +09:00
pata_artop.c	ata: pata_artop: use *switch* in atp8xx_fixup()	2022-02-19 11:18:42 +09:00
pata_atiixp.c	ata: pata_atiixp: make static read-only arrays const	2022-01-31 09:58:32 +09:00
pata_atp867x.c	ata: pata_atp867x: convert printk() calls	2022-01-05 19:33:02 +09:00
pata_buddha.c	ata/pata_buddha: Probe via modalias instead of initcall	2019-08-23 06:58:50 -06:00
pata_cmd64x.c	ata: pata_cmd64x: convert printk() calls	2022-01-05 19:33:03 +09:00
pata_cmd640.c	ata: pata_cmd640: convert printk() calls	2022-01-05 19:33:02 +09:00
pata_cs5520.c	ata: libata: make ata_host_suspend() *void*	2022-02-19 11:18:35 +09:00
pata_cs5530.c	ata: pata_cs5530: Avoid overwriting initialised field in 'cs5530_sht'	2021-06-16 06:50:25 -06:00
pata_cs5535.c	ata: pata_cs5535: Fix W=1 warnings	2022-06-30 08:21:43 +09:00
pata_cs5536.c	ata: pata_cs5536: convert printk() calls	2022-01-05 19:33:03 +09:00
pata_cypress.c	ata: pata_cypress: convert printk() calls	2022-01-05 19:33:03 +09:00
pata_efar.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
pata_ep93xx.c	ata: pata_ep93xx: use devm_platform_get_and_ioremap_resource()	2022-11-12 10:58:56 +09:00
pata_falcon.c	pata_falcon: Avoid type warnings from sparse	2021-11-29 20:28:13 +09:00
pata_ftide010.c	ata: pata_ftide010: Remove build dependency on OF	2022-10-18 08:05:10 +09:00
pata_gayle.c
pata_hpt3x2n.c	ata: make transfer mode masks *unsigned int*	2022-06-17 16:35:02 +09:00
pata_hpt3x3.c	libata: switch remaining drivers to use dma_set_mask_and_coherent	2019-08-26 13:58:59 -06:00
pata_hpt37x.c	ata: make transfer mode masks *unsigned int*	2022-06-17 16:35:02 +09:00
pata_hpt366.c	ata: make transfer mode masks *unsigned int*	2022-06-17 16:35:02 +09:00
pata_icside.c	ata: Avoid comma separated statements	2021-01-31 08:05:46 -07:00
pata_imx.c	ata: libata: make ata_host_suspend() *void*	2022-02-19 11:18:35 +09:00
pata_isapnp.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
pata_it821x.c	ata: fix read_id() ata port operation interface	2022-01-14 15:17:16 +09:00
pata_it8213.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
pata_ixp4xx_cf.c	ata: Drop commas after OF match table sentinels	2022-03-07 11:49:10 +09:00
pata_jmicron.c	ata: pata_jmicron: Fix incorrectly documented function parameter	2021-03-12 07:28:31 -07:00
pata_legacy.c	ata: pata_legacy: fix pdc20230_set_piomode()	2022-10-31 20:27:27 +09:00
pata_macio.c	ata: pata_macio: Remove unneeded word in comments	2022-09-16 23:24:06 +09:00
pata_marvell.c	ata: pata_marvell: Check the 'bmdma_addr' beforing reading	2022-04-22 08:45:06 +09:00
pata_mpc52xx.c	ata: pata_mpc52xx: Replace NO_IRQ with 0	2022-10-17 11:38:15 +09:00
pata_mpiix.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
pata_netcell.c	ata: fix read_id() ata port operation interface	2022-01-14 15:17:16 +09:00
pata_ninja32.c	libata: switch remaining drivers to use dma_set_mask_and_coherent	2019-08-26 13:58:59 -06:00
pata_ns87410.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18	2019-05-21 11:28:46 +02:00
pata_ns87415.c	ata: add/use ata_taskfile::{error|status} fields	2022-02-20 09:06:05 +09:00
pata_octeon_cf.c	ata: pata_octeon_cf: Fix refcount leak in octeon_cf_probe	2022-06-06 09:52:17 +09:00
pata_of_platform.c	ata: Drop commas after OF match table sentinels	2022-03-07 11:49:10 +09:00
pata_oldpiix.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
pata_opti.c	ata: pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()'	2021-03-30 20:21:26 -06:00
pata_optidma.c	pata_optidma: fix checking of DMA state	2021-10-12 17:46:59 +09:00
pata_palmld.c	ata: palmld: fix return value check in palmld_pata_probe()	2022-10-31 20:28:05 +09:00
pata_pcmcia.c	pata_pcmia: add SanDisk High (>8G) CF card to supported list	2020-01-29 20:54:51 -07:00
pata_pdc202xx_old.c	ata: pata_pdc202xx_old: make static read-only array pio_timing const	2022-01-31 09:58:32 +09:00
pata_pdc2027x.c	ata: make transfer mode masks *unsigned int*	2022-06-17 16:35:02 +09:00
pata_piccolo.c	ata: pata_piccolo: 'ata_tosh_init()' is misnamed in its header	2021-03-30 20:21:25 -06:00
pata_platform.c	ata: pata_platform: Make use of platform_get_mem_or_io()	2022-01-31 09:58:31 +09:00
pata_pxa.c	ata: pata_pxa: Use platform_get_irq() to get the interrupt	2022-03-10 11:17:59 +09:00
pata_radisys.c	pata_radisys: fix checking of DMA state	2021-10-12 17:47:02 +09:00
pata_rb532_cf.c	ata: rb532_cf: remove redundant codes	2021-06-24 18:49:01 -06:00
pata_rdc.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18	2019-05-21 11:28:46 +02:00
pata_rz1000.c	ata: pata_rz1000: convert printk() calls	2022-01-05 19:33:03 +09:00
pata_samsung_cf.c	ata: add/use ata_taskfile::{error|status} fields	2022-02-20 09:06:05 +09:00
pata_sc1200.c	ata: pata_sc1200: sc1200_sht'Avoid overwriting initialised field in '	2021-06-16 06:50:25 -06:00
pata_sch.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 300	2019-06-05 17:37:00 +02:00
pata_serverworks.c	ata: make transfer mode masks *unsigned int*	2022-06-17 16:35:02 +09:00
pata_sil680.c	ata: pata_sil680: fix result type of sil680_sel{dev|reg}()	2022-04-13 12:42:51 +09:00
pata_sis.c	ata: make transfer mode masks *unsigned int*	2022-06-17 16:35:02 +09:00
pata_sl82c105.c	ata: pata_sl82c105: Fix potential doc-rot	2021-03-30 20:21:25 -06:00
pata_triflex.c	ata: libata: make ata_host_suspend() *void*	2022-02-19 11:18:35 +09:00
pata_via.c	ata: make transfer mode masks *unsigned int*	2022-06-17 16:35:02 +09:00
pdc_adma.c	ata: pdc_adma: Drop pointless VPRINTK() calls and remove disabled NCQ debugging	2022-01-05 19:33:01 +09:00
sata_dwc_460ex.c	ata: sata_dwc_460ex: Check !irq instead of irq == NO_IRQ	2022-11-12 11:00:04 +09:00
sata_fsl.c	ata changes for 5.18-rc1	2022-03-23 14:35:59 -07:00
sata_gemini.c	ata: sata_gemini: Remove dependency on OF for compile tests	2022-10-18 08:04:46 +09:00
sata_gemini.h
sata_highbank.c	ata: Drop commas after OF match table sentinels	2022-03-07 11:49:10 +09:00
sata_inic162x.c	ata: add/use ata_taskfile::{error|status} fields	2022-02-20 09:06:05 +09:00
sata_mv.c	ata: sata_mv: Fixes expected number of resources now IRQs are gone	2022-08-03 07:59:12 +09:00
sata_nv.c	ata: make use of ata_port_is_frozen() helper	2022-10-18 13:53:27 +09:00
sata_promise.c	ata: make use of ata_port_is_frozen() helper	2022-10-18 13:53:27 +09:00
sata_promise.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18	2019-05-21 11:28:46 +02:00
sata_qstor.c	ata: sata_qstor: Drop pointless VPRINTK() calls	2022-01-05 19:33:02 +09:00
sata_rcar.c	ata: sata_rcar: Fix compilation warning	2022-10-18 08:01:45 +09:00
sata_sil24.c	ata: libata: add reset tracepoints	2022-01-04 20:00:57 +09:00
sata_sil.c	ata: sata_sil: Drop pointless VPRINTK() calls	2022-01-05 19:33:02 +09:00
sata_sis.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18	2019-05-21 11:28:46 +02:00
sata_svw.c	ata: add/use ata_taskfile::{error|status} fields	2022-02-20 09:06:05 +09:00
sata_sx4.c	ata: make use of ata_port_is_frozen() helper	2022-10-18 13:53:27 +09:00
sata_uli.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18	2019-05-21 11:28:46 +02:00
sata_via.c	libata: switch remaining drivers to use dma_set_mask_and_coherent	2019-08-26 13:58:59 -06:00
sata_vsc.c	ata: add/use ata_taskfile::{error|status} fields	2022-02-20 09:06:05 +09:00
sis.h