mirror of
https://github.com/torvalds/linux.git
synced 2024-11-22 04:02:20 +00:00
78eb4ea25c
const qualify the struct ctl_table argument in the proc_handler function
signatures. This is a prerequisite to moving the static ctl_table
structs into .rodata data which will ensure that proc_handler function
pointers cannot be modified.
This patch has been generated by the following coccinelle script:
```
virtual patch
@r1@
identifier ctl, write, buffer, lenp, ppos;
identifier func !~ "appldata_(timer|interval)_handler|sched_(rt|rr)_handler|rds_tcp_skbuf_handler|proc_sctp_do_(hmac_alg|rto_min|rto_max|udp_port|alpha_beta|auth|probe_interval)";
@@
int func(
- struct ctl_table *ctl
+ const struct ctl_table *ctl
,int write, void *buffer, size_t *lenp, loff_t *ppos);
@r2@
identifier func, ctl, write, buffer, lenp, ppos;
@@
int func(
- struct ctl_table *ctl
+ const struct ctl_table *ctl
,int write, void *buffer, size_t *lenp, loff_t *ppos)
{ ... }
@r3@
identifier func;
@@
int func(
- struct ctl_table *
+ const struct ctl_table *
,int , void *, size_t *, loff_t *);
@r4@
identifier func, ctl;
@@
int func(
- struct ctl_table *ctl
+ const struct ctl_table *ctl
,int , void *, size_t *, loff_t *);
@r5@
identifier func, write, buffer, lenp, ppos;
@@
int func(
- struct ctl_table *
+ const struct ctl_table *
,int write, void *buffer, size_t *lenp, loff_t *ppos);
```
* Code formatting was adjusted in xfs_sysctl.c to comply with code
conventions. The xfs_stats_clear_proc_handler,
xfs_panic_mask_proc_handler and xfs_deprecated_dointvec_minmax where
adjusted.
* The ctl_table argument in proc_watchdog_common was const qualified.
This is called from a proc_handler itself and is calling back into
another proc_handler, making it necessary to change it as part of the
proc_handler migration.
Co-developed-by: Thomas Weißschuh <linux@weissschuh.net>
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Co-developed-by: Joel Granados <j.granados@samsung.com>
Signed-off-by: Joel Granados <j.granados@samsung.com>
225 lines
5.4 KiB
C
225 lines
5.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (c) 2001-2005 Silicon Graphics, Inc.
|
|
* All Rights Reserved.
|
|
*/
|
|
#include "xfs.h"
|
|
#include "xfs_error.h"
|
|
|
|
static struct ctl_table_header *xfs_table_header;
|
|
|
|
#ifdef CONFIG_PROC_FS
|
|
STATIC int
|
|
xfs_stats_clear_proc_handler(
|
|
const struct ctl_table *ctl,
|
|
int write,
|
|
void *buffer,
|
|
size_t *lenp,
|
|
loff_t *ppos)
|
|
{
|
|
int ret, *valp = ctl->data;
|
|
|
|
ret = proc_dointvec_minmax(ctl, write, buffer, lenp, ppos);
|
|
|
|
if (!ret && write && *valp) {
|
|
xfs_stats_clearall(xfsstats.xs_stats);
|
|
xfs_stats_clear = 0;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
STATIC int
|
|
xfs_panic_mask_proc_handler(
|
|
const struct ctl_table *ctl,
|
|
int write,
|
|
void *buffer,
|
|
size_t *lenp,
|
|
loff_t *ppos)
|
|
{
|
|
int ret, *valp = ctl->data;
|
|
|
|
ret = proc_dointvec_minmax(ctl, write, buffer, lenp, ppos);
|
|
if (!ret && write) {
|
|
xfs_panic_mask = *valp;
|
|
#ifdef DEBUG
|
|
xfs_panic_mask |= (XFS_PTAG_SHUTDOWN_CORRUPT | XFS_PTAG_LOGRES);
|
|
#endif
|
|
}
|
|
return ret;
|
|
}
|
|
#endif /* CONFIG_PROC_FS */
|
|
|
|
STATIC int
|
|
xfs_deprecated_dointvec_minmax(
|
|
const struct ctl_table *ctl,
|
|
int write,
|
|
void *buffer,
|
|
size_t *lenp,
|
|
loff_t *ppos)
|
|
{
|
|
if (write) {
|
|
printk_ratelimited(KERN_WARNING
|
|
"XFS: %s sysctl option is deprecated.\n",
|
|
ctl->procname);
|
|
}
|
|
return proc_dointvec_minmax(ctl, write, buffer, lenp, ppos);
|
|
}
|
|
|
|
static struct ctl_table xfs_table[] = {
|
|
{
|
|
.procname = "irix_sgid_inherit",
|
|
.data = &xfs_params.sgid_inherit.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = xfs_deprecated_dointvec_minmax,
|
|
.extra1 = &xfs_params.sgid_inherit.min,
|
|
.extra2 = &xfs_params.sgid_inherit.max
|
|
},
|
|
{
|
|
.procname = "irix_symlink_mode",
|
|
.data = &xfs_params.symlink_mode.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = xfs_deprecated_dointvec_minmax,
|
|
.extra1 = &xfs_params.symlink_mode.min,
|
|
.extra2 = &xfs_params.symlink_mode.max
|
|
},
|
|
{
|
|
.procname = "panic_mask",
|
|
.data = &xfs_params.panic_mask.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = xfs_panic_mask_proc_handler,
|
|
.extra1 = &xfs_params.panic_mask.min,
|
|
.extra2 = &xfs_params.panic_mask.max
|
|
},
|
|
|
|
{
|
|
.procname = "error_level",
|
|
.data = &xfs_params.error_level.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = &xfs_params.error_level.min,
|
|
.extra2 = &xfs_params.error_level.max
|
|
},
|
|
{
|
|
.procname = "xfssyncd_centisecs",
|
|
.data = &xfs_params.syncd_timer.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = &xfs_params.syncd_timer.min,
|
|
.extra2 = &xfs_params.syncd_timer.max
|
|
},
|
|
{
|
|
.procname = "inherit_sync",
|
|
.data = &xfs_params.inherit_sync.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = &xfs_params.inherit_sync.min,
|
|
.extra2 = &xfs_params.inherit_sync.max
|
|
},
|
|
{
|
|
.procname = "inherit_nodump",
|
|
.data = &xfs_params.inherit_nodump.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = &xfs_params.inherit_nodump.min,
|
|
.extra2 = &xfs_params.inherit_nodump.max
|
|
},
|
|
{
|
|
.procname = "inherit_noatime",
|
|
.data = &xfs_params.inherit_noatim.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = &xfs_params.inherit_noatim.min,
|
|
.extra2 = &xfs_params.inherit_noatim.max
|
|
},
|
|
{
|
|
.procname = "inherit_nosymlinks",
|
|
.data = &xfs_params.inherit_nosym.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = &xfs_params.inherit_nosym.min,
|
|
.extra2 = &xfs_params.inherit_nosym.max
|
|
},
|
|
{
|
|
.procname = "rotorstep",
|
|
.data = &xfs_params.rotorstep.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = &xfs_params.rotorstep.min,
|
|
.extra2 = &xfs_params.rotorstep.max
|
|
},
|
|
{
|
|
.procname = "inherit_nodefrag",
|
|
.data = &xfs_params.inherit_nodfrg.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = &xfs_params.inherit_nodfrg.min,
|
|
.extra2 = &xfs_params.inherit_nodfrg.max
|
|
},
|
|
{
|
|
.procname = "filestream_centisecs",
|
|
.data = &xfs_params.fstrm_timer.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = &xfs_params.fstrm_timer.min,
|
|
.extra2 = &xfs_params.fstrm_timer.max,
|
|
},
|
|
{
|
|
.procname = "speculative_prealloc_lifetime",
|
|
.data = &xfs_params.blockgc_timer.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = &xfs_params.blockgc_timer.min,
|
|
.extra2 = &xfs_params.blockgc_timer.max,
|
|
},
|
|
{
|
|
.procname = "speculative_cow_prealloc_lifetime",
|
|
.data = &xfs_params.blockgc_timer.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = xfs_deprecated_dointvec_minmax,
|
|
.extra1 = &xfs_params.blockgc_timer.min,
|
|
.extra2 = &xfs_params.blockgc_timer.max,
|
|
},
|
|
/* please keep this the last entry */
|
|
#ifdef CONFIG_PROC_FS
|
|
{
|
|
.procname = "stats_clear",
|
|
.data = &xfs_params.stats_clear.val,
|
|
.maxlen = sizeof(int),
|
|
.mode = 0644,
|
|
.proc_handler = xfs_stats_clear_proc_handler,
|
|
.extra1 = &xfs_params.stats_clear.min,
|
|
.extra2 = &xfs_params.stats_clear.max
|
|
},
|
|
#endif /* CONFIG_PROC_FS */
|
|
};
|
|
|
|
int
|
|
xfs_sysctl_register(void)
|
|
{
|
|
xfs_table_header = register_sysctl("fs/xfs", xfs_table);
|
|
if (!xfs_table_header)
|
|
return -ENOMEM;
|
|
return 0;
|
|
}
|
|
|
|
void
|
|
xfs_sysctl_unregister(void)
|
|
{
|
|
unregister_sysctl_table(xfs_table_header);
|
|
}
|