mirror of
https://github.com/torvalds/linux.git
synced 2024-12-22 10:56:40 +00:00
0d9f78a92e
The Microsoft LifeChat 3000 USB headset was causing a very reproducible
hang whenever it was plugged in. At first, I thought the host
controller was producing bad transfer events, because the log was filled
with errors like:
xhci_hcd 0000:00:14.0: ERROR Transfer event TRB DMA ptr not part of current TD
However, it turned out to be an xHCI driver bug in the ring expansion
patches. The bug is triggered When there are two ring segments, and a
TD that ends just before a link TRB, like so:
______________ _____________
| | ---> | setup TRB B |
______________ | _____________
| | | | data TRB B |
______________ | _____________
| setup TRB A | <-- deq | | data TRB B |
______________ | _____________
| data TRB A | | | | <-- enq, deq''
______________ | _____________
| status TRB A | | | |
______________ | _____________
| link TRB |--------------- | link TRB |
_____________ <--- deq' _____________
TD A (the first control transfer) stalls on the data phase. That halts
the ring. The xHCI driver moves the hardware dequeue pointer to the
first TRB after the stalled transfer, which happens to be the link TRB.
Once the Set TR dequeue pointer command completes, the function
update_ring_for_set_deq_completion runs. That function is supposed to
update the xHCI driver's dequeue pointer to match the internal hardware
dequeue pointer. On the first call this would work fine, and the
software dequeue pointer would move to deq'.
However, if the transfer immediately after that stalled (TD B in this
case), another Set TR Dequeue command would be issued. That would move
the hardware dequeue pointer to deq''. Once that command completed,
update_ring_for_set_deq_completion would run again.
The original code would unconditionally increment the software dequeue
pointer, which moved the pointer off the ring segment into la-la-land.
The while loop would happy increment the dequeue pointer (possibly
wrapping it) until it matched the hardware pointer value.
The while loop would also access all the memory in between the first
ring segment and the second ring segment to determine if it was a link
TRB. This could cause general protection faults, although it was
unlikely because the ring segments came from a DMA pool, and would often
have consecutive memory addresses.
If nothing in that space looked like a link TRB, the deq_seg pointer for
the ring would remain on the first segment. Thus, the deq_seg and the
software dequeue pointer would get out of sync.
When the next transfer event came in after the stalled transfer, the
xHCI driver code would attempt to convert the software dequeue pointer
into a DMA address in order to compare the DMA address for the completed
transfer. Since the deq_seg and the dequeue pointer were out of sync,
xhci_trb_virt_to_dma would return NULL.
The transfer event would get ignored, the transfer would eventually
timeout, and we would mistakenly convert the finished transfer to no-op
TRBs. Some kernel driver (maybe xHCI?) would then get stuck in an
infinite loop in interrupt context, and the whole machine would hang.
This patch should be backported to kernels as old as 3.4, that contain
the commit
|
||
|---|---|---|
| .. | ||
| whci | ||
| alchemy-common.c | ||
| bcma-hcd.c | ||
| ehci-atmel.c | ||
| ehci-au1xxx.c | ||
| ehci-cns3xxx.c | ||
| ehci-dbg.c | ||
| ehci-fsl.c | ||
| ehci-fsl.h | ||
| ehci-grlib.c | ||
| ehci-hcd.c | ||
| ehci-hub.c | ||
| ehci-ixp4xx.c | ||
| ehci-lpm.c | ||
| ehci-ls1x.c | ||
| ehci-mem.c | ||
| ehci-msm.c | ||
| ehci-mv.c | ||
| ehci-mxc.c | ||
| ehci-octeon.c | ||
| ehci-omap.c | ||
| ehci-orion.c | ||
| ehci-pci.c | ||
| ehci-platform.c | ||
| ehci-pmcmsp.c | ||
| ehci-ppc-of.c | ||
| ehci-ps3.c | ||
| ehci-q.c | ||
| ehci-s5p.c | ||
| ehci-sched.c | ||
| ehci-sead3.c | ||
| ehci-sh.c | ||
| ehci-spear.c | ||
| ehci-sysfs.c | ||
| ehci-tegra.c | ||
| ehci-vt8500.c | ||
| ehci-w90x900.c | ||
| ehci-xilinx-of.c | ||
| ehci-xls.c | ||
| ehci.h | ||
| fhci-dbg.c | ||
| fhci-hcd.c | ||
| fhci-hub.c | ||
| fhci-mem.c | ||
| fhci-q.c | ||
| fhci-sched.c | ||
| fhci-tds.c | ||
| fhci.h | ||
| fsl-mph-dr-of.c | ||
| hwa-hc.c | ||
| imx21-dbg.c | ||
| imx21-hcd.c | ||
| imx21-hcd.h | ||
| isp116x-hcd.c | ||
| isp116x.h | ||
| isp1362-hcd.c | ||
| isp1362.h | ||
| isp1760-hcd.c | ||
| isp1760-hcd.h | ||
| isp1760-if.c | ||
| Kconfig | ||
| Makefile | ||
| octeon2-common.c | ||
| ohci-at91.c | ||
| ohci-au1xxx.c | ||
| ohci-cns3xxx.c | ||
| ohci-da8xx.c | ||
| ohci-dbg.c | ||
| ohci-ep93xx.c | ||
| ohci-exynos.c | ||
| ohci-hcd.c | ||
| ohci-hub.c | ||
| ohci-jz4740.c | ||
| ohci-mem.c | ||
| ohci-nxp.c | ||
| ohci-octeon.c | ||
| ohci-omap3.c | ||
| ohci-omap.c | ||
| ohci-pci.c | ||
| ohci-platform.c | ||
| ohci-pnx8550.c | ||
| ohci-ppc-of.c | ||
| ohci-ppc-soc.c | ||
| ohci-ps3.c | ||
| ohci-pxa27x.c | ||
| ohci-q.c | ||
| ohci-s3c2410.c | ||
| ohci-sa1111.c | ||
| ohci-sh.c | ||
| ohci-sm501.c | ||
| ohci-spear.c | ||
| ohci-tmio.c | ||
| ohci-xls.c | ||
| ohci.h | ||
| oxu210hp-hcd.c | ||
| oxu210hp.h | ||
| pci-quirks.c | ||
| pci-quirks.h | ||
| r8a66597-hcd.c | ||
| r8a66597.h | ||
| sl811_cs.c | ||
| sl811-hcd.c | ||
| sl811.h | ||
| ssb-hcd.c | ||
| u132-hcd.c | ||
| uhci-debug.c | ||
| uhci-grlib.c | ||
| uhci-hcd.c | ||
| uhci-hcd.h | ||
| uhci-hub.c | ||
| uhci-pci.c | ||
| uhci-q.c | ||
| xhci-dbg.c | ||
| xhci-ext-caps.h | ||
| xhci-hub.c | ||
| xhci-mem.c | ||
| xhci-pci.c | ||
| xhci-plat.c | ||
| xhci-ring.c | ||
| xhci.c | ||
| xhci.h | ||