Tomi Valkeinen 0d96687213 media: videobuf2-dma-contig: fix bad kfree in vb2_dma_contig_clear_max_seg_size ... Commit 9495b7e92f ("driver core: platform: Initialize dma_parms for platform devices") in v5.7-rc5 causes vb2_dma_contig_clear_max_seg_size() to kfree memory that was not allocated by vb2_dma_contig_set_max_seg_size(). The assumption in vb2_dma_contig_set_max_seg_size() seems to be that dev->dma_parms is always NULL when the driver is probed, and the case where dev->dma_parms has bee initialized by someone else than the driver (by calling vb2_dma_contig_set_max_seg_size) will cause a failure. All the current users of these functions are platform devices, which now always have dma_parms set by the driver core. To fix the issue for v5.7, make vb2_dma_contig_set_max_seg_size() return an error if dma_parms is NULL to be on the safe side, and remove the kfree code from vb2_dma_contig_clear_max_seg_size(). For v5.8 we should remove the two functions and move the dma_set_max_seg_size() calls into the drivers. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Fixes: 9495b7e92f ("driver core: platform: Initialize dma_parms for platform devices") Cc: stable@vger.kernel.org Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>		2020-06-11 19:20:55 +02:00
..
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	media: vb2: Makefile: place vb2-trace together with vb2-core	2018-02-26 11:39:04 -05:00
vb2-trace.c	media: videobuf2: fix build issues with vb2-trace	2018-02-23 05:13:53 -05:00
videobuf2-core.c	media: videobuf2-core: fix dprintk level	2020-03-12 17:21:57 +01:00
videobuf2-dma-contig.c	media: videobuf2-dma-contig: fix bad kfree in vb2_dma_contig_clear_max_seg_size	2020-06-11 19:20:55 +02:00
videobuf2-dma-sg.c	media/videobuf2: Drop dma_buf->k(un)map support	2019-11-25 22:36:15 +01:00
videobuf2-dvb.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
videobuf2-memops.c	media: videobuf2-vmalloc: get_userptr: buffers are always writable	2019-05-29 08:05:58 -04:00
videobuf2-v4l2.c	media: v4l2: abstract timeval handling in v4l2_buffer	2020-01-03 15:43:35 +01:00
videobuf2-vmalloc.c	drm pull for 5.6-rc1	2020-01-30 08:04:01 -08:00