mirror of
https://github.com/torvalds/linux.git
synced 2024-12-04 18:13:04 +00:00
b6d49cab44
Commitd1cbfd771c("ptp_clock: Allow for it to be optional") changed all PTP-capable Ethernet drivers from `select PTP_1588_CLOCK` to `imply PTP_1588_CLOCK`, "in order to break the hard dependency between the PTP clock subsystem and ethernet drivers capable of being clock providers." As a result it is possible to build PTP-capable Ethernet drivers without the PTP subsystem by deselecting PTP_1588_CLOCK. Drivers are required to handle the missing dependency gracefully. Some PTP-capable Ethernet drivers (e.g., TI_CPSW) factor their PTP code out into separate drivers (e.g., TI_CPTS_MOD). The above commit also changed these PTP-specific drivers to `imply PTP_1588_CLOCK`, making it possible to build them without the PTP subsystem. But as Grygorii Strashko noted in [1]: On Wed, Apr 22, 2020 at 02:16:11PM +0300, Grygorii Strashko wrote: > Another question is that CPTS completely nonfunctional in this case and > it was never expected that somebody will even try to use/run such > configuration (except for random build purposes). In my view, enabling a PTP-specific driver without the PTP subsystem is a configuration error made possible by the above commit. Kconfig should not allow users to create a configuration with missing dependencies that results in "completely nonfunctional" drivers. I audited all network drivers that call ptp_clock_register() but merely `imply PTP_1588_CLOCK` and found five PTP-specific drivers that are likely nonfunctional without PTP_1588_CLOCK: NET_DSA_MV88E6XXX_PTP NET_DSA_SJA1105_PTP MACB_USE_HWSTAMP CAVIUM_PTP TI_CPTS_MOD Note how these symbols all reference PTP or timestamping in their name; this is a clue that they depend on PTP_1588_CLOCK. Change them from `imply PTP_1588_CLOCK` [2] to `depends on PTP_1588_CLOCK`. I'm not using `select PTP_1588_CLOCK` here because PTP_1588_CLOCK has its own dependencies, which `select` would not transitively apply. Additionally, remove the `select NET_PTP_CLASSIFY` from CPTS_TI_MOD; PTP_1588_CLOCK already selects that. [1]: https://lore.kernel.org/lkml/c04458ed-29ee-1797-3a11-7f3f560553e6@ti.com/ [2]: NET_DSA_SJA1105_PTP had never declared any type of dependency on PTP_1588_CLOCK (`imply` or otherwise); adding a `depends on PTP_1588_CLOCK` here seems appropriate. Cc: Arnd Bergmann <arnd@arndb.de> Cc: Richard Cochran <richardcochran@gmail.com> Cc: Nicolas Pitre <nico@fluxnic.net> Cc: Grygorii Strashko <grygorii.strashko@ti.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Fixes:d1cbfd771c("ptp_clock: Allow for it to be optional") Signed-off-by: Clay McClure <clay@daemons.net> Signed-off-by: David S. Miller <davem@davemloft.net>
104 lines
3.0 KiB
Plaintext
104 lines
3.0 KiB
Plaintext
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# Cavium ethernet device configuration
|
|
#
|
|
|
|
config NET_VENDOR_CAVIUM
|
|
bool "Cavium ethernet drivers"
|
|
default y
|
|
---help---
|
|
Select this option if you want enable Cavium network support.
|
|
|
|
If you have a Cavium SoC or network adapter, say Y.
|
|
|
|
if NET_VENDOR_CAVIUM
|
|
|
|
config THUNDER_NIC_PF
|
|
tristate "Thunder Physical function driver"
|
|
depends on 64BIT && PCI
|
|
select THUNDER_NIC_BGX
|
|
---help---
|
|
This driver supports Thunder's NIC physical function.
|
|
The NIC provides the controller and DMA engines to
|
|
move network traffic to/from the memory. The NIC
|
|
works closely with TNS, BGX and SerDes to implement the
|
|
functions replacing and virtualizing those of a typical
|
|
standalone PCIe NIC chip.
|
|
|
|
config THUNDER_NIC_VF
|
|
tristate "Thunder Virtual function driver"
|
|
imply CAVIUM_PTP
|
|
depends on 64BIT && PCI
|
|
---help---
|
|
This driver supports Thunder's NIC virtual function
|
|
|
|
config THUNDER_NIC_BGX
|
|
tristate "Thunder MAC interface driver (BGX)"
|
|
depends on 64BIT && PCI
|
|
select PHYLIB
|
|
select MDIO_THUNDER if PCI
|
|
select THUNDER_NIC_RGX
|
|
---help---
|
|
This driver supports programming and controlling of MAC
|
|
interface from NIC physical function driver.
|
|
|
|
config THUNDER_NIC_RGX
|
|
tristate "Thunder MAC interface driver (RGX)"
|
|
depends on 64BIT && PCI
|
|
select PHYLIB
|
|
select MDIO_THUNDER if PCI
|
|
---help---
|
|
This driver supports configuring XCV block of RGX interface
|
|
present on CN81XX chip.
|
|
|
|
config CAVIUM_PTP
|
|
tristate "Cavium PTP coprocessor as PTP clock"
|
|
depends on 64BIT && PCI
|
|
depends on PTP_1588_CLOCK
|
|
---help---
|
|
This driver adds support for the Precision Time Protocol Clocks and
|
|
Timestamping coprocessor (PTP) found on Cavium processors.
|
|
PTP provides timestamping mechanism that is suitable for use in IEEE 1588
|
|
Precision Time Protocol or other purposes. Timestamps can be used in
|
|
BGX, TNS, GTI, and NIC blocks.
|
|
|
|
config LIQUIDIO
|
|
tristate "Cavium LiquidIO support"
|
|
depends on 64BIT && PCI
|
|
depends on PCI
|
|
imply PTP_1588_CLOCK
|
|
select FW_LOADER
|
|
select LIBCRC32C
|
|
select NET_DEVLINK
|
|
---help---
|
|
This driver supports Cavium LiquidIO Intelligent Server Adapters
|
|
based on CN66XX, CN68XX and CN23XX chips.
|
|
|
|
To compile this driver as a module, choose M here: the module
|
|
will be called liquidio. This is recommended.
|
|
|
|
config OCTEON_MGMT_ETHERNET
|
|
tristate "Octeon Management port ethernet driver (CN5XXX, CN6XXX)"
|
|
depends on CAVIUM_OCTEON_SOC
|
|
select PHYLIB
|
|
select MDIO_OCTEON
|
|
default y
|
|
help
|
|
Enable the ethernet driver for the management
|
|
port on Cavium Networks' Octeon CN57XX, CN56XX, CN55XX,
|
|
CN54XX, CN52XX, and CN6XXX chips.
|
|
|
|
config LIQUIDIO_VF
|
|
tristate "Cavium LiquidIO VF support"
|
|
depends on 64BIT && PCI_MSI
|
|
imply PTP_1588_CLOCK
|
|
---help---
|
|
This driver supports Cavium LiquidIO Intelligent Server Adapter
|
|
based on CN23XX chips.
|
|
|
|
To compile this driver as a module, choose M here: The module
|
|
will be called liquidio_vf. MSI-X interrupt support is required
|
|
for this driver to work correctly
|
|
|
|
endif # NET_VENDOR_CAVIUM
|