Felix Maurer 0c0d0f42ff xsk: Free skb when TX metadata options are invalid ... When a new skb is allocated for transmitting an xsk descriptor, i.e., for every non-multibuf descriptor or the first frag of a multibuf descriptor, but the descriptor is later found to have invalid options set for the TX metadata, the new skb is never freed. This can leak skbs until the send buffer is full which makes sending more packets impossible. Fix this by freeing the skb in the error path if we are currently dealing with the first frag, i.e., an skb allocated in this iteration of xsk_build_skb. Fixes: 48eb03dd26 ("xsk: Add TX timestamp and TX checksum offload support") Reported-by: Michal Schmidt <mschmidt@redhat.com> Signed-off-by: Felix Maurer <fmaurer@redhat.com> Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com> Acked-by: Stanislav Fomichev <sdf@fomichev.me> Acked-by: Martin KaFai Lau <martin.lau@kernel.org> Link: https://patch.msgid.link/edb9b00fb19e680dff5a3350cd7581c5927975a8.1731581697.git.fmaurer@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-11-15 14:26:40 -08:00
..
6lowpan	ipv6: eliminate ndisc_ops_is_useropt()	2024-08-12 17:23:57 -07:00
9p	9p: fix slab cache name creation for real	2024-10-21 15:41:29 -07:00
802	move asm/unaligned.h to linux/unaligned.h	2024-10-02 17:23:23 -04:00
8021q	netdev_features: remove NETIF_F_ALL_FCOE	2024-09-03 11:36:43 +02:00
appletalk	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-05-09 10:01:01 -07:00
atm	atm: clean up a put_user() calls	2024-06-14 19:08:50 -07:00
ax25	ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()	2024-06-01 15:49:42 -07:00
batman-adv	move asm/unaligned.h to linux/unaligned.h	2024-10-02 17:23:23 -04:00
bluetooth	Bluetooth: hci_core: Fix calling mgmt_device_connected	2024-11-12 11:39:12 -05:00
bpf	bpf, test_run: Fix LIVE_FRAME frame update after a page has been recycled	2024-10-31 16:15:21 +01:00
bridge	bridge: Handle error of rtnl_register_module().	2024-10-10 15:39:35 +02:00
caif	move asm/unaligned.h to linux/unaligned.h	2024-10-02 17:23:23 -04:00
can	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-09-15 09:13:19 -07:00
ceph	libceph: use min() to simplify code in ceph_dns_resolve_name()	2024-08-27 09:30:16 +02:00
core	netdev-genl: Hold rcu_read_lock in napi_get	2024-11-15 14:20:19 -08:00
dcb
dccp	net: fix data-races around sk->sk_forward_alloc	2024-11-11 15:29:33 -08:00
devlink	devlink: Constify the 'table_ops' parameter of devl_dpipe_table_register()	2024-06-05 10:24:57 +01:00
dns_resolver
dsa	net: dsa: refuse cross-chip mirroring operations	2024-10-09 19:41:35 -07:00
ethernet	netkit: Fix pkt_type override upon netkit pass verdict	2024-05-25 10:48:57 -07:00
ethtool	net: ethtool: phy: Don't set the context dev pointer for unfiltered DUMP	2024-09-13 21:40:12 -07:00
handshake	net/handshake: use sockfd_put() helper	2024-08-27 16:09:25 -07:00
hsr	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-09-12 17:11:24 -07:00
ieee802154	netdev_features: convert NETIF_F_NETNS_LOCAL to dev->netns_local	2024-09-03 11:36:43 +02:00
ife
ipv4	ipmr: Fix access to mfc_cache_list without lock held	2024-11-13 19:09:42 -08:00
ipv6	net: fix data-races around sk->sk_forward_alloc	2024-11-11 15:29:33 -08:00
iucv	s390/iucv: Fix vargs handling in iucv_alloc_device()	2024-08-22 13:09:20 -07:00
kcm	kcm: Serialise kcm_sendmsg() for the same socket.	2024-08-19 18:36:12 -07:00
key
l2tp	genetlink: hold RCU in genlmsg_mcast()	2024-10-15 17:52:58 -07:00
l3mdev
lapb
llc	llc: Constify struct llc_sap_state_trans	2024-07-15 08:51:19 -07:00
mac80211	wifi: mac80211: ieee80211_i: Fix memory corruption bug in struct ieee80211_chanctx	2024-10-26 00:42:49 +02:00
mac802154	Including fixes from ieee802154, bluetooth and netfilter.	2024-10-03 09:44:00 -07:00
mctp	mctp: Handle error of rtnl_register_module().	2024-10-10 15:39:35 +02:00
mpls	mpls: Handle error of rtnl_register_module().	2024-10-10 15:39:35 +02:00
mptcp	mptcp: pm: use _rcu variant under rcu_read_lock	2024-11-13 18:51:02 -08:00
ncsi	net/ncsi: Disable the ncsi work before freeing the associated structure	2024-10-03 10:14:14 +02:00
netfilter	netfilter pull request 24-11-14	2024-11-15 14:24:36 -08:00
netlabel	netlabel: fix RCU annotation for IPv4 options on socket creation	2024-05-13 14:58:12 -07:00
netlink	netlink: terminate outstanding dump on socket close	2024-11-07 13:45:34 -08:00
netrom	net/netrom: prefer strscpy over strcpy	2024-08-29 12:33:07 -07:00
nfc	Quite smaller than usual. Notably it includes the fix for the unix	2024-05-23 12:49:37 -07:00
nsh
openvswitch	netdev_features: convert NETIF_F_NETNS_LOCAL to dev->netns_local	2024-09-03 11:36:43 +02:00
packet	net: add support for skbs with unreadable frags	2024-09-11 20:44:31 -07:00
phonet	phonet: Handle error of rtnl_register_module().	2024-10-10 15:39:36 +02:00
psample	net: psample: fix flag being set in wrong skb	2024-07-11 18:11:31 -07:00
qrtr	net: qrtr: Update packets cloning when broadcasting	2024-09-24 10:48:16 +02:00
rds	net: rds: add option for GCOV profiling	2024-08-09 13:18:46 +01:00
rfkill	[tree-wide] finally take no_llseek out	2024-09-27 08:18:43 -07:00
rose	net: change proto and proto_ops accept type	2024-05-13 18:19:09 -06:00
rxrpc	rxrpc: Fix missing locking causing hanging calls	2024-11-07 11:30:34 -08:00
sched	net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.	2024-11-12 18:26:03 -08:00
sctp	sctp: fix possible UAF in sctp_v6_available()	2024-11-09 09:15:04 -08:00
smc	net/smc: do not leave a dangling sk pointer in __smc_create()	2024-11-07 11:31:14 -08:00
strparser
sunrpc	sunrpc: handle -ENOTCONN in xs_tcp_setup_socket()	2024-11-04 10:24:18 -05:00
switchdev
tipc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-09-15 09:13:19 -07:00
tls	move asm/unaligned.h to linux/unaligned.h	2024-10-02 17:23:23 -04:00
unix	af_unix: Don't return OOB skb in manage_oob().	2024-09-09 17:14:27 -07:00
vmw_vsock	Including fixes from bluetooth.	2024-11-14 10:05:33 -08:00
wireless	wifi: cfg80211: clear wdev->cqm_config pointer on free	2024-10-25 17:53:40 +02:00
x25	net: change proto and proto_ops accept type	2024-05-13 18:19:09 -06:00
xdp	xsk: Free skb when TX metadata options are invalid	2024-11-15 14:26:40 -08:00
xfrm	ipsec-2024-10-22	2024-10-24 11:11:33 +02:00
compat.c
devres.c
Kconfig	memory-provider: disable building dmabuf mp on !CONFIG_PAGE_POOL	2024-09-13 11:41:45 -07:00
Kconfig.debug
Makefile
socket.c	net: explicitly clear the sk pointer, when pf->create fails	2024-10-07 16:21:59 -07:00
sysctl_net.c	sysctl: Remove check for sentinel element in ctl_table arrays	2024-06-13 10:50:52 +02:00