mirror of
https://github.com/torvalds/linux.git
synced 2024-11-05 11:32:04 +00:00
715a223323
Currently, V4L uses a scancode table whose index is the scancode and
the value is the keycode. While this works, it has some drawbacks:
1) It requires that the scancode to be at the range 00-7f;
2) keycodes should be masked on 7 bits in order for it to work;
3) due to the 7 bits approach, sometimes it is not possible to replace
the default keyboard to another one with a different encoding rule;
4) it is different than what is done with dvb-usb approach;
5) it requires a typedef for it to work. This is not a recommended
Linux CodingStyle.
This patch is part of a larger series of IR changes. It basically
replaces the IR_KEYTAB_TYPE tables by a structured table:
struct ir_scancode {
u16 scancode;
u32 keycode;
};
This is very close to what dvb does. So, a further integration with DVB
code will be easy.
While we've changed the tables, for now, the IR keycode handling is still
based on the old approach.
The only notable effect is the redution of about 35% of the ir-common
module size:
text data bss dec hex filename
6721 29208 4 35933 8c5d old/ir-common.ko
5756 18040 4 23800 5cf8 new/ir-common.ko
In thesis, we could be using above u8 for scancode, reducing even more the size
of the module, but defining it as u16 is more convenient, since, on dvb, each
scancode has up to 16 bits, and we currently have a few troubles with rc5, as their
scancodes are defined with more than 8 bits.
This patch itself shouldn't be doing any functional changes.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
48 lines
1.1 KiB
C
48 lines
1.1 KiB
C
#ifndef _IR_I2C
|
|
#define _IR_I2C
|
|
|
|
#include <media/ir-common.h>
|
|
|
|
struct IR_i2c;
|
|
|
|
struct IR_i2c {
|
|
struct ir_scancode_table *ir_codes;
|
|
|
|
struct i2c_client *c;
|
|
struct input_dev *input;
|
|
struct ir_input_state ir;
|
|
|
|
/* Used to avoid fast repeating */
|
|
unsigned char old;
|
|
|
|
struct delayed_work work;
|
|
char name[32];
|
|
char phys[32];
|
|
int (*get_key)(struct IR_i2c*, u32*, u32*);
|
|
};
|
|
|
|
enum ir_kbd_get_key_fn {
|
|
IR_KBD_GET_KEY_CUSTOM = 0,
|
|
IR_KBD_GET_KEY_PIXELVIEW,
|
|
IR_KBD_GET_KEY_PV951,
|
|
IR_KBD_GET_KEY_HAUP,
|
|
IR_KBD_GET_KEY_KNC1,
|
|
IR_KBD_GET_KEY_FUSIONHDTV,
|
|
IR_KBD_GET_KEY_HAUP_XVR,
|
|
IR_KBD_GET_KEY_AVERMEDIA_CARDBUS,
|
|
};
|
|
|
|
/* Can be passed when instantiating an ir_video i2c device */
|
|
struct IR_i2c_init_data {
|
|
struct ir_scancode_table *ir_codes;
|
|
const char *name;
|
|
int type; /* IR_TYPE_RC5, IR_TYPE_PD, etc */
|
|
/*
|
|
* Specify either a function pointer or a value indicating one of
|
|
* ir_kbd_i2c's internal get_key functions
|
|
*/
|
|
int (*get_key)(struct IR_i2c*, u32*, u32*);
|
|
enum ir_kbd_get_key_fn internal_get_key_func;
|
|
};
|
|
#endif
|