mirror of
https://github.com/torvalds/linux.git
synced 2024-12-02 17:11:33 +00:00
f870231fdd
Add a mutex lock to protect concurrent access to I/O registers against each other. This happens between invocation of commit- tail functions and get-mode operations. Both with use the CRTC index register AST_IO_CRTC_PORT. Concurrent access can lead to failed mode-setting operations. v2: * fix typo in commit description (Jocelyn) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Reported-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220502142514.2174-3-tzimmermann@suse.de
483 lines
12 KiB
C
483 lines
12 KiB
C
/*
|
|
* Copyright 2012 Red Hat Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the
|
|
* "Software"), to deal in the Software without restriction, including
|
|
* without limitation the rights to use, copy, modify, merge, publish,
|
|
* distribute, sub license, and/or sell copies of the Software, and to
|
|
* permit persons to whom the Software is furnished to do so, subject to
|
|
* the following conditions:
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL
|
|
* THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM,
|
|
* DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
* OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
* USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The above copyright notice and this permission notice (including the
|
|
* next paragraph) shall be included in all copies or substantial portions
|
|
* of the Software.
|
|
*
|
|
*/
|
|
/*
|
|
* Authors: Dave Airlie <airlied@redhat.com>
|
|
*/
|
|
|
|
#include <linux/pci.h>
|
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_crtc_helper.h>
|
|
#include <drm/drm_drv.h>
|
|
#include <drm/drm_gem.h>
|
|
#include <drm/drm_gem_vram_helper.h>
|
|
#include <drm/drm_managed.h>
|
|
|
|
#include "ast_drv.h"
|
|
|
|
void ast_set_index_reg_mask(struct ast_private *ast,
|
|
uint32_t base, uint8_t index,
|
|
uint8_t mask, uint8_t val)
|
|
{
|
|
u8 tmp;
|
|
ast_io_write8(ast, base, index);
|
|
tmp = (ast_io_read8(ast, base + 1) & mask) | val;
|
|
ast_set_index_reg(ast, base, index, tmp);
|
|
}
|
|
|
|
uint8_t ast_get_index_reg(struct ast_private *ast,
|
|
uint32_t base, uint8_t index)
|
|
{
|
|
uint8_t ret;
|
|
ast_io_write8(ast, base, index);
|
|
ret = ast_io_read8(ast, base + 1);
|
|
return ret;
|
|
}
|
|
|
|
uint8_t ast_get_index_reg_mask(struct ast_private *ast,
|
|
uint32_t base, uint8_t index, uint8_t mask)
|
|
{
|
|
uint8_t ret;
|
|
ast_io_write8(ast, base, index);
|
|
ret = ast_io_read8(ast, base + 1) & mask;
|
|
return ret;
|
|
}
|
|
|
|
static void ast_detect_config_mode(struct drm_device *dev, u32 *scu_rev)
|
|
{
|
|
struct device_node *np = dev->dev->of_node;
|
|
struct ast_private *ast = to_ast_private(dev);
|
|
struct pci_dev *pdev = to_pci_dev(dev->dev);
|
|
uint32_t data, jregd0, jregd1;
|
|
|
|
/* Defaults */
|
|
ast->config_mode = ast_use_defaults;
|
|
*scu_rev = 0xffffffff;
|
|
|
|
/* Check if we have device-tree properties */
|
|
if (np && !of_property_read_u32(np, "aspeed,scu-revision-id",
|
|
scu_rev)) {
|
|
/* We do, disable P2A access */
|
|
ast->config_mode = ast_use_dt;
|
|
drm_info(dev, "Using device-tree for configuration\n");
|
|
return;
|
|
}
|
|
|
|
/* Not all families have a P2A bridge */
|
|
if (pdev->device != PCI_CHIP_AST2000)
|
|
return;
|
|
|
|
/*
|
|
* The BMC will set SCU 0x40 D[12] to 1 if the P2 bridge
|
|
* is disabled. We force using P2A if VGA only mode bit
|
|
* is set D[7]
|
|
*/
|
|
jregd0 = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xd0, 0xff);
|
|
jregd1 = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xd1, 0xff);
|
|
if (!(jregd0 & 0x80) || !(jregd1 & 0x10)) {
|
|
/* Patch AST2500 */
|
|
if (((pdev->revision & 0xF0) == 0x40)
|
|
&& ((jregd0 & AST_VRAM_INIT_STATUS_MASK) == 0))
|
|
ast_patch_ahb_2500(ast);
|
|
|
|
/* Double check it's actually working */
|
|
data = ast_read32(ast, 0xf004);
|
|
if ((data != 0xFFFFFFFF) && (data != 0x00)) {
|
|
/* P2A works, grab silicon revision */
|
|
ast->config_mode = ast_use_p2a;
|
|
|
|
drm_info(dev, "Using P2A bridge for configuration\n");
|
|
|
|
/* Read SCU7c (silicon revision register) */
|
|
ast_write32(ast, 0xf004, 0x1e6e0000);
|
|
ast_write32(ast, 0xf000, 0x1);
|
|
*scu_rev = ast_read32(ast, 0x1207c);
|
|
return;
|
|
}
|
|
}
|
|
|
|
/* We have a P2A bridge but it's disabled */
|
|
drm_info(dev, "P2A bridge disabled, using default configuration\n");
|
|
}
|
|
|
|
static int ast_detect_chip(struct drm_device *dev, bool *need_post)
|
|
{
|
|
struct ast_private *ast = to_ast_private(dev);
|
|
struct pci_dev *pdev = to_pci_dev(dev->dev);
|
|
uint32_t jreg, scu_rev;
|
|
|
|
/*
|
|
* If VGA isn't enabled, we need to enable now or subsequent
|
|
* access to the scratch registers will fail. We also inform
|
|
* our caller that it needs to POST the chip
|
|
* (Assumption: VGA not enabled -> need to POST)
|
|
*/
|
|
if (!ast_is_vga_enabled(dev)) {
|
|
ast_enable_vga(dev);
|
|
drm_info(dev, "VGA not enabled on entry, requesting chip POST\n");
|
|
*need_post = true;
|
|
} else
|
|
*need_post = false;
|
|
|
|
|
|
/* Enable extended register access */
|
|
ast_open_key(ast);
|
|
ast_enable_mmio(dev);
|
|
|
|
/* Find out whether P2A works or whether to use device-tree */
|
|
ast_detect_config_mode(dev, &scu_rev);
|
|
|
|
/* Identify chipset */
|
|
if (pdev->revision >= 0x50) {
|
|
ast->chip = AST2600;
|
|
drm_info(dev, "AST 2600 detected\n");
|
|
} else if (pdev->revision >= 0x40) {
|
|
ast->chip = AST2500;
|
|
drm_info(dev, "AST 2500 detected\n");
|
|
} else if (pdev->revision >= 0x30) {
|
|
ast->chip = AST2400;
|
|
drm_info(dev, "AST 2400 detected\n");
|
|
} else if (pdev->revision >= 0x20) {
|
|
ast->chip = AST2300;
|
|
drm_info(dev, "AST 2300 detected\n");
|
|
} else if (pdev->revision >= 0x10) {
|
|
switch (scu_rev & 0x0300) {
|
|
case 0x0200:
|
|
ast->chip = AST1100;
|
|
drm_info(dev, "AST 1100 detected\n");
|
|
break;
|
|
case 0x0100:
|
|
ast->chip = AST2200;
|
|
drm_info(dev, "AST 2200 detected\n");
|
|
break;
|
|
case 0x0000:
|
|
ast->chip = AST2150;
|
|
drm_info(dev, "AST 2150 detected\n");
|
|
break;
|
|
default:
|
|
ast->chip = AST2100;
|
|
drm_info(dev, "AST 2100 detected\n");
|
|
break;
|
|
}
|
|
ast->vga2_clone = false;
|
|
} else {
|
|
ast->chip = AST2000;
|
|
drm_info(dev, "AST 2000 detected\n");
|
|
}
|
|
|
|
/* Check if we support wide screen */
|
|
switch (ast->chip) {
|
|
case AST2000:
|
|
ast->support_wide_screen = false;
|
|
break;
|
|
default:
|
|
jreg = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xd0, 0xff);
|
|
if (!(jreg & 0x80))
|
|
ast->support_wide_screen = true;
|
|
else if (jreg & 0x01)
|
|
ast->support_wide_screen = true;
|
|
else {
|
|
ast->support_wide_screen = false;
|
|
if (ast->chip == AST2300 &&
|
|
(scu_rev & 0x300) == 0x0) /* ast1300 */
|
|
ast->support_wide_screen = true;
|
|
if (ast->chip == AST2400 &&
|
|
(scu_rev & 0x300) == 0x100) /* ast1400 */
|
|
ast->support_wide_screen = true;
|
|
if (ast->chip == AST2500 &&
|
|
scu_rev == 0x100) /* ast2510 */
|
|
ast->support_wide_screen = true;
|
|
if (ast->chip == AST2600) /* ast2600 */
|
|
ast->support_wide_screen = true;
|
|
}
|
|
break;
|
|
}
|
|
|
|
/* Check 3rd Tx option (digital output afaik) */
|
|
ast->tx_chip_type = AST_TX_NONE;
|
|
|
|
/*
|
|
* VGACRA3 Enhanced Color Mode Register, check if DVO is already
|
|
* enabled, in that case, assume we have a SIL164 TMDS transmitter
|
|
*
|
|
* Don't make that assumption if we the chip wasn't enabled and
|
|
* is at power-on reset, otherwise we'll incorrectly "detect" a
|
|
* SIL164 when there is none.
|
|
*/
|
|
if (!*need_post) {
|
|
jreg = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xa3, 0xff);
|
|
if (jreg & 0x80)
|
|
ast->tx_chip_type = AST_TX_SIL164;
|
|
}
|
|
|
|
if ((ast->chip == AST2300) || (ast->chip == AST2400) || (ast->chip == AST2500)) {
|
|
/*
|
|
* On AST2300 and 2400, look the configuration set by the SoC in
|
|
* the SOC scratch register #1 bits 11:8 (interestingly marked
|
|
* as "reserved" in the spec)
|
|
*/
|
|
jreg = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xd1, 0xff);
|
|
switch (jreg) {
|
|
case 0x04:
|
|
ast->tx_chip_type = AST_TX_SIL164;
|
|
break;
|
|
case 0x08:
|
|
ast->dp501_fw_addr = drmm_kzalloc(dev, 32*1024, GFP_KERNEL);
|
|
if (ast->dp501_fw_addr) {
|
|
/* backup firmware */
|
|
if (ast_backup_fw(dev, ast->dp501_fw_addr, 32*1024)) {
|
|
drmm_kfree(dev, ast->dp501_fw_addr);
|
|
ast->dp501_fw_addr = NULL;
|
|
}
|
|
}
|
|
fallthrough;
|
|
case 0x0c:
|
|
ast->tx_chip_type = AST_TX_DP501;
|
|
}
|
|
} else if (ast->chip == AST2600)
|
|
ast_dp_launch(&ast->base, 0);
|
|
|
|
/* Print stuff for diagnostic purposes */
|
|
switch(ast->tx_chip_type) {
|
|
case AST_TX_SIL164:
|
|
drm_info(dev, "Using Sil164 TMDS transmitter\n");
|
|
break;
|
|
case AST_TX_DP501:
|
|
drm_info(dev, "Using DP501 DisplayPort transmitter\n");
|
|
break;
|
|
default:
|
|
drm_info(dev, "Analog VGA only\n");
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int ast_get_dram_info(struct drm_device *dev)
|
|
{
|
|
struct device_node *np = dev->dev->of_node;
|
|
struct ast_private *ast = to_ast_private(dev);
|
|
uint32_t mcr_cfg, mcr_scu_mpll, mcr_scu_strap;
|
|
uint32_t denum, num, div, ref_pll, dsel;
|
|
|
|
switch (ast->config_mode) {
|
|
case ast_use_dt:
|
|
/*
|
|
* If some properties are missing, use reasonable
|
|
* defaults for AST2400
|
|
*/
|
|
if (of_property_read_u32(np, "aspeed,mcr-configuration",
|
|
&mcr_cfg))
|
|
mcr_cfg = 0x00000577;
|
|
if (of_property_read_u32(np, "aspeed,mcr-scu-mpll",
|
|
&mcr_scu_mpll))
|
|
mcr_scu_mpll = 0x000050C0;
|
|
if (of_property_read_u32(np, "aspeed,mcr-scu-strap",
|
|
&mcr_scu_strap))
|
|
mcr_scu_strap = 0;
|
|
break;
|
|
case ast_use_p2a:
|
|
ast_write32(ast, 0xf004, 0x1e6e0000);
|
|
ast_write32(ast, 0xf000, 0x1);
|
|
mcr_cfg = ast_read32(ast, 0x10004);
|
|
mcr_scu_mpll = ast_read32(ast, 0x10120);
|
|
mcr_scu_strap = ast_read32(ast, 0x10170);
|
|
break;
|
|
case ast_use_defaults:
|
|
default:
|
|
ast->dram_bus_width = 16;
|
|
ast->dram_type = AST_DRAM_1Gx16;
|
|
if (ast->chip == AST2500)
|
|
ast->mclk = 800;
|
|
else
|
|
ast->mclk = 396;
|
|
return 0;
|
|
}
|
|
|
|
if (mcr_cfg & 0x40)
|
|
ast->dram_bus_width = 16;
|
|
else
|
|
ast->dram_bus_width = 32;
|
|
|
|
if (ast->chip == AST2500) {
|
|
switch (mcr_cfg & 0x03) {
|
|
case 0:
|
|
ast->dram_type = AST_DRAM_1Gx16;
|
|
break;
|
|
default:
|
|
case 1:
|
|
ast->dram_type = AST_DRAM_2Gx16;
|
|
break;
|
|
case 2:
|
|
ast->dram_type = AST_DRAM_4Gx16;
|
|
break;
|
|
case 3:
|
|
ast->dram_type = AST_DRAM_8Gx16;
|
|
break;
|
|
}
|
|
} else if (ast->chip == AST2300 || ast->chip == AST2400) {
|
|
switch (mcr_cfg & 0x03) {
|
|
case 0:
|
|
ast->dram_type = AST_DRAM_512Mx16;
|
|
break;
|
|
default:
|
|
case 1:
|
|
ast->dram_type = AST_DRAM_1Gx16;
|
|
break;
|
|
case 2:
|
|
ast->dram_type = AST_DRAM_2Gx16;
|
|
break;
|
|
case 3:
|
|
ast->dram_type = AST_DRAM_4Gx16;
|
|
break;
|
|
}
|
|
} else {
|
|
switch (mcr_cfg & 0x0c) {
|
|
case 0:
|
|
case 4:
|
|
ast->dram_type = AST_DRAM_512Mx16;
|
|
break;
|
|
case 8:
|
|
if (mcr_cfg & 0x40)
|
|
ast->dram_type = AST_DRAM_1Gx16;
|
|
else
|
|
ast->dram_type = AST_DRAM_512Mx32;
|
|
break;
|
|
case 0xc:
|
|
ast->dram_type = AST_DRAM_1Gx32;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (mcr_scu_strap & 0x2000)
|
|
ref_pll = 14318;
|
|
else
|
|
ref_pll = 12000;
|
|
|
|
denum = mcr_scu_mpll & 0x1f;
|
|
num = (mcr_scu_mpll & 0x3fe0) >> 5;
|
|
dsel = (mcr_scu_mpll & 0xc000) >> 14;
|
|
switch (dsel) {
|
|
case 3:
|
|
div = 0x4;
|
|
break;
|
|
case 2:
|
|
case 1:
|
|
div = 0x2;
|
|
break;
|
|
default:
|
|
div = 0x1;
|
|
break;
|
|
}
|
|
ast->mclk = ref_pll * (num + 2) / ((denum + 2) * (div * 1000));
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Run this function as part of the HW device cleanup; not
|
|
* when the DRM device gets released.
|
|
*/
|
|
static void ast_device_release(void *data)
|
|
{
|
|
struct ast_private *ast = data;
|
|
|
|
/* enable standard VGA decode */
|
|
ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x04);
|
|
}
|
|
|
|
struct ast_private *ast_device_create(const struct drm_driver *drv,
|
|
struct pci_dev *pdev,
|
|
unsigned long flags)
|
|
{
|
|
struct drm_device *dev;
|
|
struct ast_private *ast;
|
|
bool need_post;
|
|
int ret = 0;
|
|
|
|
ast = devm_drm_dev_alloc(&pdev->dev, drv, struct ast_private, base);
|
|
if (IS_ERR(ast))
|
|
return ast;
|
|
dev = &ast->base;
|
|
|
|
pci_set_drvdata(pdev, dev);
|
|
|
|
ret = drmm_mutex_init(dev, &ast->ioregs_lock);
|
|
if (ret)
|
|
return ERR_PTR(ret);
|
|
|
|
ast->regs = pcim_iomap(pdev, 1, 0);
|
|
if (!ast->regs)
|
|
return ERR_PTR(-EIO);
|
|
|
|
/*
|
|
* If we don't have IO space at all, use MMIO now and
|
|
* assume the chip has MMIO enabled by default (rev 0x20
|
|
* and higher).
|
|
*/
|
|
if (!(pci_resource_flags(pdev, 2) & IORESOURCE_IO)) {
|
|
drm_info(dev, "platform has no IO space, trying MMIO\n");
|
|
ast->ioregs = ast->regs + AST_IO_MM_OFFSET;
|
|
}
|
|
|
|
/* "map" IO regs if the above hasn't done so already */
|
|
if (!ast->ioregs) {
|
|
ast->ioregs = pcim_iomap(pdev, 2, 0);
|
|
if (!ast->ioregs)
|
|
return ERR_PTR(-EIO);
|
|
}
|
|
|
|
ast_detect_chip(dev, &need_post);
|
|
|
|
ret = ast_get_dram_info(dev);
|
|
if (ret)
|
|
return ERR_PTR(ret);
|
|
|
|
drm_info(dev, "dram MCLK=%u Mhz type=%d bus_width=%d\n",
|
|
ast->mclk, ast->dram_type, ast->dram_bus_width);
|
|
|
|
if (need_post)
|
|
ast_post_gpu(dev);
|
|
|
|
ret = ast_mm_init(ast);
|
|
if (ret)
|
|
return ERR_PTR(ret);
|
|
|
|
/* map reserved buffer */
|
|
ast->dp501_fw_buf = NULL;
|
|
if (dev->vram_mm->vram_size < pci_resource_len(pdev, 0)) {
|
|
ast->dp501_fw_buf = pci_iomap_range(pdev, 0, dev->vram_mm->vram_size, 0);
|
|
if (!ast->dp501_fw_buf)
|
|
drm_info(dev, "failed to map reserved buffer!\n");
|
|
}
|
|
|
|
ret = ast_mode_config_init(ast);
|
|
if (ret)
|
|
return ERR_PTR(ret);
|
|
|
|
ret = devm_add_action_or_reset(dev->dev, ast_device_release, ast);
|
|
if (ret)
|
|
return ERR_PTR(ret);
|
|
|
|
return ast;
|
|
}
|