Gao Xiang 097a802ae1 erofs: reduntant assignment in __erofs_get_meta_page() ... As Joe Perches suggested [1], err = bio_add_page(bio, page, PAGE_SIZE, 0); - if (unlikely(err != PAGE_SIZE)) { + if (err != PAGE_SIZE) { err = -EFAULT; goto err_out; } The initial assignment to err is odd as it's not actually an error value -E<FOO> but a int size from a unsigned int len. Here the return is either 0 or PAGE_SIZE. This would be more legible to me as: if (bio_add_page(bio, page, PAGE_SIZE, 0) != PAGE_SIZE) { err = -EFAULT; goto err_out; } [1] https://lore.kernel.org/r/74c4784319b40deabfbaea92468f7e3ef44f1c96.camel@perches.com/ Signed-off-by: Gao Xiang <gaoxiang25@huawei.com> Link: https://lore.kernel.org/r/20190829171741.225219-1-gaoxiang25@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-08-30 09:02:10 +02:00
..
compress.h
data.c	erofs: reduntant assignment in __erofs_get_meta_page()	2019-08-30 09:02:10 +02:00
decompressor.c
dir.c
erofs_fs.h
inode.c
internal.h
Kconfig
Makefile
namei.c
super.c
tagptr.h
utils.c
xattr.c
xattr.h
zdata.c
zdata.h
zmap.c
zpvec.h