mirror of
https://github.com/torvalds/linux.git
synced 2024-11-22 12:11:40 +00:00
2c92ca849f
With the rework of how the __string() handles dynamic strings where it
saves off the source string in field in the helper structure[1], the
assignment of that value to the trace event field is stored in the helper
value and does not need to be passed in again.
This means that with:
__string(field, mystring)
Which use to be assigned with __assign_str(field, mystring), no longer
needs the second parameter and it is unused. With this, __assign_str()
will now only get a single parameter.
There's over 700 users of __assign_str() and because coccinelle does not
handle the TRACE_EVENT() macro I ended up using the following sed script:
git grep -l __assign_str | while read a ; do
sed -e 's/\(__assign_str([^,]*[^ ,]\) *,[^;]*/\1)/' $a > /tmp/test-file;
mv /tmp/test-file $a;
done
I then searched for __assign_str() that did not end with ';' as those
were multi line assignments that the sed script above would fail to catch.
Note, the same updates will need to be done for:
__assign_str_len()
__assign_rel_str()
__assign_rel_str_len()
I tested this with both an allmodconfig and an allyesconfig (build only for both).
[1] https://lore.kernel.org/linux-trace-kernel/20240222211442.634192653@goodmis.org/
Link: https://lore.kernel.org/linux-trace-kernel/20240516133454.681ba6a0@rorschach.local.home
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Christian König <christian.koenig@amd.com> for the amdgpu parts.
Acked-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> #for
Acked-by: Rafael J. Wysocki <rafael@kernel.org> # for thermal
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Darrick J. Wong <djwong@kernel.org> # xfs
Tested-by: Guenter Roeck <linux@roeck-us.net>
84 lines
2.0 KiB
C
84 lines
2.0 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (c) 2015-2016, Intel Corporation. All rights reserved.
|
|
* Intel Management Engine Interface (Intel MEI) Linux driver
|
|
*/
|
|
|
|
#if !defined(_MEI_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _MEI_TRACE_H_
|
|
|
|
#include <linux/stringify.h>
|
|
#include <linux/types.h>
|
|
#include <linux/tracepoint.h>
|
|
|
|
#include <linux/device.h>
|
|
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM mei
|
|
|
|
TRACE_EVENT(mei_reg_read,
|
|
TP_PROTO(const struct device *dev, const char *reg, u32 offs, u32 val),
|
|
TP_ARGS(dev, reg, offs, val),
|
|
TP_STRUCT__entry(
|
|
__string(dev, dev_name(dev))
|
|
__field(const char *, reg)
|
|
__field(u32, offs)
|
|
__field(u32, val)
|
|
),
|
|
TP_fast_assign(
|
|
__assign_str(dev);
|
|
__entry->reg = reg;
|
|
__entry->offs = offs;
|
|
__entry->val = val;
|
|
),
|
|
TP_printk("[%s] read %s:[%#x] = %#x",
|
|
__get_str(dev), __entry->reg, __entry->offs, __entry->val)
|
|
);
|
|
|
|
TRACE_EVENT(mei_reg_write,
|
|
TP_PROTO(const struct device *dev, const char *reg, u32 offs, u32 val),
|
|
TP_ARGS(dev, reg, offs, val),
|
|
TP_STRUCT__entry(
|
|
__string(dev, dev_name(dev))
|
|
__field(const char *, reg)
|
|
__field(u32, offs)
|
|
__field(u32, val)
|
|
),
|
|
TP_fast_assign(
|
|
__assign_str(dev);
|
|
__entry->reg = reg;
|
|
__entry->offs = offs;
|
|
__entry->val = val;
|
|
),
|
|
TP_printk("[%s] write %s[%#x] = %#x",
|
|
__get_str(dev), __entry->reg, __entry->offs, __entry->val)
|
|
);
|
|
|
|
TRACE_EVENT(mei_pci_cfg_read,
|
|
TP_PROTO(const struct device *dev, const char *reg, u32 offs, u32 val),
|
|
TP_ARGS(dev, reg, offs, val),
|
|
TP_STRUCT__entry(
|
|
__string(dev, dev_name(dev))
|
|
__field(const char *, reg)
|
|
__field(u32, offs)
|
|
__field(u32, val)
|
|
),
|
|
TP_fast_assign(
|
|
__assign_str(dev);
|
|
__entry->reg = reg;
|
|
__entry->offs = offs;
|
|
__entry->val = val;
|
|
),
|
|
TP_printk("[%s] pci cfg read %s:[%#x] = %#x",
|
|
__get_str(dev), __entry->reg, __entry->offs, __entry->val)
|
|
);
|
|
|
|
#endif /* _MEI_TRACE_H_ */
|
|
|
|
/* This part must be outside protection */
|
|
#undef TRACE_INCLUDE_PATH
|
|
#undef TRACE_INCLUDE_FILE
|
|
#define TRACE_INCLUDE_PATH .
|
|
#define TRACE_INCLUDE_FILE mei-trace
|
|
#include <trace/define_trace.h>
|