mirror of
https://github.com/torvalds/linux.git
synced 2024-11-22 04:02:20 +00:00
f0baf76a22
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). In the error path emit an error message replacing the (less useful) message by the core. Apart from the improved error message there is no change in behaviour. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/1d16e93a498831abd64df8b8cf54fd8872cdd1cd.1701619134.git.u.kleine-koenig@pengutronix.de Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
159 lines
3.7 KiB
C
159 lines
3.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Detection routine for the NCR53c710 based MVME16x SCSI Controllers for Linux.
|
|
*
|
|
* Based on work by Alan Hourihane
|
|
*
|
|
* Rewritten to use 53c700.c by Kars de Jong <jongk@linux-m68k.org>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/blkdev.h>
|
|
#include <linux/device.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/init.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/slab.h>
|
|
#include <asm/mvme16xhw.h>
|
|
#include <scsi/scsi_host.h>
|
|
#include <scsi/scsi_device.h>
|
|
#include <scsi/scsi_transport.h>
|
|
#include <scsi/scsi_transport_spi.h>
|
|
|
|
#include "53c700.h"
|
|
|
|
MODULE_AUTHOR("Kars de Jong <jongk@linux-m68k.org>");
|
|
MODULE_DESCRIPTION("MVME16x NCR53C710 driver");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
static struct scsi_host_template mvme16x_scsi_driver_template = {
|
|
.name = "MVME16x NCR53c710 SCSI",
|
|
.proc_name = "MVME16x",
|
|
.this_id = 7,
|
|
.module = THIS_MODULE,
|
|
};
|
|
|
|
static struct platform_device *mvme16x_scsi_device;
|
|
|
|
static int mvme16x_probe(struct platform_device *dev)
|
|
{
|
|
struct Scsi_Host * host = NULL;
|
|
struct NCR_700_Host_Parameters *hostdata;
|
|
|
|
if (!MACH_IS_MVME16x)
|
|
goto out;
|
|
|
|
if (mvme16x_config & MVME16x_CONFIG_NO_SCSICHIP) {
|
|
printk(KERN_INFO "mvme16x-scsi: detection disabled, "
|
|
"SCSI chip not present\n");
|
|
goto out;
|
|
}
|
|
|
|
hostdata = kzalloc(sizeof(struct NCR_700_Host_Parameters), GFP_KERNEL);
|
|
if (hostdata == NULL) {
|
|
printk(KERN_ERR "mvme16x-scsi: "
|
|
"Failed to allocate host data\n");
|
|
goto out;
|
|
}
|
|
|
|
/* Fill in the required pieces of hostdata */
|
|
hostdata->base = (void __iomem *)0xfff47000UL;
|
|
hostdata->clock = 50; /* XXX - depends on the CPU clock! */
|
|
hostdata->chip710 = 1;
|
|
hostdata->dmode_extra = DMODE_FC2;
|
|
hostdata->dcntl_extra = EA_710;
|
|
hostdata->ctest7_extra = CTEST7_TT1;
|
|
|
|
/* and register the chip */
|
|
host = NCR_700_detect(&mvme16x_scsi_driver_template, hostdata,
|
|
&dev->dev);
|
|
if (!host) {
|
|
printk(KERN_ERR "mvme16x-scsi: No host detected; "
|
|
"board configuration problem?\n");
|
|
goto out_free;
|
|
}
|
|
host->this_id = 7;
|
|
host->base = 0xfff47000UL;
|
|
host->irq = MVME16x_IRQ_SCSI;
|
|
if (request_irq(host->irq, NCR_700_intr, 0, "mvme16x-scsi", host)) {
|
|
printk(KERN_ERR "mvme16x-scsi: request_irq failed\n");
|
|
goto out_put_host;
|
|
}
|
|
|
|
/* Enable scsi chip ints */
|
|
{
|
|
volatile unsigned long v;
|
|
|
|
/* Enable scsi interrupts at level 4 in PCCchip2 */
|
|
v = in_be32(0xfff4202c);
|
|
v = (v & ~0xff) | 0x10 | 4;
|
|
out_be32(0xfff4202c, v);
|
|
}
|
|
|
|
platform_set_drvdata(dev, host);
|
|
scsi_scan_host(host);
|
|
|
|
return 0;
|
|
|
|
out_put_host:
|
|
scsi_host_put(host);
|
|
out_free:
|
|
kfree(hostdata);
|
|
out:
|
|
return -ENODEV;
|
|
}
|
|
|
|
static void mvme16x_device_remove(struct platform_device *dev)
|
|
{
|
|
struct Scsi_Host *host = platform_get_drvdata(dev);
|
|
struct NCR_700_Host_Parameters *hostdata = shost_priv(host);
|
|
|
|
/* Disable scsi chip ints */
|
|
{
|
|
volatile unsigned long v;
|
|
|
|
v = in_be32(0xfff4202c);
|
|
v &= ~0x10;
|
|
out_be32(0xfff4202c, v);
|
|
}
|
|
scsi_remove_host(host);
|
|
NCR_700_release(host);
|
|
kfree(hostdata);
|
|
free_irq(host->irq, host);
|
|
}
|
|
|
|
static struct platform_driver mvme16x_scsi_driver = {
|
|
.driver = {
|
|
.name = "mvme16x-scsi",
|
|
},
|
|
.probe = mvme16x_probe,
|
|
.remove_new = mvme16x_device_remove,
|
|
};
|
|
|
|
static int __init mvme16x_scsi_init(void)
|
|
{
|
|
int err;
|
|
|
|
err = platform_driver_register(&mvme16x_scsi_driver);
|
|
if (err)
|
|
return err;
|
|
|
|
mvme16x_scsi_device = platform_device_register_simple("mvme16x-scsi",
|
|
-1, NULL, 0);
|
|
if (IS_ERR(mvme16x_scsi_device)) {
|
|
platform_driver_unregister(&mvme16x_scsi_driver);
|
|
return PTR_ERR(mvme16x_scsi_device);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void __exit mvme16x_scsi_exit(void)
|
|
{
|
|
platform_device_unregister(mvme16x_scsi_device);
|
|
platform_driver_unregister(&mvme16x_scsi_driver);
|
|
}
|
|
|
|
module_init(mvme16x_scsi_init);
|
|
module_exit(mvme16x_scsi_exit);
|