linux

mirror of https://github.com/torvalds/linux.git synced 2024-11-23 04:31:50 +00:00

A mirror of the official Linux kernel repository just in case

Go to file

Liang Chen 0646dc31ca skbuff: Fix a race between coalescing and releasing SKBs Commit `1effe8ca4e` ("skbuff: fix coalescing for page_pool fragment recycling") allowed coalescing to proceed with non page pool page and page pool page when @from is cloned, i.e. to->pp_recycle --> false from->pp_recycle --> true skb_cloned(from) --> true However, it actually requires skb_cloned(@from) to hold true until coalescing finishes in this situation. If the other cloned SKB is released while the merging is in process, from_shinfo->nr_frags will be set to 0 toward the end of the function, causing the increment of frag page _refcount to be unexpectedly skipped resulting in inconsistent reference counts. Later when SKB(@to) is released, it frees the page directly even though the page pool page is still in use, leading to use-after-free or double-free errors. So it should be prohibited. The double-free error message below prompted us to investigate: BUG: Bad page state in process swapper/1 pfn:0e0d1 page:00000000c6548b28 refcount:-1 mapcount:0 mapping:0000000000000000 index:0x2 pfn:0xe0d1 flags: 0xfffffc0000000(node=0\|zone=1\|lastcpupid=0x1fffff) raw: 000fffffc0000000 0000000000000000 ffffffff00000101 0000000000000000 raw: 0000000000000002 0000000000000000 ffffffffffffffff 0000000000000000 page dumped because: nonzero _refcount CPU: 1 PID: 0 Comm: swapper/1 Tainted: G E 6.2.0+ Call Trace: <IRQ> dump_stack_lvl+0x32/0x50 bad_page+0x69/0xf0 free_pcp_prepare+0x260/0x2f0 free_unref_page+0x20/0x1c0 skb_release_data+0x10b/0x1a0 napi_consume_skb+0x56/0x150 net_rx_action+0xf0/0x350 ? __napi_schedule+0x79/0x90 __do_softirq+0xc8/0x2b1 __irq_exit_rcu+0xb9/0xf0 common_interrupt+0x82/0xa0 </IRQ> <TASK> asm_common_interrupt+0x22/0x40 RIP: 0010:default_idle+0xb/0x20 Fixes: `53e0961da1` ("page_pool: add frag page recycling support in page pool") Signed-off-by: Liang Chen <liangchen.linux@gmail.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://lore.kernel.org/r/20230413090353.14448-1-liangchen.linux@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2023-04-13 10:08:42 -07:00
arch	bpf-for-netdev	2023-04-07 18:23:37 -07:00
block	block: remove obsolete config BLOCK_COMPAT	2023-03-16 09:35:44 -06:00
certs	Kbuild updates for v6.3	2023-02-26 11:53:25 -08:00
crypto	asymmetric_keys: log on fatal failures in PE/pkcs7	2023-03-21 16:23:56 +00:00
Documentation	tcp: restrict net.ipv4.tcp_app_win	2023-04-07 08:19:11 +01:00
drivers	net: macb: fix a memory corruption in extended buffer descriptor mode	2023-04-13 10:05:07 -07:00
fs	nfsd-6.3 fixes:	2023-04-04 11:20:55 -07:00
include	rtnetlink: Restore RTM_NEW/DELLINK notification behavior	2023-04-12 20:47:58 -07:00
init	bootconfig: Change message if no bootconfig with CONFIG_BOOT_CONFIG_FORCE=y	2023-03-22 22:21:43 +09:00
io_uring	io_uring-6.3-2023-03-30	2023-03-31 12:30:13 -07:00
ipc	Merge branch 'work.namespace' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2023-02-24 19:20:07 -08:00
kernel	tracing: Free error logs of tracing instances	2023-04-05 09:54:37 -04:00
lib	Fixes for 6.3-rc3:	2023-03-25 12:57:34 -07:00
LICENSES	LICENSES: Add the copyleft-next-0.3.1 license	2022-11-08 15:44:01 +01:00
mm	21 hotfixes, 8 of which are cc:stable. 11 are for MM, the remainder are	2023-03-24 18:06:11 -07:00
net	skbuff: Fix a race between coalescing and releasing SKBs	2023-04-13 10:08:42 -07:00
rust	Rust fixes for 6.3-rc1	2023-03-03 14:51:15 -08:00
samples	LoongArch changes for v6.3	2023-03-01 09:27:00 -08:00
scripts	Kbuild fixes for v6.3 (2nd)	2023-04-01 09:25:17 -07:00
security	keys: Do not cache key in task struct if key is requested from kernel thread	2023-03-21 16:22:40 +00:00
sound	ALSA: hda/hdmi: Preserve the previous PCM device upon re-enablement	2023-04-01 18:05:48 +02:00
tools	selftests: add the missing CONFIG_IP_SCTP in net config	2023-04-13 10:04:55 -07:00
usr	usr/gen_init_cpio.c: remove unnecessary -1 values from int file	2022-10-03 14:21:44 -07:00
virt	KVM: PPC: Make KVM_CAP_IRQFD_RESAMPLE platform dependent	2023-03-31 11:19:05 -04:00
.clang-format	cpumask: re-introduce constant-sized cpumask optimizations	2023-03-05 14:30:34 -08:00
.cocciconfig
.get_maintainer.ignore	get_maintainer: add Alan to .get_maintainer.ignore	2022-08-20 15:17:44 -07:00
.gitattributes	.gitattributes: use 'dts' diff driver for *.dtso files	2023-02-26 15:28:23 +09:00
.gitignore	kbuild: rpm-pkg: move source components to rpmbuild/SOURCES	2023-03-16 22:45:56 +09:00
.mailmap	mailmap: add entries for Richard Leitner	2023-03-23 17:18:35 -07:00
.rustfmt.toml	rust: add `.rustfmt.toml`	2022-09-28 09:02:20 +02:00
COPYING
CREDITS	There is no particular theme here - mainly quick hits all over the tree.	2023-02-23 17:55:40 -08:00
Kbuild	Kbuild updates for v6.1	2022-10-10 12:00:45 -07:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	Driver core fixes for 6.3-rc5	2023-04-02 10:10:16 -07:00
Makefile	Linux 6.3-rc5	2023-04-02 14:29:29 -07:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.