mirror of
https://github.com/torvalds/linux.git
synced 2024-12-27 13:22:23 +00:00
8ee775f92c
Macros with hidden flow control are bad form as the code path
taken can be unexpected for the reader.
Expand these in-place and remove the macros.
Done with coccinelle script:
@@
expression chip;
expression arg1;
expression arg2;
expression arg3;
@@
- RTSX_WRITE_REG(chip, arg1, arg2, arg3);
+ retval = rtsx_write_register(chip, arg1, arg2, arg3);
+ if (retval) {
+ rtsx_trace(chip);
+ return retval;
+ }
@@
expression chip;
expression arg1;
expression arg2;
@@
- RTSX_READ_REG(chip, arg1, arg2);
+ retval = rtsx_read_register(chip, arg1, arg2);
+ if (retval) {
+ rtsx_trace(chip);
+ return retval;
+ }
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
||
|---|---|---|
| .. | ||
| general.c | ||
| general.h | ||
| Kconfig | ||
| Makefile | ||
| ms.c | ||
| ms.h | ||
| rtsx_card.c | ||
| rtsx_card.h | ||
| rtsx_chip.c | ||
| rtsx_chip.h | ||
| rtsx_scsi.c | ||
| rtsx_scsi.h | ||
| rtsx_sys.h | ||
| rtsx_transport.c | ||
| rtsx_transport.h | ||
| rtsx.c | ||
| rtsx.h | ||
| sd.c | ||
| sd.h | ||
| spi.c | ||
| spi.h | ||
| TODO | ||
| trace.c | ||
| trace.h | ||
| xd.c | ||
| xd.h | ||