Li Nan 98c598afc2 nbd: pass nbd_sock to nbd_read_reply() instead of index ... If a socket is processing ioctl 'NBD_SET_SOCK', config->socks might be krealloc in nbd_add_socket(), and a garbage request is received now, a UAF may occurs. T1 nbd_ioctl __nbd_ioctl nbd_add_socket blk_mq_freeze_queue T2 recv_work nbd_read_reply sock_xmit krealloc config->socks def config->socks Pass nbd_sock to nbd_read_reply(). And introduce a new function sock_xmit_recv(), which differs from sock_xmit only in the way it get socket. ================================================================== BUG: KASAN: use-after-free in sock_xmit+0x525/0x550 Read of size 8 at addr ffff8880188ec428 by task kworker/u12:1/18779 Workqueue: knbd4-recv recv_work Call Trace: __dump_stack dump_stack+0xbe/0xfd print_address_description.constprop.0+0x19/0x170 __kasan_report.cold+0x6c/0x84 kasan_report+0x3a/0x50 sock_xmit+0x525/0x550 nbd_read_reply+0xfe/0x2c0 recv_work+0x1c2/0x750 process_one_work+0x6b6/0xf10 worker_thread+0xdd/0xd80 kthread+0x30a/0x410 ret_from_fork+0x22/0x30 Allocated by task 18784: kasan_save_stack+0x1b/0x40 kasan_set_track set_alloc_info __kasan_kmalloc __kasan_kmalloc.constprop.0+0xf0/0x130 slab_post_alloc_hook slab_alloc_node slab_alloc __kmalloc_track_caller+0x157/0x550 __do_krealloc krealloc+0x37/0xb0 nbd_add_socket +0x2d3/0x880 __nbd_ioctl nbd_ioctl+0x584/0x8e0 __blkdev_driver_ioctl blkdev_ioctl+0x2a0/0x6e0 block_ioctl+0xee/0x130 vfs_ioctl __do_sys_ioctl __se_sys_ioctl+0x138/0x190 do_syscall_64+0x33/0x40 entry_SYSCALL_64_after_hwframe+0x61/0xc6 Freed by task 18784: kasan_save_stack+0x1b/0x40 kasan_set_track+0x1c/0x30 kasan_set_free_info+0x20/0x40 __kasan_slab_free.part.0+0x13f/0x1b0 slab_free_hook slab_free_freelist_hook slab_free kfree+0xcb/0x6c0 krealloc+0x56/0xb0 nbd_add_socket+0x2d3/0x880 __nbd_ioctl nbd_ioctl+0x584/0x8e0 __blkdev_driver_ioctl blkdev_ioctl+0x2a0/0x6e0 block_ioctl+0xee/0x130 vfs_ioctl __do_sys_ioctl __se_sys_ioctl+0x138/0x190 do_syscall_64+0x33/0x40 entry_SYSCALL_64_after_hwframe+0x61/0xc6 Signed-off-by: Li Nan <linan122@huawei.com> Reviewed-by: Yu Kuai <yukuai3@huawei.com> Reviewed-by: Ming Lei <ming.lei@redhat.com> Link: https://lore.kernel.org/r/20230911023308.3467802-1-linan666@huaweicloud.com Signed-off-by: Jens Axboe <axboe@kernel.dk>		2023-11-21 07:42:04 -07:00
..
aoe	aoe: replace strncpy with strscpy	2023-10-03 18:23:48 -06:00
drbd	hardening updates for v6.7-rc1	2023-10-30 19:09:55 -10:00
mtip32xx	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00
null_blk	block/null_blk: Fix double blk_mq_start_request() warning	2023-11-20 10:26:26 -07:00
rnbd	rnbd-srv: Convert to use bdev_open_by_path()	2023-10-28 13:29:17 +02:00
xen-blkback	xen/blkback: Convert to bdev_open_by_dev()	2023-10-28 13:29:17 +02:00
zram	zram: Convert to use bdev_open_by_dev()	2023-10-28 13:29:17 +02:00
amiflop.c	amiflop: don't call fsync_bdev in FDFMTBEG	2023-08-21 14:35:31 +02:00
ataflop.c	block: move bdev_mark_dead out of disk_check_media_change	2023-10-28 13:29:23 +02:00
brd.c	brd: use cond_resched instead of cond_resched_rcu	2023-06-14 11:13:07 -06:00
floppy.c	block: move bdev_mark_dead out of disk_check_media_change	2023-10-28 13:29:23 +02:00
Kconfig	block: ublk: switch to ioctl command encoding	2023-04-18 20:13:30 -06:00
loop.c	v6.6-vfs.super	2023-08-28 11:04:18 -07:00
Makefile	Revert "pktcdvd: remove driver."	2023-01-04 14:44:13 -07:00
n64cart.c	block: remove blk_cleanup_disk	2022-06-28 06:33:15 -06:00
nbd.c	nbd: pass nbd_sock to nbd_read_reply() instead of index	2023-11-21 07:42:04 -07:00
pktcdvd.c	pktcdvd: Convert to bdev_open_by_dev()	2023-10-28 13:29:17 +02:00
ps3disk.c	block: remove blk_cleanup_disk	2022-06-28 06:33:15 -06:00
ps3vram.c	ps3vram: remove bio splitting	2023-01-29 15:18:35 -07:00
rbd_types.h
rbd.c	rbd: take header_rwsem in rbd_dev_refresh() only when updating	2023-09-26 10:33:19 +02:00
sunvdc.c	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00
swim3.c	swim3: mark swim3_init() static	2023-08-10 08:32:59 -06:00
swim_asm.S
swim.c	swim: fix a missing FMODE_ -> BLK_OPEN_ conversion in floppy_open	2023-06-20 07:16:04 -06:00
ublk_drv.c	block: ublk_drv: Remove unused function	2023-10-19 05:24:02 -06:00
virtio_blk.c	vhost,virtio,vdpa: features, fixes, cleanups	2023-11-05 09:02:32 -10:00
xen-blkfront.c	for-6.5/block-2023-06-23	2023-06-26 12:47:20 -07:00
z2ram.c	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00