mirror of
https://github.com/torvalds/linux.git
synced 2024-12-15 15:41:58 +00:00
c46fc0424c
Zorro reported following crash while having enabled syscall tracing (CONFIG_FTRACE_SYSCALLS): Unable to handle kernel pointer dereference at virtual ... Oops: 0011 [#1] SMP DEBUG_PAGEALLOC SNIP Call Trace: ([<000000000024d79c>] ftrace_syscall_enter+0xec/0x1d8) [<00000000001099c6>] do_syscall_trace_enter+0x236/0x2f8 [<0000000000730f1c>] sysc_tracesys+0x1a/0x32 [<000003fffcf946a2>] 0x3fffcf946a2 INFO: lockdep is turned off. Last Breaking-Event-Address: [<000000000022dd44>] rb_event_data+0x34/0x40 ---[ end trace 8c795f86b1b3f7b9 ]--- The crash happens in syscall_get_arguments function for syscalls with zero arguments, that will try to access first argument (args[0]) in event entry, but it's not allocated. Bail out of there are no arguments. Cc: stable@vger.kernel.org Reported-by: Zorro Lang <zlang@redhat.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
107 lines
2.5 KiB
C
107 lines
2.5 KiB
C
/*
|
|
* Access to user system call parameters and results
|
|
*
|
|
* Copyright IBM Corp. 2008
|
|
* Author(s): Martin Schwidefsky (schwidefsky@de.ibm.com)
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License (version 2 only)
|
|
* as published by the Free Software Foundation.
|
|
*/
|
|
|
|
#ifndef _ASM_SYSCALL_H
|
|
#define _ASM_SYSCALL_H 1
|
|
|
|
#include <uapi/linux/audit.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/err.h>
|
|
#include <asm/ptrace.h>
|
|
|
|
/*
|
|
* The syscall table always contains 32 bit pointers since we know that the
|
|
* address of the function to be called is (way) below 4GB. So the "int"
|
|
* type here is what we want [need] for both 32 bit and 64 bit systems.
|
|
*/
|
|
extern const unsigned int sys_call_table[];
|
|
extern const unsigned int sys_call_table_emu[];
|
|
|
|
static inline long syscall_get_nr(struct task_struct *task,
|
|
struct pt_regs *regs)
|
|
{
|
|
return test_pt_regs_flag(regs, PIF_SYSCALL) ?
|
|
(regs->int_code & 0xffff) : -1;
|
|
}
|
|
|
|
static inline void syscall_rollback(struct task_struct *task,
|
|
struct pt_regs *regs)
|
|
{
|
|
regs->gprs[2] = regs->orig_gpr2;
|
|
}
|
|
|
|
static inline long syscall_get_error(struct task_struct *task,
|
|
struct pt_regs *regs)
|
|
{
|
|
return IS_ERR_VALUE(regs->gprs[2]) ? regs->gprs[2] : 0;
|
|
}
|
|
|
|
static inline long syscall_get_return_value(struct task_struct *task,
|
|
struct pt_regs *regs)
|
|
{
|
|
return regs->gprs[2];
|
|
}
|
|
|
|
static inline void syscall_set_return_value(struct task_struct *task,
|
|
struct pt_regs *regs,
|
|
int error, long val)
|
|
{
|
|
regs->gprs[2] = error ? error : val;
|
|
}
|
|
|
|
static inline void syscall_get_arguments(struct task_struct *task,
|
|
struct pt_regs *regs,
|
|
unsigned int i, unsigned int n,
|
|
unsigned long *args)
|
|
{
|
|
unsigned long mask = -1UL;
|
|
|
|
/*
|
|
* No arguments for this syscall, there's nothing to do.
|
|
*/
|
|
if (!n)
|
|
return;
|
|
|
|
BUG_ON(i + n > 6);
|
|
#ifdef CONFIG_COMPAT
|
|
if (test_tsk_thread_flag(task, TIF_31BIT))
|
|
mask = 0xffffffff;
|
|
#endif
|
|
while (n-- > 0)
|
|
if (i + n > 0)
|
|
args[n] = regs->gprs[2 + i + n] & mask;
|
|
if (i == 0)
|
|
args[0] = regs->orig_gpr2 & mask;
|
|
}
|
|
|
|
static inline void syscall_set_arguments(struct task_struct *task,
|
|
struct pt_regs *regs,
|
|
unsigned int i, unsigned int n,
|
|
const unsigned long *args)
|
|
{
|
|
BUG_ON(i + n > 6);
|
|
while (n-- > 0)
|
|
if (i + n > 0)
|
|
regs->gprs[2 + i + n] = args[n];
|
|
if (i == 0)
|
|
regs->orig_gpr2 = args[0];
|
|
}
|
|
|
|
static inline int syscall_get_arch(void)
|
|
{
|
|
#ifdef CONFIG_COMPAT
|
|
if (test_tsk_thread_flag(current, TIF_31BIT))
|
|
return AUDIT_ARCH_S390;
|
|
#endif
|
|
return AUDIT_ARCH_S390X;
|
|
}
|
|
#endif /* _ASM_SYSCALL_H */
|