mirror of
https://github.com/torvalds/linux.git
synced 2024-10-23 05:30:55 +00:00
2c92ca849f
With the rework of how the __string() handles dynamic strings where it
saves off the source string in field in the helper structure[1], the
assignment of that value to the trace event field is stored in the helper
value and does not need to be passed in again.
This means that with:
__string(field, mystring)
Which use to be assigned with __assign_str(field, mystring), no longer
needs the second parameter and it is unused. With this, __assign_str()
will now only get a single parameter.
There's over 700 users of __assign_str() and because coccinelle does not
handle the TRACE_EVENT() macro I ended up using the following sed script:
git grep -l __assign_str | while read a ; do
sed -e 's/\(__assign_str([^,]*[^ ,]\) *,[^;]*/\1)/' $a > /tmp/test-file;
mv /tmp/test-file $a;
done
I then searched for __assign_str() that did not end with ';' as those
were multi line assignments that the sed script above would fail to catch.
Note, the same updates will need to be done for:
__assign_str_len()
__assign_rel_str()
__assign_rel_str_len()
I tested this with both an allmodconfig and an allyesconfig (build only for both).
[1] https://lore.kernel.org/linux-trace-kernel/20240222211442.634192653@goodmis.org/
Link: https://lore.kernel.org/linux-trace-kernel/20240516133454.681ba6a0@rorschach.local.home
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Christian König <christian.koenig@amd.com> for the amdgpu parts.
Acked-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> #for
Acked-by: Rafael J. Wysocki <rafael@kernel.org> # for thermal
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Darrick J. Wong <djwong@kernel.org> # xfs
Tested-by: Guenter Roeck <linux@roeck-us.net>
108 lines
2.2 KiB
C
108 lines
2.2 KiB
C
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM iscsi
|
|
|
|
#if !defined(_TRACE_ISCSI_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_ISCSI_H
|
|
|
|
#include <linux/tracepoint.h>
|
|
|
|
/* max debug message length */
|
|
#define ISCSI_MSG_MAX 256
|
|
|
|
/*
|
|
* Declare tracepoint helper function.
|
|
*/
|
|
void iscsi_dbg_trace(void (*trace)(struct device *dev, struct va_format *),
|
|
struct device *dev, const char *fmt, ...);
|
|
|
|
/*
|
|
* Declare event class for iscsi debug messages.
|
|
*/
|
|
DECLARE_EVENT_CLASS(iscsi_log_msg,
|
|
|
|
TP_PROTO(struct device *dev, struct va_format *vaf),
|
|
|
|
TP_ARGS(dev, vaf),
|
|
|
|
TP_STRUCT__entry(
|
|
__string(dname, dev_name(dev) )
|
|
__vstring(msg, vaf->fmt, vaf->va)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__assign_str(dname);
|
|
__assign_vstr(msg, vaf->fmt, vaf->va);
|
|
),
|
|
|
|
TP_printk("%s: %s",__get_str(dname), __get_str(msg)
|
|
)
|
|
);
|
|
|
|
/*
|
|
* Define event to capture iscsi connection debug messages.
|
|
*/
|
|
DEFINE_EVENT(iscsi_log_msg, iscsi_dbg_conn,
|
|
TP_PROTO(struct device *dev, struct va_format *vaf),
|
|
|
|
TP_ARGS(dev, vaf)
|
|
);
|
|
|
|
/*
|
|
* Define event to capture iscsi session debug messages.
|
|
*/
|
|
DEFINE_EVENT(iscsi_log_msg, iscsi_dbg_session,
|
|
TP_PROTO(struct device *dev, struct va_format *vaf),
|
|
|
|
TP_ARGS(dev, vaf)
|
|
);
|
|
|
|
/*
|
|
* Define event to capture iscsi error handling debug messages.
|
|
*/
|
|
DEFINE_EVENT(iscsi_log_msg, iscsi_dbg_eh,
|
|
TP_PROTO(struct device *dev, struct va_format *vaf),
|
|
|
|
TP_ARGS(dev, vaf)
|
|
);
|
|
|
|
/*
|
|
* Define event to capture iscsi tcp debug messages.
|
|
*/
|
|
DEFINE_EVENT(iscsi_log_msg, iscsi_dbg_tcp,
|
|
TP_PROTO(struct device *dev, struct va_format *vaf),
|
|
|
|
TP_ARGS(dev, vaf)
|
|
);
|
|
|
|
/*
|
|
* Define event to capture iscsi sw tcp debug messages.
|
|
*/
|
|
DEFINE_EVENT(iscsi_log_msg, iscsi_dbg_sw_tcp,
|
|
TP_PROTO(struct device *dev, struct va_format *vaf),
|
|
|
|
TP_ARGS(dev, vaf)
|
|
);
|
|
|
|
/*
|
|
* Define event to capture iscsi transport session debug messages.
|
|
*/
|
|
DEFINE_EVENT(iscsi_log_msg, iscsi_dbg_trans_session,
|
|
TP_PROTO(struct device *dev, struct va_format *vaf),
|
|
|
|
TP_ARGS(dev, vaf)
|
|
);
|
|
|
|
/*
|
|
* Define event to capture iscsi transport connection debug messages.
|
|
*/
|
|
DEFINE_EVENT(iscsi_log_msg, iscsi_dbg_trans_conn,
|
|
TP_PROTO(struct device *dev, struct va_format *vaf),
|
|
|
|
TP_ARGS(dev, vaf)
|
|
);
|
|
|
|
#endif /* _TRACE_ISCSI_H */
|
|
|
|
/* This part must be outside protection */
|
|
#include <trace/define_trace.h>
|