Oleksij Rempel d0c3601f2c net: macb: Avoid 20s boot delay by skipping MDIO bus registration for fixed-link PHY ... A boot delay was introduced by commit 79540d133e ("net: macb: Fix handling of fixed-link node"). This delay was caused by the call to `mdiobus_register()` in cases where a fixed-link PHY was present. The MDIO bus registration triggered unnecessary PHY address scans, leading to a 20-second delay due to attempts to detect Clause 45 (C45) compatible PHYs, despite no MDIO bus being attached. The commit 79540d133e ("net: macb: Fix handling of fixed-link node") was originally introduced to fix a regression caused by commit 7897b071ac ("net: macb: convert to phylink"), which caused the driver to misinterpret fixed-link nodes as PHY nodes. This resulted in warnings like: mdio_bus f0028000.ethernet-ffffffff: fixed-link has invalid PHY address mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 0 ... mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 31 This patch reworks the logic to avoid registering and allocation of the MDIO bus when: - The device tree contains a fixed-link node. - There is no "mdio" child node in the device tree. If a child node named "mdio" exists, the MDIO bus will be registered to support PHYs attached to the MACB's MDIO bus. Otherwise, with only a fixed-link, the MDIO bus is skipped. Tested on a sama5d35 based system with a ksz8863 switch attached to macb0. Fixes: 79540d133e ("net: macb: Fix handling of fixed-link node") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Cc: stable@vger.kernel.org Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/20241013052916.3115142-1-o.rempel@pengutronix.de Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-10-15 10:40:47 -07:00
..
Kconfig	ethernet: fix PTP_1588_CLOCK dependencies	2021-08-13 17:49:05 -07:00
macb_main.c	net: macb: Avoid 20s boot delay by skipping MDIO bus registration for fixed-link PHY	2024-10-15 10:40:47 -07:00
macb_pci.c	net: macb: Use predefined PCI vendor ID constant	2024-09-13 20:08:53 -07:00
macb_ptp.c	net: macb: Convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()	2023-11-18 14:52:57 +00:00
macb.h	net: macb: Convert tasklet API to new bottom half workqueue mechanism	2024-07-31 18:59:46 -07:00
Makefile