Commit Graph

348287 Commits

Author SHA1 Message Date
Kevin McKinney
684fb7e6f0 Staging: bcm: Remove typedef for _LED_INFO_STRUCT and call directly.
This patch removes typedef for _LED_INFO_STRUCT, and changes
the name of the struct to bcm_led_info. In addition,
any calls to struct LED_INFO_STRUCT, or *PLED_INFO_STRUCT
are changed to call directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:51:50 -08:00
Kevin McKinney
a6f0b530e5 Staging: bcm: Replace UINT with unsigned int in led_control.h
This patch replaces "UINT" with "unsigned int" in
led_control.h.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:51:50 -08:00
Kevin McKinney
df3d870f57 Staging: bcm: Replace BOOLEAN with bool in led_control.h
This patch replaces "BOOLEAN" with "bool" in
led_control.h.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:51:50 -08:00
Kevin McKinney
3549a173dc Staging: bcm: Replace UCHAR with unsigned char in led_control.h
This patch replace "UCHAR" with "unsigned
char" in led_control.h

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:51:49 -08:00
Kevin McKinney
20dcfc5358 Staging: bcm: Fix warning: "do {} while (0) macros should not be semicolon terminated" in led_control.h
This patch properly fixes the warning "do {} while
(0) macros should not be semicolon terminated" as
reported by checkpath.pl

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:51:49 -08:00
Kevin McKinney
48ac0ca5ae Staging: bcm: Properly format comments as needed in led_control.h
This patch formats all comments, and remove them
as needed in led_control.h.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:51:49 -08:00
Kevin McKinney
67c6603827 Staging: bcm: Fix all white space issues in led_control.h
This patch fixes all white space issues in
led_control.h as reported by checkpatch.pl.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:51:49 -08:00
Kevin McKinney
9d4cf71fbd Staging: bcm: Remove typedef for IPV6HeaderFormatTag and call directly.
This patch removes typedef IPV6HeaderFormatTag,
and changes the name of the struct to bcm_ipv6_hdr.
In addition, any calls to typedef IPV6Header
are changed to call the struct directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:02 -08:00
Kevin McKinney
8f0652c255 Staging: bcm: Remove typedef for IPV6RoutingHeaderFormatTag and call directly.
This patch removes typedef IPV6RoutingHeaderFormatTag,
and changes the name of the struct to bcm_ipv6_routing_hdr.
In addition, any calls to typedef IPV6RoutingHeader
are changed to call the struct directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:02 -08:00
Kevin McKinney
17d7fd271a Staging: bcm: Remove typedef for IPV6FragmentHeaderFormatTag and call directly.
This patch removes typedef IPV6FragmentHeaderFormatTag,
and changes the name of the struct to bcm_ipv6_fragment_hdr.
In addition, any calls to typedef IPV6FragmentHeader
are changed to call the struct directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:02 -08:00
Kevin McKinney
d69438df32 Staging: bcm: Remove typedef for IPV6DestOptionsHeaderFormatTag and call directly.
This patch removes typedef IPV6DestOptionsHeaderFormatTag,
and changes the name of the struct to bcm_ipv6_dest_options_hdr.
In addition, any calls to typedef IPV6DestOptionsHeader
are changed to call the struct directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:02 -08:00
Kevin McKinney
bc25b75153 Staging: bcm: Remove typedef for IPV6HopByHopOptionsHeaderFormatTag and call directly.
This patch removes typedef IPV6HopByHopOptionsHeaderFormatTag,
and changes the name of the struct to bcm_ipv6_options_hdr.
In addition, any calls to typedef IPV6HopByHopOptionsHeader
are changed to call the struct directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:02 -08:00
Kevin McKinney
5601bb9da5 Staging: bcm: Remove typedef for IPV6AuthenticationHeaderFormatTag and call directly.
This patch removes typedef for IPV6AuthenticationHeaderFormatTag,
and changes the name of the struct to bcm_ipv6_authentication_hdr
In addition, any calls to typedef IPV6AuthenticationHeader, are
changed to call the struct directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:02 -08:00
Kevin McKinney
ceebf54d2e Staging: bcm: Remove typedef for IPV6IcmpHeaderFormatTag.
This patch removes typedef for IPV6IcmpHeaderFormatTag
because it is not being used.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:01 -08:00
Kevin McKinney
dbadab2684 Staging: bcm: Remove typedef for _E_IPADDR_CONTEXT and call directly.
This patch removes typedef for _E_IPADDR_CONTEXT, and changes
the name of the enum to bcm_ipaddr_context. In addition,
any calls to enum E_IPADDR_CONTEXT are changed to call
directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:01 -08:00
Kevin McKinney
16806309fe Staging: bcm: Replace BOOLEAN with bool in IPv6ProtocolHdr.h
This patch replaces "BOOLEAN" with "bool" in
IPv6ProtocolHdr.h, and any other required
files.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:01 -08:00
Kevin McKinney
b66cf16013 Staging: bcm: Replace VOID with void in IPv6ProtocolHdr.h
This patch replaces "VOID" with "void" in
IPv6ProtocolHdr.h.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:01 -08:00
Kevin McKinney
3ee5afde0e Staging: bcm: Replace PVOID with void * in IPv6ProtocolHdr.h
This patch replaces "PVOID" with "void *" in
IPv6ProtocolHdr.h.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:01 -08:00
Kevin McKinney
67b587cd94 Staging: bcm: Replace UCHAR with unsigned char in IPv6ProtocolHdr.h
This patch replaces "UCHAR" with "unsigned char" in
IPv6ProtocolHdr.h.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:01 -08:00
Kevin McKinney
828c1dd5de Staging: bcm: Replace ULONG with unsigned long in IPv6ProtocolHdr.h
This patch replaces "ULONG" with "unsigned long" in
IPv6ProtocolHdr.h.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:00 -08:00
Kevin McKinney
5ef43c3bf6 Staging: bcm: Replace USHORT with unsigned short in IPv6ProtocolHdr.h
This patch replace "USHORT" with "unsigned
short" in IPv6ProtocolHdr.h

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:00 -08:00
Kevin McKinney
eb379dae37 Staging: bcm: Properly format braces in IPv6ProtocolHdr.h
This patch properly formats braces in IPv6ProtocolHdr.h
as reported by checkpath.pl

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:00 -08:00
Kevin McKinney
5cc3dead2a Staging: bcm: Properly format and remove comments as needed in IPv6ProtocolHdr.h
This patch formats all comments and removes
them as needed.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:00 -08:00
Kevin McKinney
d83beb86f4 Staging: bcm: Fix all white space issues in IPv6ProtocolHdr.h
This patch fixes all white space issues in
IPv6ProtocolHdr.h as reported by checkpatch.pl.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:49:00 -08:00
Kevin McKinney
7e5df051d4 Staging: bcm: Remove unnecessary comments in CmHost.h
This patch removes unnecessary comments that
appear to be added as part of an annotation
system.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:47:10 -08:00
Kevin McKinney
1fb14c4276 Staging: bcm: Replace unsigned long long with u64 in Ioctl.h
This patch replaces "unsigned long long" with
u64" in Ioctl.h.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:47:10 -08:00
Kevin McKinney
44d8311272 Staging: bcm: Remove typedef for _FLASH_SECTOR_INFO.
This patch removes typedef for _FLASH_SECTOR_INFO
because it is not being used.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:51 -08:00
Kevin McKinney
168b14009a Staging: bcm: Remove typedef for _FLASH_CS_INFO and call directly.
This patch removes typedef for _FLASH_CS_INFO, and
changes the name of the struct to bcm_flash_cs_info.
In addition, any calls to typedefs FLASH_CS_INFO, or
*PFLASH_CS_INFO are changed to call the struct
directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:51 -08:00
Kevin McKinney
08391731e0 Staging: bcm: Remove typedef for _FLASH_2X_CS_INFO and call directly.
This patch removes typedef for _FLASH_2X_CS_INFO, and
changes the name of the struct to bcm_flash2x_cs_info.
In addition, any calls to typedefs FLASH2X_CS_INFO, or
*PFLASH2X_CS_INFO are changed to call the struct
directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:51 -08:00
Kevin McKinney
ad2f522cc6 Staging: bcm: Remove typedef for _VENDOR_SECTION_INFO and call directly.
This patch removes typedef for _VENDOR_SECTION_INFO, and
changes the name of the struct to bcm_vendor_section_info.
In addition, any calls to typedefs VENDOR_SECTION_INFO, or
*PVENDOR_SECTION_INFO are changed to call the struct
directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:50 -08:00
Kevin McKinney
2fe119fd35 Staging: bcm: Remove typedef for _FLASH2X_VENDORSPECIFIC_INFO and call directly.
This patch removes typedef for _FLASH2X_VENDORSPECIFIC_INFO,
and changes the name of the struct to bcm_flash2x_vendor_info.
In addition, any calls to typedefs FLASH2X_VENDORSPECIFIC_INFO,
or *PFLASH2X_VENDORSPECIFIC_INFO are changed to call the
struct directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:50 -08:00
Kevin McKinney
77b54101b5 Staging: bcm: Remove typedef for _DSD_HEADER and call directly.
This patch removes typedef for _DSD_HEADER, and changes
the name of the struct to bcm_dsd_header. In addition,
any calls to typedefs DSD_HEADER, or *PDSD_HEADER are
changed to call the struct directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:50 -08:00
Kevin McKinney
be5e219dcd Staging: bcm: Remove typedef for _ISO_HEADER and call directly.
This patch removes typedef for _ISO_HEADER, and changes
the name of the struct to bcm_iso_header. In addition,
any calls to typedefs ISO_HEADER, or *PISO_HEADER are
changed to call the struct directly.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:50 -08:00
Kevin McKinney
20a2ae8019 Staging: bcm: Replace PUCHAR with u8 * in nmv.h
This patch replaces "PUCHAR" with "u8 *" in
nvm.h.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:50 -08:00
Kevin McKinney
b5ec04ed75 Staging: bcm: Replace UINT with unsigned int in nvm.h
This patch replaces "UINT" with "unsigned
int" in nvm.h.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:50 -08:00
Kevin McKinney
6f98775fe9 Staging: bcm: Replace B_UINT32 with u32 in nvm.h
This patch replace "B_UINT32" with "u32" in
nvm.h

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:49 -08:00
Kevin McKinney
e5b2445e46 Staging: bcm: Enclose complex values in parenthesis in nvm.h
This patch fixes the warning: "Macros with complex values
should be enclosed in parenthesis" as reported by
checkpatch.pl

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:49 -08:00
Kevin McKinney
72a57c08b5 Staging: bcm: Properly format braces in nvm.h
This patch properly formats braces in nvm.h as
reported by checkpath.pl

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:49 -08:00
Kevin McKinney
04ac0434c1 Staging: bcm: Properly format and remove comments as needed in nvm.h
This patch formats all comments and removes
them as needed.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:49 -08:00
Kevin McKinney
0a42577ddf Staging: bcm: Fix all white space issues in nvm.h
This patch fixes all white space issues in
nvm.h as reported by checkpatch.pl.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07 10:45:49 -08:00
Greg Kroah-Hartman
ecc3599396 First round of IIO new stuff and cleanups for 3.9
Here we have:
 * RTC driver for the hid-sensor hubs.  This is routed through here with
   agreement of Jiri Kosina and Andrew Morton.
 * Some small patches doing dead code removal and fixing some comments.
 * max1363 - move to the triggered_buffer helpers (basically duplicate code
   removal).
 * lp8788 - parent device change from the i2c device to the intermediate mfd.
 
 So the bulk of what we have is actually outside the IIO tree but the RTC
 driver in question is dependent on some patches that directly effect IIO so
 I am routing it through IIO with the agreement of the relevant maintainers
 (Andrew is acting as maintainer of RTC at the moment).  The majority of
 HID-sensor related code is in IIO and it now crosses 3 subsystems so it
 was going to be a bit awkward whatever route it took.
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (GNU/Linux)
 
 iQIcBAABAgAGBQJQ6adzAAoJEFSFNJnE9BaIdXUP/3evWP7pfIME87JWjG7/jE4G
 OD1Wv5S0Iq7qJUYrd1GD4jeGleXQbsWfb956mXG3CyVMWzZhn5Yfn6rLYCBwET+7
 NYDh/4e5qLzcdENtqMrXYlb+PNMnv07lCsOhxTHEm8EaqkaQBd+AYZTm8qWaADt8
 Cd26ItGPLAgWlyaskF1dfu0sZAR2C7s4dBqqGdD7Yt/pk8jF7AllCcPKgZ48vhBI
 oVP2Gmxs5Tt2CtmOhJMrtx+u5SqMyOyIgf6BFxVSjTBBDyD3uBBZ/VqlKVkBOCE6
 DeCoBjkEuu0nnI6akygcQLHPa3MbLYum42WaSLX12VG4ZMcxYwRoimzSPwDDeSyP
 oJd8V9RhvlqOHbvKo2aF6gDYRkVd2RXo32B8xrpB8WvAuI/EEYn/1BpeV8WkPph3
 hngFV20r7pevm5mtjdRK+1tx8Vp8NjpWp0Y/dwfsbr6F4LJMa2cKfpKQWHoD51ZK
 LNy4lRLTEP0iJWpUE752Zt0FBFpTJO65nsHQ6QkWELRBxJ0WjM9yy3ArWxBz1EPv
 gzbWJpT4B3XnKn5qx0TZ0tCPqTAeqVlHAUwp4VxhQMaa+qxWKDjvhKO58GaEifep
 9yv7sVhUo4sULNIMW0dT6stu/dAA5ygGu1Y387t+ZTQEv8gdGNljAua7bVNbQYxJ
 qqTTsjwx/rX+8NxQbPJh
 =vBZ+
 -----END PGP SIGNATURE-----

Merge tag 'iio-for-3.9a' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next

Jonathan says:

	First round of IIO new stuff and cleanups for 3.9

	Here we have:
	* RTC driver for the hid-sensor hubs.  This is routed through here with
	  agreement of Jiri Kosina and Andrew Morton.
	* Some small patches doing dead code removal and fixing some comments.
	* max1363 - move to the triggered_buffer helpers (basically duplicate code
	  removal).
	* lp8788 - parent device change from the i2c device to the intermediate mfd.

	So the bulk of what we have is actually outside the IIO tree but the RTC
	driver in question is dependent on some patches that directly effect IIO so
	I am routing it through IIO with the agreement of the relevant maintainers
	(Andrew is acting as maintainer of RTC at the moment).  The majority of
	HID-sensor related code is in IIO and it now crosses 3 subsystems so it
	was going to be a bit awkward whatever route it took.
2013-01-07 09:53:39 -08:00
Alexander Holler
e07c6d170c hid: iio: rename struct hid_sensor_iio_common to hid_sensor_common
The structure with common attributes for hid-sensors isn't specific
to the iio-subsystem, so rename it to hid_sensor_common.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2013-01-06 11:48:11 +00:00
Alexander Holler
62e00cb9a3 rtc: add rtc-driver for HID sensors of type time
This driver makes the time from HID sensors (hubs) which are offering
such available like any other RTC does.

It is necessary that all values like year, month etc, are send as
8bit values (1 byte each) and all of them in 1 report. Also the
spec HUTRR39b doesn't define the range of the year field, we
tread it as 0 - 99 because that's what most RTCs I know about are
offering.

Currently the time can only be read. Setting the time must be done
through sending a report (or a feature). The spec currently doesn't
define how and I'm not sure if I just should define something by myself.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2013-01-06 11:46:10 +00:00
Alexander Holler
2974cdf293 iio: merge hid-sensor-attributes.h into hid-sensor-hub.h
The stuff in hid-sensor-attributes.h is needed by every piece which
uses hid-sensor-hub and merging it into hid-sensor-hub.h makes it accessible
from outside the iio subdirectory.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2013-01-06 11:43:37 +00:00
Alexander Holler
8e3cdca26c iio: Add Usage IDs for HID time sensors.
These are Usage IDs for the attributes year, month, day,
hour, minute and second, needed to read HID time sensors.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2013-01-06 11:41:12 +00:00
Kim, Milo
5306f416ad iio: lp8788_adc: fix parent device in kernel message
Use 'dev' of iio device in a kernel message rather than i2c client device node.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2013-01-06 11:35:31 +00:00
Kim, Milo
dc11699908 iio: lp8788_adc: fix a parent device in _probe()
The lp8788-adc is a platform driver of lp8788-mfd.
 The platform device is allocated when mfd_add_devices() is called
 in lp8788-mfd.
 On the other hand, 'lp->dev' is the i2c client device.

 Therefore, this 'platform_device' is a proper parent device of
 iio device and device kernel message.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2013-01-06 11:35:30 +00:00
Linus Torvalds
d1c3ed669a Linux 3.8-rc2 2013-01-02 18:13:21 -08:00
Linus Torvalds
d50403dcc5 Merge branch 'fixes-for-3.8' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds
Pull LED fix from Bryan Wu.

* 'fixes-for-3.8' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds:
  leds: leds-gpio: set devm_gpio_request_one() flags param correctly
2013-01-02 18:12:35 -08:00
Javier Martinez Canillas
2d7c22f67d leds: leds-gpio: set devm_gpio_request_one() flags param correctly
commit a99d76f leds: leds-gpio: use gpio_request_one

changed the leds-gpio driver to use gpio_request_one() instead
of gpio_request() + gpio_direction_output()

Unfortunately, it also made a semantic change that breaks the
leds-gpio driver.

The gpio_request_one() flags parameter was set to:

GPIOF_DIR_OUT | (led_dat->active_low ^ state)

Since GPIOF_DIR_OUT is 0, the final flags value will just be the
XOR'ed value of led_dat->active_low and state.

This value were used to distinguish between HIGH/LOW output initial
level and call gpio_direction_output() accordingly.

With this new semantic gpio_request_one() will take the flags value
of 1 as a configuration of input direction (GPIOF_DIR_IN) and will
call gpio_direction_input() instead of gpio_direction_output().

int gpio_request_one(unsigned gpio, unsigned long flags, const char *label)
{
..
	if (flags & GPIOF_DIR_IN)
		err = gpio_direction_input(gpio);
	else
		err = gpio_direction_output(gpio,
				(flags & GPIOF_INIT_HIGH) ? 1 : 0);
..
}

The right semantic is to evaluate led_dat->active_low ^ state and
set the output initial level explicitly.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reported-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
2013-01-02 17:58:41 -08:00