ext4: Use is_power_of_2() for clarity

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
This commit is contained in:
Theodore Ts'o 2009-04-24 23:31:59 -04:00
parent c5ca7c7636
commit f7c439504c

View File

@ -1483,7 +1483,7 @@ set_qf_format:
return 0;
if (option < 0 || option > (1 << 30))
return 0;
if (option & (option - 1)) {
if (!is_power_of_2(option)) {
printk(KERN_ERR "EXT4-fs: inode_readahead_blks"
" must be a power of 2\n");
return 0;
@ -2101,8 +2101,7 @@ static ssize_t inode_readahead_blks_store(struct ext4_attr *a,
if (parse_strtoul(buf, 0x40000000, &t))
return -EINVAL;
/* inode_readahead_blks must be a power of 2 */
if (t & (t-1))
if (!is_power_of_2(t))
return -EINVAL;
sbi->s_inode_readahead_blks = t;