ALSA: usb-audio: Use kmemdup_array instead of kmemdup for multiple allocation

Let the kmemdup_array() take care about multiplication
and possible overflows.

Using kmemdup_array() is more appropriate and makes the code
easier to audit.

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
Link: https://patch.msgid.link/20240826043454.3198-1-shenlichuan@vivo.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Shen Lichuan 2024-08-26 12:34:54 +08:00 committed by Takashi Iwai
parent b29ba8f1f9
commit f7b1633d64

View File

@ -167,8 +167,8 @@ static int create_fixed_stream_quirk(struct snd_usb_audio *chip,
return -EINVAL;
}
if (fp->nr_rates > 0) {
rate_table = kmemdup(fp->rate_table,
sizeof(int) * fp->nr_rates, GFP_KERNEL);
rate_table = kmemdup_array(fp->rate_table, fp->nr_rates, sizeof(int),
GFP_KERNEL);
if (!rate_table) {
kfree(fp);
return -ENOMEM;