Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 20:22:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

sysfs: kobject_put cleanup

Browse Source 
This patch removes redundant argument checks for kobject_put().

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Mariusz Kozlowski 2007-01-02 13:41:10 +01:00 committed by Greg Kroah-Hartman
parent d3fc373ac5
commit f750653670
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/sysfs/bin.c
View File

@ -147,7 +147,7 @@ static int open(struct inode * inode, struct file * file)
Error:
module_put(attr->attr.owner);
Done:
if (error && kobj)
if (error)
kobject_put(kobj);
return error;
}
@ -158,8 +158,7 @@ static int release(struct inode * inode, struct file * file)
struct bin_attribute * attr = to_bin_attr(file->f_path.dentry);
u8 * buffer = file->private_data;
if (kobj)
kobject_put(kobj);
kobject_put(kobj);
module_put(attr->attr.owner);
kfree(buffer);
return 0;

5
fs/sysfs/file.c
View File

@ -361,7 +361,7 @@ static int sysfs_open_file(struct inode *inode, struct file *file)
error = -EACCES;
module_put(attr->owner);
Done:
if (error && kobj)
if (error)
kobject_put(kobj);
return error;
}
@ -375,8 +375,7 @@ static int sysfs_release(struct inode * inode, struct file * filp)
if (buffer)
remove_from_collection(buffer, inode);
if (kobj)
kobject_put(kobj);
kobject_put(kobj);
/* After this point, attr should not be accessed. */
module_put(owner);