Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-06 20:21:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

PCI aerdrv: fix annoying warnings

Browse Source 
Some compiler generates following warnings:

  In function 'aer_isr':
  warning: 'e_src.id' may be used uninitialized in this function
  warning: 'e_src.status' may be used uninitialized in this function

Avoid status flag "int ret" and return constants instead, so that
gcc sees the return value matching "it is initialized" better.

Acked-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
This commit is contained in:
Linus Torvalds 2010-05-27 11:21:11 +09:00 committed by Jesse Barnes
parent 73cd3b43f0
commit f6735590e9
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/pci/pcie/aer/aerdrv_core.c
View File

@ -727,20 +727,21 @@ static void aer_isr_one_error(struct pcie_device *p_device,
static int get_e_source(struct aer_rpc *rpc, struct aer_err_source *e_src) static int get_e_source(struct aer_rpc *rpc, struct aer_err_source *e_src)
{ {
unsigned long flags; unsigned long flags;
int ret = 0;
/* Lock access to Root error producer/consumer index */ /* Lock access to Root error producer/consumer index */
spin_lock_irqsave(&rpc->e_lock, flags); spin_lock_irqsave(&rpc->e_lock, flags);
if (rpc->prod_idx != rpc->cons_idx) { if (rpc->prod_idx == rpc->cons_idx) {
*e_src = rpc->e_sources[rpc->cons_idx]; spin_unlock_irqrestore(&rpc->e_lock, flags);
rpc->cons_idx++; return 0;
if (rpc->cons_idx == AER_ERROR_SOURCES_MAX)
rpc->cons_idx = 0;
ret = 1;
} }
*e_src = rpc->e_sources[rpc->cons_idx];
rpc->cons_idx++;
if (rpc->cons_idx == AER_ERROR_SOURCES_MAX)
rpc->cons_idx = 0;
spin_unlock_irqrestore(&rpc->e_lock, flags); spin_unlock_irqrestore(&rpc->e_lock, flags);
return ret; return 1;
} }
/** /**